September 2025 - Koha-bugs - lists.koha-community.org

[Bug 40847] New: OAuth endpoint missing some validations
by bugzilla-daemon＠bugs.koha-community.org 23 Sep '25

23 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 Bug ID: 40847 Summary: OAuth endpoint missing some validations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com I found the endpoint would benefit from more validations on: * Provider * Interface This is not properly tested either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 40852] New: Add option of allowing holds to be placed by patrons in OPAC for lost items
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40852 Bug ID: 40852 Summary: Add option of allowing holds to be placed by patrons in OPAC for lost items Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: director(a)fairfield.lib.ia.us QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle(a)bywatersolutions.com Adding the option of allowing patrons to place holds on lost items would aid library staff in determining when lost items should be considered for replacement sooner. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 40851] New: Keep "Place a Hold" tab at top of Normal Detail view for lost items
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40851 Bug ID: 40851 Summary: Keep "Place a Hold" tab at top of Normal Detail view for lost items Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: director(a)fairfield.lib.ia.us QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle(a)bywatersolutions.com Created attachment 186737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186737&action=e… Item with lost status without hold option at top Currently, if an item has been marked "lost", when viewing this item in the staff module in the normal detail view, the "place a hold" option that is ordinarily at the top of the screen is removed. This is tied to the item's status as lost. This is confusing for staff and seems unnecessary. Can a patch be created to keep the "place a hold" option at the top even for items marked lost? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 35956] New: In Vue [% INCLUDE 'calendar.inc' %] should not be needed if not used
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35956 Bug ID: 35956 Summary: In Vue [% INCLUDE 'calendar.inc' %] should not be needed if not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When doing bug 35919, I found that some recent change made it explode if I didn't add that include (look at the FIXME on koha-tmpl/intranet-tmpl/prog/en/modules/admin/record_sources.tt). -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Paul Derscheid <paul.derscheid(a)lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid(a)lmscloud.de --- Comment #564 from Paul Derscheid <paul.derscheid(a)lmscloud.de> --- This is actually not fully in 25.05.04 yet, just the fix for the Cypress test. I actually backported that cypress fix by accident. I must've confused it w/ another patch having the same commit message. Normally this wouldn't be backported as this is a new feature but since it was requested and people seem to look forward to it, I will make an exception. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 40849] New: Undesired printing effects in slips when branch notes are printed
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40849 Bug ID: 40849 Summary: Undesired printing effects in slips when branch notes are printed Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org This is going to be a hard one to explain. I'm using logic in HOLD_SLIP to determine if the hold is in house or a transfer, and then print the slip accordingly. We have done this for years. This has always worked fine. Recently, the slip has stopped printing the the extra space we print at the end of the slip to make the slip longer for books whenever the slip has notes from the library branch field. This is what I have determined: We have a line in the slip that prints the library notes after the library name. It looks like this: <h1>[% branch.branchname %]<br/> <i>[% branch.branchnotes %]</i></h1> Below that, this is what we use to lengthen the slip: [% blank = '   <br />' %] [% blank.repeat(25) %] If the library doesn't have any notes, the extra space prints fine. But if it does have notes, it omits the spacing. I have confirmed this by removing the second line for the notes and only printing the destination. If I remove the second line, it prints just fine. This also only seems to affect certain printers. I can print on the latest driver for Star TSP100III with the second line for notes just fine, but if I print with the latest driver for POS-X thermal printers, it is affected by this line. I am working with the POS-X vendor to see what they can find on their end and why their driver behaves differently, but for this extra info to affect the driver at all, I thought it might be worth filing a bug on and see if there is a problem with my coding or something in Koha itself that could be affecting printing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 30955] New: Send a notice to new owner when transferring shared list
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30955 Bug ID: 30955 Summary: Send a notice to new owner when transferring shared list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl See bug 25498. Would be helpful to send a notice to inform the new owner of this change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 53

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #37 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 186716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186716&action=e… Bug 3492: (follow-up) Remove last reservefee references Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #36 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 186715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186715&action=e… Bug 3492: Modernize hold fee system and migrate to circulation rules This commit completely modernizes the hold fee system by migrating from the deprecated categories.reservefee column to the circulation rules framework and implementing modern Koha::Objects patterns. WHAT CHANGED: 1. MIGRATION TO CIRCULATION RULES: - Moved hold fees from categories.reservefee to circulation_rules table - Added database migration script with atomic update - Maintains existing fee amounts during migration - Provides rule hierarchy: category+itemtype+branch specific rules 2. NEW SYSTEM PREFERENCE: TitleHoldFeeStrategy - Options: highest, lowest, most_common - Addresses inconsistent title-level hold fees when items have different fees - Default: 'highest' (safest approach for library revenue) 3. MODERN Koha::Objects API: - Koha::Item->holds_fee($patron): Calculate fee for specific item - Koha::Hold->calculate_hold_fee(): Enhanced item/title-level logic - Koha::Hold->should_charge($stage): Centralized charging logic - Koha::Hold->charge_hold_fee(): Modern fee charging with proper accounting - Removed C4::Reserves::GetReserveFee and ChargeReserveFee 4. ENHANCED FUNCTIONALITY: - Proper ReservesControlBranch logic (patron home vs item home library) - Complete HoldFeeMode implementation (placement/collection/not_always) - Clear OPAC messaging with "You will be charged..." commitment - Comprehensive test coverage for all fee scenarios 5. TECHNICAL IMPROVEMENTS: - Object-oriented design following Koha patterns - Proper error handling and edge case management - Modern test structure with comprehensive coverage - Clean separation between fee calculation and charging TEST PLAN: A) MIGRATION AND SETUP: 1. Apply all patches and run database update 2. Verify existing hold fees migrated to circulation rules: - Administration > Circulation and fine rules - Previous categories.reservefee values now in "Hold fee" column 3. Confirm old categories.reservefee column no longer used B) BASIC FEE CALCULATION: 1. Set up patron categories with different hold fees in circulation rules 2. Create items with different item types, each with different hold fees 3. Test item-level holds charge correct fees based on specific item 4. Test title-level holds use TitleHoldFeeStrategy preference C) TITLE-LEVEL HOLD STRATEGIES: 1. Set TitleHoldFeeStrategy to "highest": - Create title with items having fees $1.00, $2.00, $3.00 - Verify title-level holds charge $3.00 2. Set TitleHoldFeeStrategy to "lowest": - Verify same title charges $1.00 3. Set TitleHoldFeeStrategy to "most_common": - Add multiple items with $2.00 fee - Verify title-level holds charge $2.00 (most common) D) HOLDFEEMODE PREFERENCES: 1. Set HoldFeeMode to "any_time_is_placed": - Place holds and verify immediate fee charging - Check patron account for correct hold fee debits 2. Set HoldFeeMode to "any_time_is_collected": - Place holds, verify no immediate charges - Check out items to patron, verify fee charged on collection 3. Set HoldFeeMode to "not_always": - With available items: verify no fee charged - With all items checked out but no other holds: verify no fee - With all items checked out and other holds exist: verify fee charged E) RULE HIERARCHY TESTING: 1. Set different fees for different category/itemtype/branch combinations 2. Verify most specific rule applies: - Branch + Category + ItemType (most specific) - Category + ItemType - Category only (most general) 3. Test with different patron categories and item types F) USER INTERFACE TESTING: 1. OPAC interface: - Verify "You will be charged..." messages display correct amounts - Test both item-level and title-level hold fee messages - Confirm fees match actual charges in patron account 2. Staff interface: - Place holds for patrons and verify fee calculations - Check Administration > Circulation rules interface works correctly G) EDGE CASES AND ERROR HANDLING: 1. Test $0.00 fees (no charge scenarios) 2. Test patrons with no applicable fee rules (should default to $0.00) 3. Test items with no holdable copies (should return $0.00) 4. Test invalid/missing itemtypes or categories 5. Test holds on biblios with no items H) REGRESSION TESTING: 1. Verify existing hold placement workflows unchanged 2. Check patron account charging remains accurate 3. Confirm OPAC and staff interfaces display correctly 4. Test that existing holds continue to work properly I) UNIT TESTS: Run the following test suites to verify functionality: - prove t/db_dependent/Koha/Hold.t - prove t/db_dependent/Koha/Item.t - prove t/db_dependent/Reserves.t - prove t/db_dependent/Circulation.t BACKWARDS COMPATIBILITY: - All existing functionality preserved - Hold fee amounts maintained during migration - Existing workflows continue unchanged - Legacy code updated to use new API seamlessly Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 22 Sep '25

22 Sep '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 186714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186714&action=e… Bug 3492: Remove from patron categories admin Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> Signed-off-by: Tomás Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0