March 2026 - Koha-bugs - lists.koha-community.org

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12769] Manage fees for sending notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jacob.omara(a)openfifth.co.uk |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194272&action=e… Bug 4858: Refine OPAC print notice UX for patrons without an email address When a patron has no email address on file: - Print transport checkboxes are forced checked and disabled (print is the system fallback when no email exists); a hidden input ensures the print preference is submitted despite the checkbox being disabled. - Email transport checkboxes are disabled (there is no address to send to). Merge the two separate alert blocks (warning before the form, info after the table) into a single alert at the top of the page. Use alert-warning styling when the patron has no email address (charges will apply, no choice) and alert-info styling when they do have an email (charges are avoidable by selecting email delivery). Also move the has_print_transport calculation before the form so the unified alert can use it. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194271&action=e… Bug 4858: (QA follow-up) Miscellaneous fixes - Add print_notice_charge to Koha::Patron::Category to_api_mapping. - Remove over-defensive branchcode and letter_code regex validation in gather_print_notices.pl::apply_print_notice_charge; the data is internal (from GetPrintMessages DB query) and the regex could silently skip charges for libraries with spaces or special characters in their branchcode. - Fix cronlogaction indentation inside apply_print_notice_charge. - Move test file from t/db_dependent/Koha/Account/PrintNoticeCharges.t to t/db_dependent/Koha/Patron/PrintNoticeCharge.t to match the class being tested (Koha::Patron, not Koha::Account::PrintNoticeCharges). - Add missing trailing newline to t/db_dependent/PrintNoticeCharging_EndToEnd.t. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194270&action=e… Bug 4858: (QA follow-up) Fix high-priority issues - Remove duplicate 'use Scalar::Util' import introduced by this patch; the import already existed at line 26 of Koha/Patron.pm. - Pass notice_code as the note field on the add_debit call in add_print_notice_charge_if_needed. Previously the notice_code parameter was accepted but silently dropped, meaning all print notice charges looked identical in the account with no way to identify which letter triggered the charge. - Add print transport column to the OPAC messaging preferences table (opac-messaging.tt). The original patch added a print notice charging warning in the OPAC that told patrons to "uncheck print notice options" but never actually gave them a column to do so. This adds the print column to the OPAC table header and body rows (mirroring the staff messaging-preference-form.inc implementation), and adds a pmp_print JS click handler for the toggle_digest function, so patrons can opt out of print notices themselves. - Align PRINT_NOTICE debit type default_amount between fresh install and upgrade: account_debit_types.yml correctly set this to NULL (charge amount is per patron category, not a global default) but the atomicupdate was inserting 0.50. Changed atomicupdate to NULL. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194269&action=e… Bug 4858: (QA follow-up) Fix installer issues after rebase - Fix SQL syntax error in sample_notices_message_transports.sql: the print transport row for RETURN_RECALLED_ITEM was terminated with a semicolon instead of a comma, prematurely ending the INSERT statement and leaving the three MEMBERSHIP_EXPIRY rows as invalid bare tuples. This would break fresh installations by failing to insert those rows. - Fix atomicupdate ALTER TABLE AFTER clause: the column was being added AFTER reservefee which does not exist in the categories table (it exists on items). This would cause the ALTER TABLE to fail on all upgrades. Changed to AFTER overduenoticerequired to match the column order in kohastructure.sql. Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194268&action=e… Bug 4858: DO NOT PUSH - DBIC Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194267&action=e… Bug 4858: Add print_notice_charge to categories api definition Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194266&action=e… Bug 4858: Add print message transports to installer and atomic update Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4858] Ability to Charge for Print Notices
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194265&action=e… Bug 4858: Messaging print preference should be checked by default Sponsored-by: OpenFifth <https://openfifth.co.uk\> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0