- Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #135 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 151139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151139&action=e… Bug 8179: Remove commented code Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #134 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 151138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151138&action=e… Bug 8179: Make partial receive work correctly Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151026|0 |1 is obsolete| | Attachment #151086|0 |1 is obsolete| | Attachment #151087|0 |1 is obsolete| | Attachment #151088|0 |1 is obsolete| | Attachment #151089|0 |1 is obsolete| | Attachment #151092|0 |1 is obsolete| | Attachment #151093|0 |1 is obsolete| | --- Comment #133 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 151137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151137&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Laura Escamilla <laura.escamilla(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22428] New: MARC modification template cuts text to 100 characters
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Bug ID: 22428 Summary: MARC modification template cuts text to 100 characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When trying to update a field using a MARC modification template, it is impossible to put a value of over 100 characters. To reproduce: 1. Go to Tools > MARC modification templates 2. Click on 'New template' 3. Name your new template and click on 'Submit' 4. Click on 'New action' 5. Enter the following information in the form - 'Add new' - field(s): 856 y - with value: Organization-wide access - sign on to OnePass / Accès à l'échelle de l'organisation - Ouvrez une session (OnePass) 6. Click on Add action 7. Note that the text is cut in the displayed table 'Organization-wide access - sign on to OnePass / Accès à l'échelle de l'organisation - Ouvrez une ses' 8. Do a search to obtain a biblionumber 1. Make a search in the catalog 2. Click on the title to go to the detailed record 3. Click on the 'MARC' tab 4. The biblionumber is written next to MARC record: 5. Copy the biblionumber 9. Go to Tools > Batch record modification 10. In the 'List of biblionumbers...' text box, paste the biblionumber 11. Choose the template created at step 3 in the 'Modify record using the following template:' drop down menu 12. Click on 'Continue' 13. Click on 'Show MARC' to see the result of the modification (the added line is usually at the bottom, note that the text is still cut after 100 characters, so not only a display bug) 14. Click on 'Close' 15. Click on 'Modify selected records' 16. Click on the biblionumber to see the modified record 17. In the detailed record, the 856y field is under 'Online resources' (note that the text is still cut) I noticed that in the database, the field field_value in the table marc_modification_template_actions is limited to 100 characters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 21043, which changed state. Bug 21043 Summary: Add routes to add debits to a patron's account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 33724] New: Expand explanations of terms used in ERM module
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33724 Bug ID: 33724 Summary: Expand explanations of terms used in ERM module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: Needs documenting Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aude.charillon(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The manual should better explain what each available field on the Agreements and Licenses screen mean and what they can be used for. Also clarify the difference between Agreements and Licenses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 28126] New: Remove AllowPurchaseSuggestionBranchChoice from the Koha manual
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28126 Bug ID: 28126 Summary: Remove AllowPurchaseSuggestionBranchChoice from the Koha manual Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: erohlfs(a)equinoxinitiative.org QA Contact: testopia(a)bugs.koha-community.org In version 20.11, we saw the introduction of a new System Preference "OPACSuggestionUnwantedFields" and the removal of "AllowPurchaseSuggestionBranchChoice" via https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420 This is a request to remove the AllowPurchaseSuggestionBranchChoice description from the official Koha manual. https://koha-community.org/manual/20.11/en/html/systempreferences.html#allo… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 30213] New: Hide Delete (aka Priority) column when user only has place_hold permission
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug ID: 30213 Summary: Hide Delete (aka Priority) column when user only has place_hold permission Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: sbrown(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com With the change to holds permissions in Bug 29540, the Delete (or Priority, with full holds permissions) column isn't useful and is misleading for users with only the place_hold permission. They don't have the option to change holds' priority using the column, and if they select 'del' on a patron to delete their hold, they get locked out for having insufficient permissions when they click the Update Hold(s) button. But this is misleading because they *can* delete an individual hold using the red X. It would be clearer if that entire column were hidden for users with only the place_hold permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 32994] New: Remove compiled files from src 2
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Bug ID: 32994 Summary: Remove compiled files from src 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: mtj(a)kohaaloha.com small followup patch for bug 32609 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 44

[Bug 32975] New: Error in package.json's definition of css:build vs css:build:prod
by bugzilla-daemon＠bugs.koha-community.org 12 May '23

12 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975 Bug ID: 32975 Summary: Error in package.json's definition of css:build vs css:build:prod Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 32609 package.json defines these commands: "css:build": "gulp css && gulp css --view opac", "css:build:prod": "gulp build && gulp css --view opac", The second one, css:build:prod is not running the "build" process for the OPAC. It should say "gulp build --view opac" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 [Bug 32609] Remove compiled files from src -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17