- Koha-bugs - lists.koha-community.org

[Bug 30629] New: <span> in title of patron card creator template needs to be removed
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '22

09 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629 Bug ID: 30629 Summary: <span> in title of patron card creator template needs to be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org <title> elements are not allowed to have <span> elements, they show as such in the browser tab. There is a wrong span in the template for: /cgi-bin/koha/patroncards/manage.pl?card_element=template -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Tested on sandbox - Failed when creating a message: Error trace Template process failed: undef error - The method Koha::Patron::Message->patron_read_date is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Patron::Message=HASH(0x55c6e0dc8e60)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 223 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 223 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 243 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0x55c6e0c5ada0)', 'Template::Context=HASH(0x55c6ddb6d958)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)', 'patron_messages.inc', undef, 'localize me!') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 409 Template::Context::include('Template::Context=HASH(0x55c6ddb6d958)', 'patron_messages.inc') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt line 810 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0x55c6e1361ad0)', 'Template::Context=HASH(0x55c6ddb6d958)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)', 'Template::Document=HASH(0x55c6e1361ad0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 94 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 91 Template::Service::process('Template::Service=HASH(0x55c6e0c4a660)', '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt', 'HASH(0x55c6e0d30130)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template.pm line 66 Template::process('Template=HASH(0x55c6dd8a77f8)', '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt', 'HASH(0x55c6e0d30130)', 'SCALAR(0x55c6da300c50)') called at /kohadevbox/koha/C4/Templates.pm line 127 C4::Templates::output('C4::Templates=HASH(0x55c6e0d89578)') called at /kohadevbox/koha/circ/circulation.pl line 636 eval {...} at /kohadevbox/koha/circ/circulation.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::__ANON__('CGI::Compile=HASH(0x55c6ddb71328)', '', '/kohadevbox/koha/circ/circulation.pl', '/kohadevbox/koha/circ', 'ARRAY(0x55c6e0e46b48)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::circulation_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55c6e0db51f0)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55c6d6269cf8)', 'HASH(0x55c6dd8d05a8)', '/kohadevbox/koha/circ/circulation.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x55c6d6269cf8)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55c6dd8f9030)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55c6dd8f92d0)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x55c6e0e89608)', 'Try::Tiny::Catch=REF(0x55c6dd95a858)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x55c6dd8f9438)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x55c6dd8c9830)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x55c6dd933228)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x55c6dd8f8d78)', 'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 105 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x55c6dd8e4920)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x55c6dd8c9938)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x55c6dd590130)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x55c6d6269c20)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 38 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x55c6e09635e0)', 'Try::Tiny::Catch=REF(0x55c6e14df6d0)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x55c6dc7962a0)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x55c6dc795580)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x55c6dc795460)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x55c6d5c86e50)', 'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x55c6d5c86e50)', 'Net::Server::Proto::UNIX=GLOB(0x55c6dda3e8a0)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x55c6d5c86e50)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x55c6d5c86e50)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x55c6d5c86e50)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x55c6d5c86e50)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x55c6d5c86e50)', 'port', 'ARRAY(0x55c6d62147c0)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'bug12029-koha', 'group', 'bug12029-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'setsid', 1, 'log_file', '/var/log/koha/bug12029/plack-error.log', 'background', 1, 'pid_file', '/var/run/koha/bug12029/plack.pid') called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x55c6d5c86e50)', 'CODE(0x55c6d5c86d00)', 'HASH(0x55c6d5c86aa8)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x55c6d5c86d18)', 'CODE(0x55c6d5c86d00)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x55c6d59d8428)', 'Plack::Handler::Starman=HASH(0x55c6d5c86d18)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x55c6d5971760)') called at /usr/bin/starman line 38 at /kohadevbox/koha/C4/Templates.pm line 127 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ivan.marquez(a)autoparallel.c |oleonard(a)myacpl.org |om | --- Comment #32 from Owen Leonard <oleonard(a)myacpl.org> --- FYI I've changed the assignment to myself because Autoparallel had no interest in participating in the Bugzilla process. I've attached the last version of their patch and what I think is a mangled version of Hayley's followup. Everything seems to work correctly but I'm going to be cautious by asking for new signoffs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #31 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 137435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137435&action=e… Bug 12029: (follow-up) Adhering to coding guidelines This is a follow-up patch which (based on comment #19) does the following: 1) Removes newline from top of Koha/Patron/Messages.pm 2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread 3) Removes method Koha::Patron::Messages->unread_count 4) (Will address tests in separate patch) 5) Removes changes to Koha/Schema/Result/Message.pm 6) Changes atomicupdate from qq{} to q{} 7) (Left for RM) 8) Removes extra copyright statement in opac/dismiss_message.pl 9) Removes extra comments from opac/dismiss_message.pl 10) (Left for now) 11) (Left for now) Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130516|0 |1 is obsolete| | Attachment #132949|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 137434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137434&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27442] New: Circulation Module Report "Overdues" does not accurately show overdues by date
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442 Bug ID: 27442 Summary: Circulation Module Report "Overdues" does not accurately show overdues by date Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I believe the SQL is wrong in the hardcoded report "Overdue" under the Circulation Module. When a due date range is added when running the report, it is not showing the items that are overdue for a particular date, a library will need to run a range of 2 days to find out the day's overdue. Steps to Recreate: 1. Run Overdue report 2. Use the filter on the left to enter the date due to range of 10/12- 10/12. 3. No results are found with the actual date due to 10/12 4 Run the same report using the filter set at 10/12 - 10/13. 5 Koha will provide items that are due on 10/12. The SQL is looking at date_due rather than date(date_due) which is not giving accurate results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 [Bug 31121] Format date range on top of cashup summary page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Add a context-sensitive report a problem process
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31028 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalogue records -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27070] New: Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '22

08 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 Bug ID: 27070 Summary: Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com To recreate - be using Elasticsearch 6 in KOha On sample data try searching for: street shuffle cool, that works Now try searching for a word from title and the publisher name: shuffle constable No results, odd. Try searching for: shuffle AND constable That works. I cannot figure from the docs why this is the case - we pass a default operator, that should be enough I thought, but no. https://www.elastic.co/guide/en/elasticsearch/reference/6.8/query-dsl-query… for comparison: https://www.elastic.co/guide/en/elasticsearch/reference/5.6/query-dsl-query… After testing the type => 'cross_fields' seems to do what we want -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 35