- Koha-bugs - lists.koha-community.org

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I believe this is a good step in the right direction! There is a note in the QA tools about a POD error still: FAIL misc/cronjobs/advance_notices.pl OK critic OK forbidden patterns OK git manipulation FAIL pod *** WARNING: empty section in previous paragraph in file misc/cronjobs/advance_notices.pl If you get a chance today, please check if you can fix this as well! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115363|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 115586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115586&action=e… Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl This patch removes the double ups in the perldoc of the above file, deleting the less clear double ups. The missing "-c" in OPTIONS appears to have been fixed in an earlier patch (it is there already). Task Plan: 1. Run perldoc misc/cronjobs/advance_notices.pl in the terminal. Note the double ups of NAME, SYNOPSIS, and DESCRIPTION 2. Apply the patch 3. Run the command again. The double ups should be gone, with the more clear version of each of NAME, SYNOPSIS, and DESCRIPTION remaining. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115374|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 115585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115585&action=e… Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. https://bugs.koha-community.org/show_bug.cgi?id=27237 Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11257] Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Document <<items.content>> |Document <<items.content>> |for duedgst and preduedgst |for DUEDGST and PREDUEDGST |and update sample notices |and update sample notices --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi James, I really like the new version much better. I am going to sign off. Could you maybe do a follow up for the DUEDGST? Both are almost the same. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- In case it helps, here are the links I tested: /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OPACUserCSS=1 /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OPACUserJS=1 /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserCSS=1 /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserJS=1 /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_OpacAdditionalStylesheet=1 /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_opaclayoutstylesheet=1 /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_intranetcolorstylesheet=1 /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_intranetstylesheet=1 I also tested some doubling them up, e.g. /cgi-bin/koha/opac-main.pl?DISABLE_SYSPREF_opaclayoutstylesheet=1&DISABLE_SYSPREF_OPACUserJS=1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 --- Comment #8 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 115584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115584&action=e… Bug 14004: Add OpacAdditionalStylesheet and opaclayoutstylesheet Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115120|0 |1 is obsolete| | Attachment #115567|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 115583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115583&action=e… Bug 14004: Add ability to temporarily disable JS/CSS sysprefs It would be *super* handy if intranetuserjs and/or opacuserjs could be temporarily disabled via a check-box or syspref. Right now, debugging issues in intranetuserjs usuaally starts with copying the contents into a text file, blanking the syspref and re-testing. This patch adds this feature by setting syspref via ENV OVERRIDE_SYSPREF like override via Apache config. Implemented only for preferences : OPACUserCSS OPACUserJS IntranetUserCSS IntranetUserJS => replaced with ' ' intranetcolorstylesheet intranetstylesheet => replaced with 0 Test plan : 1) Set some CSS in IntranetUserCSS like : #breadcrumbs{color:red} 2) Go to staff interface home page like : /cgi-bin/koha/mainpage.pl 3) See CSS impact is visible 4) Edit URL : /cgi-bin/koha/mainpage.pl?DISABLE_SYSPREF_IntranetUserCSS=1 5) See CSS impact is not visible 6) Check with the other preferences Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '21

21 Jan '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0