- Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #666 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196876&action=e… Bug 10190: (follow-up) mtt formatting The Transport Type options when displaying in 'edit' mode were showing as a comma separated string rather than as separate options (as they do when being set). Ammends this so that they display as separate options consistently. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #665 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196875&action=e… Bug 10190: Fix false conflict error when editing specific trigger rules When editing a specific rule (e.g. */Kids/Books) alongside an all/all/all rule, the conflict check incorrectly reported a conflict. The effective=true API response always returns context as */*/* (fallback), so ruleSetInDb.context differed from currentRuleSet.context (which was overridden to the real context). Fix by overriding ruleSetInDb.context before the hasConflict comparison, consistent with the existing pattern in setCurrentRuleSet. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #664 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196874&action=e… Bug 10190: Fix patron_categories permission format The x-koha-authorization was using 'parameters: catalogue' which the Koha auth system interprets as a 'catalogue' subpermission within the 'parameters' module (which doesn't exist), causing a 403 for any user. The correct format for the top-level 'catalogue' permission is 'catalogue: "1"', consistent with all other read-only API endpoints. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #663 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196873&action=e… Bug 10190: Center tables in add modal Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #662 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196872&action=e… Bug 10190: Enforce manage_circ_rules_from_any_libraries permission - Add OR-type x-koha-authorization to /circulation_rules, /circulation_rules/kinds, and /circulation_rules/config endpoints so users with either circulate:circulate_remaining_permissions OR parameters:manage_circ_rules can access them - Enforce manage_circ_rules_from_any_libraries in the set_rules controller: users without this permission may only set rules for their own library and cannot set default (*) rules - Add explicit use C4::Auth qw(haspermission) import to CirculationRules.pm - Lock the library selector in the Vue UI for users who lack manage_circ_rules_from_any_libraries, defaulting them to their own library - Update set_rules() tests to cover the new permission restrictions Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #661 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196871&action=e… Bug 10190: (QA follow-up) Fix six issues reported during QA 1. Letter context: setFilteredLetters() was reading library_id from currentRuleSet (which has no top-level library_id property) instead of this.context.library_id, causing library-specific letter templates to never match. 2. False conflict on edit: conflict check fetched rule set from DB with effective=false (raw), but the in-memory snapshot was fetched with effective=true (with fallbacks). Comparing raw vs effective always triggered a conflict when a context inherited any value from a more general rule. Fixed by using effective=true for the DB fetch too. 3. Incomplete deletion: updateCircRuleSets() inside deleteRuleSet() was called without await, creating a race condition where the page refresh could complete before the deletion API call, leaving stale data visible. Also added a guard to skip rule sets with no explicit rules for the trigger being deleted, and simplified rulesForDeletion construction. 4. No rules displayed on initial load: the route watcher in CirculationTriggersList fired immediately before init() had loaded patron categories and item types, causing setAllExhaustiveEffectiveRuleSets() to produce an empty result. Fixed with a metaInitialized flag that the watcher waits for before proceeding. 5. DefaultToLoggedInLibraryOverdueTriggers syspref not respected: the default_view template variable was computed but never applied to the store's currentLibraryId. Fixed by passing it to init(). 6. UI colors: info box background changed from #84c1f3 to #DAECFB (lighter, matching the circulation rules page). Error alert messages changed from alert-info (blue) to alert-warning (yellow) to match Koha conventions. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #660 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196870&action=e… Bug 10190: Fix permission mismatch on /circulation_rules/config endpoint The config endpoint was gated on parameters: manage_circ_rules, while the actual GET/PUT /circulation_rules endpoints require circulate: circulate_remaining_permissions. Any user who can read/write circulation rules should also be able to load the config that drives the UI. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #659 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196869&action=e… Bug 10190: Patron categories fetch shouldn't require full manage permission Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #658 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196868&action=e… Bug 10190: fix failing Permissions.t and overhaul CirculationTriggers Cypress spec Permissions.t: - Remove edit_notice_status_triggers from userpermissions.sql so fresh installs no longer seed this deprecated permission (existing installs are handled by the atomic update) - Add a defensive DELETE in the test to cover DBs that pre-date the atomic update CirculationTriggers_spec.ts: - Fix getMockCirculationRule: the helper was returning the old {rule_name, rule_value, branchcode, ...} format; update to the current API format {context: {...}, overdue_N_delay: ..., ...} - Remove assertions for UI elements that do not exist (success/error flash messages, "Existing triggers" heading, "rule set will be removed" text) - Fix reset confirmation text to match actual component output - Fix duplicate patron_category_id "ST" in mock patron categories - Remove aspirational tests that checked non-implemented behaviour - Add describe block for the no-default-triggers warning (no rules anywhere, rules only at specific libraries, library link switches the filter) - Add regression test for NaN trigger number when adding first rule for a library Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '26

07 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #657 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 196867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196867&action=e… Bug 10190: Fix test count in overdues.t Signed-off-by: Michaela <michaela.sieber(a)kit.edu> -- You are receiving this mail because: You are watching all bug changes.

1 0