- Koha-bugs - lists.koha-community.org

[Bug 33514] New: breaks ISBN search in item search
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Bug ID: 33514 Summary: breaks ISBN search in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 23919 Item search is SQL based, not search engine based. When bug 23919 added SearchWithISSNVariations to item search, it broke all searches, but for one use case (that was tested): single ISBN, no ISBD punctuation. We are exploding the search now with up to 4 forms of ISBN into something like: isbn like 'isbn1' or isbn like 'isbn2' ... But: We are not truncating. As soon as there is more than one ISBN (this is a repeatable field) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. The data in biblioitems.isbn looks like this: isbn1 ; | isbn2 ; | isbn3. isbn1. This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search. I am not sure what is best, we could do something like this, which will make the search work again, but I think we also should make it a separate switch: @@ -1047,7 +1047,12 @@ sub _SearchItems_build_where_fragment { if ( C4::Context->preference("SearchWithISBNVariations") and $query ) { my @isbns = C4::Koha::GetVariationsOfISBN( $query ); $query = []; + foreach my $isbn(@isbns) { + $isbn = "%" . $isbn . "%"; + } Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 [Bug 23919] Make ISSN searchable with and without hyphen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #432 from Jonathan Druart <jonathan.druart(a)gmail.com> --- Last 4 patches pushed to main. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #431 from Jonathan Druart <jonathan.druart(a)gmail.com> --- Created attachment 195525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195525&action=e… Bug 38365: Fix Cypress tests ReferenceError: window is not defined at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:521:26 at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:523:3 at Object.<anonymous> (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:747:3) at Module._compile (node:internal/modules/cjs/loader:1521:14) at Module._extensions..js (node:internal/modules/cjs/loader:1623:10) at Object.require.extensions.<computed> [as .js] (/kohadevbox/Cypress/12.17.4/Cypress/resources/app/node_modules/ts-node/dist/index.js:851:20) at Module.load (node:internal/modules/cjs/loader:1266:32) at Function.Module._load (node:internal/modules/cjs/loader:1091:12) at Module.require (node:internal/modules/cjs/loader:1289:19) at require (node:internal/modules/helpers:182:18) at Object.<anonymous> (/kohadevbox/koha/t/cypress/plugins/api-client.js:11:23) at Module._compile (node:internal/modules/cjs/loader:1521:14) at Module._extensions..js (node:internal/modules/cjs/loader:1623:10) at Object.require.extensions.<computed> [as .js] (/kohadevbox/Cypress/12.17.4/Cypress/resources/app/node_modules/ts-node/dist/index.js:851:20) at Module.load (node:internal/modules/cjs/loader:1266:32) at Function.Module._load (node:internal/modules/cjs/loader:1091:12) at Module.require (node:internal/modules/cjs/loader:1289:19) at require (node:internal/modules/helpers:182:18) at Object.<anonymous> (/kohadevbox/koha/t/cypress/plugins/insertData.js:14:29) at Module._compile (node:internal/modules/cjs/loader:1521:14) at Module._extensions..js (node:internal/modules/cjs/loader:1623:10) at Object.require.extensions.<computed> [as .js] (/kohadevbox/Cypress/12.17.4/Cypress/resources/app/node_modules/ts-node/dist/index.js:851:20) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #430 from Jonathan Druart <jonathan.druart(a)gmail.com> --- Created attachment 195524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195524&action=e… Bug 38365: Fix xt/author/valid-templates.t 13:12:25 # Failed test '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/str/import_from_kbart_file.inc' 13:12:25 # at xt/author/valid-templates.t line 147. 13:12:25 # undef error - : filter not found 13:12:25 13:12:25 # Failed test '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/str/job_progress.inc' 13:12:25 # at xt/author/valid-templates.t line 147. 13:12:25 # undef error - : filter not found 13:12:25 13:12:25 # Failed test [13:12:08] xt/author/valid-templates.t ................................................. 13:12:25 Dubious, test returned 28 (wstat 7168, 0x1c00) 13:12:25 Failed 28/870 subtests 13:12:26 '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc' 13:12:26 # at xt/author/valid-templates.t line 147. 13:12:26 # undef error - : filter not found 13:12:28 13:12:28 # Failed test '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/str/erm_sushi_harvester.inc' 13:12:28 # at xt/author/valid-templates.t line 147. 13:12:28 # undef error - : filter not found -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #429 from Jonathan Druart <jonathan.druart(a)gmail.com> --- Created attachment 195523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195523&action=e… Bug 38365: Fix Koha/Middleware/ContentSecurityPolicy.t GIT_INSTALL is not set and we get the wrong root. The test suite does not pass on a non git install anyway. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #428 from Jonathan Druart <jonathan.druart(a)gmail.com> --- Created attachment 195522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195522&action=e… Bug 38365: Require a non-empty nonce in FrameworkPlugin.t Test plan: 0. Apply the patch 1. Run the following: prove t/db_dependent/FrameworkPlugin.t \ t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t \ t/db_dependent/Koha/UI/Form/Builder/Biblio.t \ t/db_dependent/Koha/UI/Form/Builder/Item.t \ t/db_dependent/Serials.t Squashed version of the following patches: Bug 38365: Fix Koha/UI/Form/Builder/Biblio.t # Failed test at t/db_dependent/Koha/UI/Form/Builder/Biblio.t line 216. # '<script nonce=""> # $(document).ready(function () { # # }); # </script> # ' # doesn't match '(?^us:<script>.*</script>)' # Looks like you failed 1 test of 4. Bug 38365: Fix Koha/UI/Form/Builder/Item.t # There were 16 warning(s) # Previous test 0 '' # Use of uninitialized value $csp_nonce in concatenation (.) or string at /kohadevbox/koha/Koha/FrameworkPlugin.pm line 381. # at /kohadevbox/koha/Koha/FrameworkPlugin.pm line 381. Bug 38365: Fix Serials.t Bug 38365: Fix FrameworkPlugin.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '26

17 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0