- Koha-bugs - lists.koha-community.org

[Bug 43394] DT - pagination is broken if pageLength is not an integer
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43394 --- Comment #3 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204496&action=e… Bug 43394: DT - Cast pageLength to Integer In "Edit patron card batch" the pageLength is coming from the syspref, the value is a string. But DataTable's needs an integer. Let's fix this in datatables.js, in the kohaTable's constructor Test plan: Got to cgi-bin/koha/patroncards/edit-batch.pl Enter more than 20 borrowernumbers and "Add patron(s)" Click "next" and notice that with this patch the pagination works. Without this patch the JS error is "Uncaught TypeError: can't access property "nTr", p is undefined" Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43394] DT - pagination is broken if pageLength is not an integer
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43394 Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43394] DT - pagination is broken if pageLength is not an integer
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43394 Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia(a)bugs.koha-communit |nick(a)bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #806 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204495&action=e… Bug 10190: (QA follow-up) Fix spelling for QA tools Other complaints are invalid: ContextA spelling - this is a variable Use of _("") - this is in regex for 'overdue_(' when checking rules git manipulation - not ideal adding and removing in same set, but this is a long work, not asking for a squash here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #805 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204494&action=e… Bug 10190: (QA follow-up) Add new permission to tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #804 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204493&action=e… Bug 10190: (QA follow-up) Adjust error message to list both permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #803 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204492&action=e… Bug 10190: (QA follow-up): fixes phase four - Display new manage_circ_triggers permission (add to template) - Ensure loading messages are informative to the user Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #802 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204491&action=e… Bug 10190: (follow-up): test: cypress tests update New tests: - regression: mtt cells render as .fallback (bold italics) - bg-success-subtle highlight on completed steps in the add flow - disabled-Delete states: - patron category filter set - item type filter set - default library, if any library has a trigger higher that default's highest - redirect to admin home if not permitted to access the page - in the edit/add stepper form - check row actions are enabled at the 'selectOrAdd' step - check row actions are disabled once add mode is entered - check the action column is always available on the main page Clean up / general updates: - replace the /api/v1/** catch-all intercept with per-endpoint intercepts so @get-rules waits resolve reliably - remove now-redundant cy.wait("@get-rules") calls - drop unused mount / dayjs / dates imports - ensure expected strings match UI where strings have changed Assisted-by: Claude Opus 4.7 (Anthropic) AI used to draft enhancements tests. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Tests were run multiple times and adjusted iteratively to match code changes, cover regressions as those were found, and handle vue page load. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #801 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204490&action=e… Bug 10190: (QA follow-up) UI/UX improvements and fixes - phase three Trigger deletion and rule set reset - warn the user that resetting or deleting a given set will break sets using it as fallback. - indicate which sets will be affected. - display a preview of the post reset state of each affected rule set. - preparation: allow TriggerTable to take a title parameter. - refactor to remove 'has_rules' from the store's rule suffixes list so those match the DB. - DRY: refactor to implement TriggerTable rather than use custom templates. - select context stage handles narrower viewports - prevent crash on missing rule set TriggersTable: refactor: the <a> elements used as buttons are now button elements - this is so they may be marked as disabled. Main page - trigger actions (delete button display) - disable the trigger deletion button. - if the context has been narrowed down ('delete' deletes all explicit rule set per trigger per library). - if the trigger belongs to default library AND one or more libraries have a trigger of a number bigger than the selected one. This is to protect trigger sequentiality from being broken for the relevant libraries. We also include an on hover message to explain the disabled button. Add/ Edit trigger form - clarify letters 'undo' button behaviour: - swap the native vue select X for a fa-undo icon. - display 'undo override and reset to fallback' on hover. - only display the add/edit button at the selectOrAdd step. - restore selected trigger yellow highlight (regression fix). - display any temporarily saved data from prior step in a green 'success' container. - only messages and data pulled from the DB for informative purposes display in blue containers. Other - redirect to correct URL (admin home) if store load fails - mtt fallbacks display as such consistently (bold italics) - is a bugfix. - catch errors on store initialisation - remove whitespace duplicate - ensure that mtt, if set, always display Assisted-by: Claude Opus 4.7 (Anthropic) AI used to help trace back potential bug sources, flag potential regressions, and draft enhancements. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash). Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '26

28 Aug '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #800 from Nick Clemens (kidclamp) <nick(a)bywatersolutions.com> --- Created attachment 204489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204489&action=e… Bug 10190: (QA follow-up): UI/UX bug fixes - phase two Fix: handle exiting modal - prevent data reload when the user exits the modal - as preparation for the above: refactor to use one handler only Fix: new trigger saves with delay defined - Identified an old refactor omission - we were still passing 'i' despite the from now relying on this.triggerNumber Fix: return to correct trigger tab after save or reset Fix: restore delete button and bold italic info - restore display, fixes a regression introduced by the previous UI/UX patch set Fix: order dropdown options by description or name (not code) Fix: circ rule resets - restore reset funtionality (mtt was still occasionally passed as a string, and would then get compared to an array. Ensure this is not the case.) - do not trigger the data refresh if the current ruleset did not get deleted - make sure triggerNumber is defined when navigation is caused by reset - add the notice code in brackets to letter names for display (eg. Overdue notice (ODUE)) Assisted-by: Claude Opus 4.6 (Anthropic) AI used to help trace back potential bug sources and draft fixes. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash) Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0