February 2015 - Koha-bugs - lists.koha-community.org

[Bug 13025] New: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Bug ID: 13025 Summary: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com One of our partners is seeing the following Software error intermittently on checkout: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925, <DATA> line 522. Here's the offending code: 1924 # Remove any OVERDUES related debarment if the borrower has no overdues 1925 if ( $borrowernumber 1926 && $borrower->{'debarred'} 1927 && C4::Context->preference('AutoRemoveOverduesRestrictions') 1928 && !HasOverdues( $borrowernumber ) 1929 && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } 1930 ) { 1931 DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); 1932 } I'm not *entirely* sure why this is happening -- HasOverdues is defined in C4/Members.pm: 53 push @EXPORT, qw( 54 &Search 55 &GetMemberDetails 56 &GetMemberRelatives ... 108 HasOverdues 109 ); and C4::Members is being included in C4/Circulation.pm: 30 use C4::Members; ... so !HasOverdues( $borrowernumber ) *shouldn't* be interpreted as a call to &C4::Circulation::HasOverdues ... nonetheless, calling 1928 && !HasOverdues( $borrowernumber ) could be re-written as 1928 && ! C4::Members::HasOverdues( $borrowernumber ) which would be un-ambiguously correct. For the sake of consistency, the call to HasOverdues at C4/Circulation.pm line 2626 should also be changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 10926] New: print slip different in two places
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10926 Bug ID: 10926 Summary: print slip different in two places Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If you choose print slip on the details page you get one version of the slip, if you choose print slip on the checkout page you get another. I have a customized version of the issue slip for my branch and it's only working on the check out tab, not the details tab - print slip should be the same everywhere. See here: http://screencast.com/t/FDbhZU9nXzyc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 12861] New: Noisy warns in C4/AuthoritiesMarc.pm
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Bug ID: 12861 Summary: Noisy warns in C4/AuthoritiesMarc.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: chris(a)bigballofwax.co.nz QA Contact: testopia(a)bugs.koha-community.org If you hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY You will see a lot of this opac-authorities-home.pl: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 146, <DATA> line 522. In the error logs -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 13458] New: Add new patron shows default / hardcoded patron categories after search
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Bug ID: 13458 Summary: Add new patron shows default / hardcoded patron categories after search Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: david.roberts(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com After performing a patron search resulting in a list of patrons, clicking on New Patron shows a default list of patron categories, not the ones configured on the system. This happens in 3.18 and on Master. To reproduce: 1) Carry out a patron search for Smith (or other similar common name). This will bring up cgi-bin/koha/members/member.pl and a list of patrons. 2) Click on New Patron. 3) The list of categories will contain: Adult Patron, Child Patron, Professional Patron, Organisation, Staff Patron, Statistical Patron. These will display regardless of which patron categories are configured. This is the only page on which this happens - adding a patron on cgi-bin/koha/members/members-home.pl shows the correct list of configured patron categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 8952] New: Add http:// to url in social media links on opac-detail
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Priority: P5 - low Change sponsored?: --- Bug ID: 8952 Assignee: oleonard(a)myacpl.org Summary: Add http:// to url in social media links on opac-detail Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy(a)rijksmuseum.nl Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Currently, the url is built using OPACBaseURL but does not contain a http:// prefix. -- You are receiving this mail because: You are watching all bug changes.

1 57

[Bug 12238] New: tools/export.pl: file list of ids as input parameter
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12238 Bug ID: 12238 Summary: tools/export.pl: file list of ids as input parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: stephane.delaune(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org add to tools/export.pl the ability to have a file list of identifiers (biblionumber or authid) as input parameter. This file may be generated with "Koha saved reports", which would choose precisely the exported records -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 11978] New: OverDrive API now prepends http:// to URLs
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Bug ID: 11978 Summary: OverDrive API now prepends http:// to URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver(a)bywatersolutions.com Reporter: jweaver(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The OverDrive API has changed the way URLs for detail pages and other information is returned; Koha currently prepends http:// to the URLs it receives, but now OverDrive does that themselves, breaking the links. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 12642] New: SMS.t requires a database
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Bug ID: 12642 Summary: SMS.t requires a database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: robin(a)catalyst.net.nz QA Contact: gmcharlt(a)gmail.com Needs to be moved to db_dependant or builds will be broken. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 12971] New: Printing member information lacks data
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Bug ID: 12971 Summary: Printing member information lacks data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: rkopaczka(a)afm.edu.pl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 11703 Print summary page don't contains information about checked out and reserved items. Bug 11703, made regression on "Print summary" option in member detail page. Originally moremember-print.tt uses data from moremember.pl sript (issueloop, reserveloop), which is no longer provided by it, but by ajax query. Without this loops, on print page are only borrower and fines/charges info. Also other templates (moremember-brief.tt & moremember-receipt.tt), responsible for printing members info, have data loops which was previously provided by moremember. But in cause of this two, it seems that they are no longer used anyway. As I investigated they are set up in moremember.pl:83-95, but on page use of this options is modified, to call printslip.pl not moremembers (in members-toolbar.inc). I could not find other places where they are used. Printslip however generate correct info, since it uses IssueSlip function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 12847] New: Date comparisons in C4::Members::IssueSlip is broken
by bugzilla-daemon＠bugs.koha-community.org 22 Apr '15

22 Apr '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Bug ID: 12847 Summary: Date comparisons in C4::Members::IssueSlip is broken Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In C4/Members.pm: 2379 sub IssueSlip { 2380 my ($branch, $borrowernumber, $quickslip) = @_; 2381 2382 # return unless ( C4::Context->boolean_preference('printcirculationslips') ); 2383 2384 my $now = POSIX::strftime("%Y-%m-%d", localtime); 2385 2386 my $issueslist = GetPendingIssues($borrowernumber); 2387 foreach my $it (@$issueslist){ 2388 if ((substr $it->{'issuedate'}, 0, 10) eq $now || (substr $it->{'lastreneweddate'}, 0, 10) eq $now) { 2389 $it->{'now'} = 1; 2390 } 2391 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2392 $it->{'overdue'} = 1; 2393 } 2394 my $dt = dt_from_string( $it->{'date_due'} ); 2395 $it->{'date_due'} = output_pref( $dt );; 2396 } At line 2384, $now is being defined with the format "%Y-%m-%d", however this is being compared against 'issuedate', 'lastrenewdate' and 'date_due'. 'date_due' is formatted '09/04/2014 23:59' The comparison only uses the first 10 characters of 'date_due', so we can ignore the timestamp at the end, but it's trying to compare 'YYYY-MM-DD' against 'MM/YY/DDDD', e.g. 2014-08-28 against 09/04/2014 -- This is a string comparison; so the initial '0' in '09/04/2014' sorts before the '2' in '2014-08-28'... since the date due is less than $now, the 'overdue' flag is set for this item. I believe that all of the dates involved (issuedate, lastreneweddate, and date_due) are Koha::DateUtils objects; as such it should be possible to define $now the same way, and use Koha::DateUtils methods directly for date comparisons, rather than doing string comparisons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 55