June 2017 - Koha-bugs - lists.koha-community.org

[Bug 17974] New: Add the Koha::Item->biblio method
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Bug ID: 17974 Summary: Add the Koha::Item->biblio method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 18482] New: False duplicates detected on adding a batch from a stage file
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Bug ID: 18482 Summary: False duplicates detected on adding a batch from a stage file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org Created attachment 62572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62572&action=ed… False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates. Checking for duplicate now lies on duplinbatch value that is not reset at each loop (In the initial commit, discarding record was directly tight to FindDuplicate return). So from the point when duplinbatch is defined, all the following biblios are discarded as duplicate whatever FindDuplicate return is. This patch adds a distinct flag. Test plan : You need the 2 test attached files TestFile1.mrc and TestFile2.elc (TestFile1 includes only the title "Amilec ou La graine d'hommes" that is also included in TestFile2). To save them, right click on bugzilla link and do 'Save target as'. 1) go to “Stage MARC records for import” page, upload TestFile1, select iso 5426 encoding and stage it for Import. 2) Click again 'Stage MARC records' button and do the same for TestFile2.elc 3) Go to acquisitions module, enter a vendor name and create a new basket. 4) From your basket, click 'Add to basket', then in the “Add order to basket window/block” choose 'From a staged file'. 5) Then click ‘Add orders' button on File1. 6) Leave default matching on Title/Author, tick the title, add a location in second tag and fund in third tag and Save. 7) Make sure that the new record is indexed (depending to your indexing system and test platform). 8) Redo step 4 and step 5 this time on TestFile2. 9) Leave default matching on Title/Author, select all titles, add a location in second tag, a fund in third tag and Save. 10) A warning is displayed saying that no records have been imported because they all match an existing record. The “Import all” block is not any more visible. 11) Apply the patch 12) Refresh 'Add orders from' page (File2) and redo step 9 13) You are redirected to the basket page : a warning is displayed to tell you that some duplicates have been found and skipped. There's a link on the warning throughout you can go back to the list of remaining records and treat them individually if necesary. 14) Click the link : you fall upon the only title that is a very duplicate (record of TestFile1). 15) Be happy 16) Sign off Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 18512] New: GetAuthorisedValues.GetByCode Template plguin should return code ( not empty string) if value not found
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Bug ID: 18512 Summary: GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 18611] New: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch.
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Bug ID: 18611 Summary: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On the manage marc import screen, clicking Import Batch on a batch containing a deleted item gives the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details.", and creates an empty PDF file. To replicate: 1) Import a marc record including items. 2) Delete one of the items in the batch. 3) In Home › Tools › Manage staged MARC records, click '(Create label batch)' on the batch in question. 4) This will show the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details." The logs in /var/log/koha/INSTANCE/intranet-error.log will look like this: 123456 [Mon May 15 11:14:21.848772 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) [for Statement "INSERT INTO creator_batches (batch_id, item_number, branch_code, creator) VALUES (?,?,?,?);" with ParamValues: 0=164, 1=123456, 2="APL", 3='Labels'] at /usr/share/koha/lib/C4/Creators/Batch.pm line 69., referer: http://asdfsadf... [Mon May 15 11:14:21.849012 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: Database returned the following error on attempted INSERT: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) at /usr/share/koha/lib/C4/Creators/Batch.pm line 71., referer: http://asdfsadf... [Mon May 15 11:14:21.849147 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: create_labelbatch_from_importbatch() : Error attempting to add item #123456 of import batch #11048 to label batch. at /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl line 198., referer: http://asdfsadf ... I think we need to have /usr/share/koha/lib/C4/Creators/Batch.pm exclude items where the itemnumber is null. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 18600] New: Missing db update for TalkingTechItivaPhoneNotification
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 Bug ID: 18600 Summary: Missing db update for TalkingTechItivaPhoneNotification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Adding TalkingTechItivaPhoneNotification to sysprefs.sql is causing a test to fail on Jenkins: https://jenkins.koha-community.org/job/Koha_16.11.x_D8/lastBuild/testReport… I think we are missing a database update statement, checking for the existence of the system preference in the database and adding it, when it's not already there yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 18204] New: Authority searches are not saved in Search history
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Bug ID: 18204 Summary: Authority searches are not saved in Search history Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: leire(a)scanbit.net QA Contact: testopia(a)bugs.koha-community.org When you search an authority in Authority search, this search is not saved in Search history. EnableOpacSearchHistory is enabled Steps to test: 1- Login your account (opac) 2- Search an authority in Authority search 3- Go to Search history -> Authority 4- It says "Your authority search history is empty" Tested on 16.11.04 -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 16295] New: marc_modification_templates permission doesn't allow access to modify template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Bug ID: 16295 Summary: marc_modification_templates permission doesn't allow access to modify template Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I have a staff member with permission to manage marc modification templates but they can't use it. They get Error: You do not have permission to access this page. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 18663] New: ExportRemoveFields
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Bug ID: 18663 Summary: ExportRemoveFields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Acc -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 18548] New: running koha-create --request-db without an instance name should abort
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Bug ID: 18548 Summary: running koha-create --request-db without an instance name should abort Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: eric.vantillard(a)evaxion.fr QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz running `koha-create --request-db` without an instance name will exit with this error message getent: invalid option -- 'k' Try `getent --help' or `getent --usage' for more information. [...] It should detect that the instance name is missing and exit with an error message explaining that the instance name is mandatory -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 18651] New: Move of checkouts is still not correctly handled
by bugzilla-daemon＠bugs.koha-community.org 28 Jul '17

28 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Bug ID: 18651 Summary: Move of checkouts is still not correctly handled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18242 Bug 18242 fixes a major: The move of a checkout from the issues table to the old_issues table was not done in a transaction, that leads to data lost. The issues row was deleted but not inserted to the old_issues table. Now that we have 18242, the move is done in a transaction but there are still several problems: 1. AddReturn returns a $issue hashref with the old issue_id value => At first glance it does not affect anything, but would be good to fix it for future uses. 2. If the move fails for whatever reason (see https://lists.katipo.co.nz/pipermail/koha/2017-May/048045.html for an example), fines can be charged. It should not 3. accountlines.issue_id are not updated! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 [Bug 18242] Move of checkouts to old_issues is not handle correctly -- You are receiving this mail because: You are watching all bug changes.

1 100