November 2018 - Koha-bugs - lists.koha-community.org

[Bug 21531] New: Subscription "New fields" button should read "New field"
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21531 Bug ID: 21531 Summary: Subscription "New fields" button should read "New field" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 21519 Action buttons for any "New" operation use singular, so the "New fields" button on the "Add subscription fields" should read "New field." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21519 [Bug 21519] Switch two-column templates to Bootstrap grid: Serials part 1 -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 21590] New: "send list" email uses the term "virtual shelf", this should be "list".
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21590 Bug ID: 21590 Summary: "send list" email uses the term "virtual shelf", this should be "list". Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The text of an email sent via the OPAC 'send shelves' menu item reads "Hi, George sent you from our online catalog, the virtual shelf called ..." Per https://wiki.koha-community.org/wiki/Terminology, we should use 'list' instead of 'virtual shelf'. To re-create 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". This is hard coded in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 20592] New: updateitem.pl causes database errors when empty non-public item notes updated
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20592 Bug ID: 20592 Summary: updateitem.pl causes database errors when empty non-public item notes updated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you go to /cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1#item1, and click "Update" next to an empty "Non-public note" field, it will generate a database error. Typically, this is hidden in your Apache logs, but if you have DEBUG turned on, the database error will be fatal. Example logs: [Tue Apr 17 12:43:48.607368 2018] [cgi:error] [pid 1992] [client ...:22158] AH01215: [Tue Apr 17 12:43:48 2018] updateitem.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE itemnumber='1'' at line 1 [for Statement "UPDATE items SET WHERE itemnumber=?" with ParamValues: 0="1"] at ../git/C4/Items.pm line 2038.: ../git/catalogue/updateitem.pl, referer: http://koha/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1 [Tue Apr 17 12:43:48.607852 2018] [cgi:error] [pid 1992] [client ...:22158] AH01215: [Tue Apr 17 12:43:48 2018] updateitem.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'WHERE itemnumber='1'' at line 1 [for Statement "UPDATE items SET WHERE itemnumber=?" with ParamValues: 0="1"] at ../git/C4/Items.pm line 2038.: ../git/catalogue/updateitem.pl, referer: http://koha/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=1&itemnumber=1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 21617] New: statistics.ccode is not long enough (see also dbrev 18.06.00.032)
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21617 Bug ID: 21617 Summary: statistics.ccode is not long enough (see also dbrev 18.06.00.032) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Warn from a test: DBD::mysql::st execute failed: Data too long for column 'ccode' at row 1 [for Statement "INSERT INTO statistics (datetime, branch, type, value, other, itemnumber, itemtype, location, borrowernumber, proccode, ccode) VALUES (now(),?,?,?,?,?,?,?,?,?,?)" with ParamValues: 0="z8LIyIV", 1='issue', 2=undef, 3='', 4='2584', 5='E_QkzaV5Ay', 6='oDnFRZyog2CS2_XoUB_MB2sBxyI3elbFPC_AekxLPrduGTXKnlNoLKEdQrXzpAw5zD1pGbZshV9ydZup', 7='2000005168', 8='', 9='j9ZDn74omZAoZrTOdC4a05SpWRSHPR2apfss7y5V6QJuQnBEk32XWXCfMp7'] at C4/Stats.pm line 138. The dbrev 18.06.00.032 did not change it from 10 to 80 as in other tables. We should either truncate to 10 chars in Stats.pm or increase to varchar(80). Since it is varchar and not char, we should not be afraid about size. I choose for the latter here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 21497] New: Correctly format dates for ILL requests in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21497 Bug ID: 21497 Summary: Correctly format dates for ILL requests in OPAC Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de In the OPAC the dates for ill requests are shown unformatted. Dates shoudl be displayed according to the datefomat system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 18959] New: Text_CSV_Various.t must skip if Text::CSV:: Unicode is not installed
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18959 Bug ID: 18959 Summary: Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Tests from Text_CSV_Various.t fail if Text::CSV::Unicode is not installed -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 21599] New: Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21599 Bug ID: 21599 Summary: Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org DBD::mysql::st execute failed: Incorrect decimal value: '' for column 'defaultreplacecost' at row 1 [for Statement "INSERT INTO `itemtypes` ( `checkinmsg`, `checkinmsgtype`, `defaultreplacecost`, `description`, `hideinopac`, `imageurl`, `itemtype`, `notforloan`, `processfee`, `rentalcharge`, `searchcategory`, `sip_media_type`, `summary`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="message", 2="", 3="xx", 4=0, 5='', 6="XX", 7=0, 8="", 9="", 10="", 11=undef, 12=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. And so, selenium basic_workflow.t is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 21600] New: t/db_dependent/api/v1/patrons.t is failing with new SQL modes
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Bug ID: 21600 Summary: t/db_dependent/api/v1/patrons.t is failing with new SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: tomascohen(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I have failed fixing this one, Tomas can you have a look please? It seems that we try and insert a rfc3339 formatted date into a datetime or timestamp column. DBD::mysql::st execute failed: Incorrect datetime value: '2018-10-18T12:50:41-03:00' for column 'lastseen' -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 21613] New: Turn strict SQL mode on for tests
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Bug ID: 21613 Summary: Turn strict SQL mode on for tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org In order to make sure developers will be aware of possible regressions we should turn the strict SQL mode on for tests. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 21542] New: OverDrive password submission should use a password field to mask input
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21542 Bug ID: 21542 Summary: OverDrive password submission should use a password field to mask input Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1 - Enabled Overdrive and fill all preferences 2 - Make sure OverDrivePasswordRequired is true 3 - Go to opac account 4 - Log in to overdrive 5 - Note the input is shown in plain text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12