February 2018 - Koha-bugs - lists.koha-community.org

[Bug 18186] New: Amounts with decimal comma instead of decimal dot breaking payments
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '23

16 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186 Bug ID: 18186 Summary: Amounts with decimal comma instead of decimal dot breaking payments Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In our current installations running under Plack, the amounts on the pay and paycollect pages suddenly started showing with a decimal comma instead of a decimal point. This causes quite a bit of trouble, as Koha expects a . and amounts entered didn't result in the expected payments. We got several reports about payments being broken in Koha. Test plan: - Add manual invoice - View the "fines" tag - Verify that individual fees and totals display with , instead of . - Pay selected or any amount - Verify that the input field for the amount is also showing the , - Verify that paying something like 1,10 doesn't work as expected. The problem with the test plan is, that you might not see the ,. This appears only on our productions servers, but not in my development environment. We tested: - different language settings in Koha - different language settings in the browser - verified that CurrencyFormat isn't used in the code on those page - verified that all the formatting done was using the TT filter format('%.2f') In the end the problem turned out to be related to Plack. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18412] New: Show list price in foreign currency in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 09 Jan '23

09 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 Bug ID: 18412 Summary: Show list price in foreign currency in acquisitions Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org At the moment, the list price as entered in a foreign currency is not shown in acquisitions on the basket or receive forms. Only the converted price is shown. A As exchange rates can change and the libraries need to check invoices etc with the price an item was ordered with, we should also show the list price as it was entered in the foreign currency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 19903] New: Add Koha::Patron::Restrictions
by bugzilla-daemon＠bugs.koha-community.org 08 Jan '23

08 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19903 Bug ID: 19903 Summary: Add Koha::Patron::Restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We need a Koha::Object-based class to replace (the so-called) Koha::Patron::Debarments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 17436] New: Add a way to know in patron module where renew of an item was made
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '23

04 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 Bug ID: 17436 Summary: Add a way to know in patron module where renew of an item was made Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: marjorie.barry-vila(a)ccsr.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 56297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56297&action=ed… number of renewals Hi, In statistic's table, we have possibility to know where a renew was made (opacrenew in sys pref OpacRenewalBranch). It will be great to see this information on patron page in circulation history maybe? Number of renewals column? a number for opacrenew and a number for librarian interface. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 17062] New: debian/control.in update: change maintainer
by bugzilla-daemon＠bugs.koha-community.org 03 Jan '23

03 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17062 Bug ID: 17062 Summary: debian/control.in update: change maintainer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net Changing the package maintainer and removing a whitespace in debian/control.in. Regenerated debian/control from that, which also adds libhtml-parser-perl because of bug 16971. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 16261] New: System preference noissuecharge should take account of the amount "greater than or equal to"
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '22

12 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16261 Bug ID: 16261 Summary: System preference noissuecharge should take account of the amount "greater than or equal to" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: marjorie.barry-vila(a)ccsr.qc.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Hi, Noissuecharge takes into account the amounts of fines "greater than" to what is written in the preference system. Example: noissuecharge filled with 5 Patron has $ 5 in fines, it will not be blocked to check-out. We have to write 4.99 to block patron with 5 $ in fines. Noissuecharge should take account of the amount "greater than or equal to" Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 19008] New: More database cleanups
by bugzilla-daemon＠bugs.koha-community.org 09 Dec '22

09 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Bug ID: 19008 Summary: More database cleanups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 85

[Bug 20078] New: Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus.
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Bug ID: 20078 Summary: Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com The indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) are not listed in C4::Search::getIndexes, and therefore cannot be used in the koha drop down menus. To re-create: Find a bib with 526$c and 526$d populated, e.g. +---------------+--------------+-------------+-------------+ | title | biblionumber | 526$c (arl) | 526$d (arp) | +---------------+--------------+-------------+-------------+ | Star flight / | 1347 | 5.5 | 14 | +---------------+--------------+-------------+-------------+ Entering the following in the search bar works: arl:5.5 as does arp:14 However entering the following in intranetuserjs: $(document).ready(function(){ // Add Accelerated Reading Level to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arl">Accelerated Reading Level</option>'); } // Add Accelerated Reading Point to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="arp">Accelerated Reading Point</option>'); } }); Then running an advanced search using the respective values of Accelerated Reading Level and Accelerated Reading Point will fail. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 18309] New: UNIMARC update from IFLA
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Bug ID: 18309 Summary: UNIMARC update from IFLA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt(a)gmail.com Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org IFLA Federation published new recommendations for UNIMARC standard. Will impact pré-installed biblio and authorities frameworks. -- You are receiving this mail because: You are watching all bug changes.

1 183

[Bug 19963] New: ethnicity and ethnicity tables and columns survived update
by bugzilla-daemon＠bugs.koha-community.org 07 Dec '22

07 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963 Bug ID: 19963 Summary: ethnicity and ethnicity tables and columns survived update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The database update for 3.21.00.033 should have removed the ethnicity table and the ethnicity and ethnotes columns from borrowers, deletedborrowers and borrower_modifications. This didn't work right in all cases. I just noticed that all those survived in our older databases. The reason is that the database update only checked for NULL when counting existing data, but not for "": 11054 $DBversion = "3.21.00.033"; 11055 if ( CheckVersion($DBversion) ) { 11056 11057 my $done = 0; 11058 my $count_ethnicity = $dbh->selectrow_arrayref(q| 11059 SELECT COUNT(*) FROM ethnicity 11060 |); 11061 my $count_borrower_modifications = $dbh->selectrow_arrayref(q| 11062 SELECT COUNT(*) 11063 FROM borrower_modifications 11064 WHERE ethnicity IS NOT NULL 11065 OR ethnotes IS NOT NULL 11066 |); 11067 my $count_borrowers = $dbh->selectrow_arrayref(q| 11068 SELECT COUNT(*) 11069 FROM borrowers 11070 WHERE ethnicity IS NOT NULL 11071 OR ethnotes IS NOT NULL 11072 |); 11073 # We don't care about the ethnicity of the deleted borrowers, right? 11074 if ( $count_ethnicity->[0] == 0 11075 and $count_borrower_modifications->[0] == 0 11076 and $count_borrowers->[0] == 0 11077 ) { 11078 $dbh->do(q| 11079 DROP TABLE ethnicity 11080 |); 11081 $dbh->do(q| 11082 ALTER TABLE borrower_modifications 11083 DROP COLUMN ethnicity, 11084 DROP COLUMN ethnotes 11085 |); 11086 $dbh->do(q| 11087 ALTER TABLE borrowers 11088 DROP COLUMN ethnicity, 11089 DROP COLUMN ethnotes 11090 |); 11091 $dbh->do(q| 11092 ALTER TABLE deletedborrowers 11093 DROP COLUMN ethnicity, 11094 DROP COLUMN ethnotes 11095 |); 11096 $done = 1; 11097 } 11098 if ( $done ) { 11099 print "Upgrade to $DBversion done (Bug 10020: Drop table ethnicity and columns ethnicity and ethnotes)\n"; 11100 } 11101 else { 11102 print "Upgrade to $DBversion done (Bug 10020: This database contains data related to 'ethnicity'. No change will be done on the DB structure but note that the Koha codebase does not use it)\n"; 11103 } 11104 11105 SetVersion ($DBversion); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4