September 2018 - Koha-bugs - lists.koha-community.org

[Bug 18471] New: Receiving order with unitprice greater than 1000 processing incorrectly
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Bug ID: 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Two problems here really: Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total To recreate: 1 - Open a basket 2 - Place an order for an item with price > 1000, $4367.00 for example 3 - Close basket 4 - Receive order 5 - Note on orderreceive.pl the price is populate as "4,367.00" 6 - Receive/Save 7 - Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8 - Cancel receipt 9 - Receive again, this time enter price as "4367" 10 - Receive/save 11 - Note actual cost is correct 12 - Finish receiving 13 - Note invoice reads total as $4.00 14 - Check db - price in aqorders is correct but displaying incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 21186] New: Incorrect Bootstrap modal event name in multiple templates
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21186 Bug ID: 21186 Summary: Incorrect Bootstrap modal event name in multiple templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org When we upgraded Bootstrap in the staff client we missed updating some references to Bootstrap's "hidden" event. It should now be "hidden.bs.modal." $("#marcPreview").on("hidden.bs.modal", function(){ // Action triggered when modal is closed }); -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 19933] New: Move C4::Members:: patronflags to the Koha namespace - part 1
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 Bug ID: 19933 Summary: Move C4::Members::patronflags to the Koha namespace - part 1 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org C4::Members::patronflags does a lot of things and most of the time they are not even used by the callers. We should split this subroutine and fetch only the data we need. -- You are receiving this mail because: You are watching all bug changes.

1 46

[Bug 21257] New: Patrons checkout table throws JS error when location/collection not defined
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21257 Bug ID: 21257 Summary: Patrons checkout table throws JS error when location/collection not defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1 - Check out an item to a patron 2 - Make sure that item has no collection of location defined 3 - Try to view patrons checkouts - table does not load 4 - Check the console: TypeError: oObj.collection is null -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 21347] New: bad code for input field in item information tab of addorderiso2709 page
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21347 Bug ID: 21347 Summary: bad code for input field in item information tab of addorderiso2709 page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org In cgi-bin/koha/acqui/addorderiso2709.pl, there is a problem with some fields in item information problem. Instead to have a field, you have the code : Cote <input type="text" name="field_value" value="" size="50" maxlength="255" /> Note <input type="text" name="field_value" value="" size="50" maxlength="255" /> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 21293] New: Display of housebound delivery information broken by Bug 13618
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21293 Bug ID: 21293 Summary: Display of housebound delivery information broken by Bug 13618 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, kyle.m.hall(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 13618 A stray " | html " filter in the housebound template means that none of the housebound delivery details are showing up. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 21454] New: Price filtered variables should not need to be html filtered
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21454 Bug ID: 21454 Summary: Price filtered variables should not need to be html filtered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618, 21393 The result of a variable escaped using the Price filter does not need to be html filtered, it is always a float. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 [Bug 21393] Make template filter checks code reusable -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 21393] New: Make template filter checks code reusable
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21393 Bug ID: 21393 Summary: Make template filter checks code reusable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 The code used to catch missing filters (xt/find-missing-filters.t) is not isolated, which make it hard to reuse for other usages. We would like the QA tests (qa-test-tools) to have another test to catch them, which would let us (developpers, QAers, RM) know earlier in the workflow that something is wrong. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 21377] New: Variable declarations erroneously filtered
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Bug ID: 21377 Summary: Variable declarations erroneously filtered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com In the main ILL template file ill-requests.tt a few variable declarations that are not strings have the "html" filter applied to them, this breaks them. These filters should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 21418] New: Incorrectly filtered markup in staff client lists
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 Bug ID: 21418 Summary: Incorrectly filtered markup in staff client lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Staff Client Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: bgkriegel(a)gmail.com, brendan(a)bywatersolutions.com, chris(a)bigballofwax.co.nz, dcook(a)prosentient.com.au, ere.maijala(a)helsinki.fi, fridolin.somers(a)biblibre.com, george(a)nekls.org, gmcharlt(a)gmail.com, j.kylmala(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, katrin.fischer(a)bsz-bw.de, kohadevinim(a)devinim.com.tr, kyle(a)bywatersolutions.com, liz(a)catalyst.net.nz, m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, mirko(a)abunchofthings.net, mtompset(a)hotmail.com, nick(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com, veron(a)veron.ch Depends on: 13618 The AJAX DataTable of existing lists is broken because the action buttons are incorrectly rendered. The "| html" filter should be removed from the action_block declarations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 19