July 2019 - Koha-bugs - lists.koha-community.org

[Bug 19819] New: C4::Context->dbh is unreasonably slow
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Bug ID: 19819 Summary: C4::Context->dbh is unreasonably slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I have been profiling Koha the last day or so to try to fix some bottlenecks increasing performance of bulk-processing of data. Discovered that C4::Context->dbh was unexpectedly slow (Koha::Database->schema->storage->dbh is the culprit). If it is safe to do so, performance can be greatly improved by locally caching $dbh in a state variable. Patch will be provided shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 19121] New: Prevent XSS in the Staff Client and the OPAC - bis
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121 Bug ID: 19121 Summary: Prevent XSS in the Staff Client and the OPAC - bis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On bug 13618 we tried to escape variables at template level: all variables were escaped using Template::Stash::AutoEscaping::Escaped::HTML::escape It works well, but unfortunately it leads to performance issues (see bug 15715). Indeed in some scripts, 70k variables are displayed Another approach would be to escape variables when they are sent to the scripts. We will get only 1 call per variable passed to the script and we will not escape unnecessarily variables several times, or variables coming from the DB (maybe we will need a script to clean the data?) -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 19016] New: Add a script to fix corrupted data
by bugzilla-daemon＠bugs.koha-community.org 27 Nov '19

27 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016 Bug ID: 19016 Summary: Add a script to fix corrupted data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Depends on: 18966 We must provide a fix to deal with corrupted data. For more information, see bug 18966 and https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966 [Bug 18966] Move of checkouts - Deal with duplicate IDs at DBMS level -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 22210] New: Allow organisations to sign up to Mana KB more easily
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Bug ID: 22210 Summary: Allow organisations to sign up to Mana KB more easily Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 17047 Target Milestone: --- The Mana KB registration form asks for first name and last name. I think a lot of libraries would prefer to sign up with a general account for the organisation (library@...). People can leave the library and more than one person might work with serials/reports. So I think tying the account to a person might not be the best way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 22037] New: regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP.
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 Bug ID: 22037 Summary: regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Target Milestone: --- Currently on 18.05.06. I have two sample patrons set up. XXXXXXXX (an adult patron) and YYYYYYYYYY (a child patron). XXXXXXXX is the guarantor for YYYYYYYYYY and I have put a 12.00 fee on YYYYYYYYYY's account. Because of our system settings, a fee of 10.01 or over on a child's account should block checkouts by the adult guarantor and, in this case it does. If I go to XXXXXXXX's account in Koha I get the "Fees & Charges: Patron's guarantees collectively owe 12.00. Checkouts are BLOCKED because fine balance is OVER THE LIMIT." message that I expect to see and the patron is blocked from checkout in the staff client. In a SIP2 transaction, however, XXXXXXXX is not blocked. Prior to our upgrade this scenario would cause XXXXXXXX's account to send a SIP2 PI response of 'N.' Since the upgrade, the guarantor account with an over-limit guarantee is not triggering an 'N' response in the PI field - it's coming through as PIY as seen in the sample SIP response below: --> 6300120181220 150631 AOLEAVENWRTH|AAXXXXXXXX|AD1234|BP1|BQ5|AY2AZEE0C <-- 64 00120181220 150632000000000000000000000000AOLEAVENWRTH|AAXXXXXXXX|AESIP Test|BLY|CQY|CC10|PB19000101|PCADULT|PIY|AFGreetings from Koha. |AFLEAVENWRTH|AY2AZD277 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33

[Bug 23123] New: Status AVAILABLE for suggestions is not translated in the templates
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Bug ID: 23123 Summary: Status AVAILABLE for suggestions is not translated in the templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- We noticed that the status AVAILABLE (suggestion was ordered and received in acq) is not displayed correctly in the suggestions table. I think it's missing in the templates here: 131 <span class="label">Status:</span> 132 [% SET status_found = 0 %] 133 [% IF ( STATUS == 'ASKED' ) %] 134 Pending 135 [% SET status_found = 1 %] 136 [% ELSIF ( STATUS == 'ACCEPTED' ) %] 137 Accepted 138 [% SET status_found = 1 %] 139 [% ELSIF ( STATUS == 'CHECKED' ) %] 140 Checked 141 [% SET status_found = 1 %] 142 [% ELSIF ( STATUS == 'REJECTED' ) %] 143 Rejected 144 [% SET status_found = 1 %] 145 [% ELSE %] 146 [% FOREACH s IN SuggestionStatuses %] 147 [% IF STATUS == s.authorised_value %] 148 [% s.lib | html %] 149 [% SET status_found = 1 %] 150 [% END %] 151 [% END %] 152 [% END %] It shows as AVAILABLE and is not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 17851] New: Add elasticsearch config to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Bug ID: 17851 Summary: Add elasticsearch config to koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Following the Elasticsearch installation instructions from: https://wiki.koha-community.org/wiki/Elasticsearch the <elasticsearch> config seems to be missing. This patch adds interactive Elasticsearch-questions to the Makefile.PL to configure ES. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 21526] New: TT variables used to build a link should be uri filtered
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Bug ID: 21526 Summary: TT variables used to build a link should be uri filtered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 and not html filtered, see the wiki page for more details https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_th… Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.

1 86

[Bug 23230] New: Make Koha::Plugins::Base::_version_compare OO
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Bug ID: 23230 Summary: Make Koha::Plugins::Base::_version_compare OO Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This method is to be run inside plugin objects that inherit from Koha::Plugins::Base, but calling $self->_version_compare(); won't work because the method doesn't expect $self to be passed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 23346] New: Add without-db-name parameter to koha-dump
by bugzilla-daemon＠bugs.koha-community.org 26 Nov '19

26 Nov '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23346 Bug ID: 23346 Summary: Add without-db-name parameter to koha-dump Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz See also bug 15664 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13