October 2020 - Koha-bugs - lists.koha-community.org

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Alexis Ripetti <alexis.ripetti(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #57 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- So, I fixed the test that does not pass. I also put the changes in the good patch. When I apply both patches, I got this : <pre> not ok 8 # Failed test at t/db_dependent/Circulation.t line 2102. # got: '2020-11-17' # expected: '2020-11-25' # Looks like you failed 1 test of 8. not ok 28 - AddReturn + CumulativeRestrictionPeriods # Failed test 'AddReturn + CumulativeRestrictionPeriods' # at t/db_dependent/Circulation.t line 2103. </pre> Is this the one who should fail ? I also got this : <pre> not ok 14 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u) # Failed test 'Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)' # at t/db_dependent/Circulation.t line 3554. # got: '47.75' # expected: '42' ok 15 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u) not ok 16 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u) # Failed test 'Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u)' # at t/db_dependent/Circulation.t line 3568. # got: '35.75' # expected: '36' ok 17 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed Saturday, for renewal (312h - 168h - 24h * 0.25u not ok 18 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u # Failed test 'Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u' # at t/db_dependent/Circulation.t line 3582. # got: '41.75' # expected: '42' ok 19 - Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u) # Looks like you failed 3 tests of 19. not ok 42 - Incremented fee tests # Failed test 'Incremented fee tests' # at t/db_dependent/Circulation.t line 3592. </pre> These failed tests are also here when I do not apply both patches. Do you get the same errors? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 [Bug 26875] Allow printing of just one barcode -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26874 [Bug 26874] Exclude label layouts without barcodes from selection when printing a barcode batch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26873] New: Disable date picker for Managed On when editing a suggestion
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26873 Bug ID: 26873 Summary: Disable date picker for Managed On when editing a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When editing an existing suggestions, one is presented with a date picker to select a Managed On date. However, regardless of what you select, it saves as today's date. I'm inclined to just disable the date picker. Alternatively, we could make it save the selected date, but it seems confusing to be able to make that user-controlled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Alexis Ripetti <alexis.ripetti(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110764|0 |1 is obsolete| | --- Comment #56 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- Created attachment 112725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112725&action=e… Bug 14784: Add tests This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0. To test: 1. Apply patches 2. prove -v t/db_dependent/Circulation.t When applying only this patch, one test should fail. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Alexis Ripetti <alexis.ripetti(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110763|0 |1 is obsolete| | --- Comment #55 from Alexis Ripetti <alexis.ripetti(a)inLibro.com> --- Created attachment 112724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112724&action=e… Bug 14784: Fix checkin message for debarred patrons After thinking about it I changed the code's behavior to always display a reminder if the patron was previously debarred. This makes sense to me (it's only a reminder) and it correctly stacks with other messages. -- Test plan: Before 1) Select a user with active restrictions (manual restriction works) 2) Make sure finesday=0 for the user category. See [1] 3) Checkout and return an item (not overdue) A previous restriction reminder will appear 4) Checkout and return an overdue item (change the date at cehckout) No previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) I've also tested with finesday=1 with "no overdue", "grace period overdue" and "long overdue" test cases. The appropriate nessage appeared for each test. [1] The "finesday" setting is called "Suspension in days" in the web interface, if you're searching for it like I did... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26872] New: Series/collection is not added to the record created from a suggestion
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26872 Bug ID: 26872 Summary: Series/collection is not added to the record created from a suggestion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org I believe there is a mismatch in naming. The column is suggestions.collectiontitle, but the code talks about seriestitle: if ($suggestionid and $mss->{kohafield}) { # Reading suggestion info if ordering from a suggestion if ( $mss->{kohafield} eq 'biblio.title' ) { $value = $data->{title}; } elsif ( $mss->{kohafield} eq 'biblio.author' ) { $value = $data->{author}; } elsif ( $mss->{kohafield} eq 'biblioitems.publishercode' ) { $value = $data->{publishercode}; } elsif ( $mss->{kohafield} eq 'biblioitems.editionstatement' ) { $value = $data->{editionstatement}; } elsif ( $mss->{kohafield} eq 'biblioitems.publicationyear' ) { $value = $data->{publicationyear}; } elsif ( $mss->{kohafield} eq 'biblioitems.isbn' ) { $value = $data->{isbn}; } elsif ( $mss->{kohafield} eq 'biblio.seriestitle' ) { $value = $data->{seriestitle}; } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13752] Item level holds crossed if item moved to another bib
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #9 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Katrin Fischer from comment #8) > I've tried something: > > - Find record A > - Place an item level hold on one of the items > - Move the item to another record B > - The item hold was moved with the item > > I believe this is the only way the biblionumber would change and it looks > like the issue might have been fixed. Are you saying the scenario that Joy outlined in Comment 1 is no longer an issue? Your test you do here doesn't talk about orders and baskets, so I am not sure that you addressed this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 7972] GUI for Crons
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 --- Comment #9 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Our primary concern is not only being able to adjust the frequency and between what hours a cron might run, but also being able to see what all is running, and when. As a consortium admin with a support vendor, we are blind to these settings, and would like to be able to see how things are set without having to ask the vendor to dig all this information up. I think some things might need to be untouchable, and only visible, and others need to be both visible and adjustable. They should also only allow you to adjust them within certain limits, so as not to bog down the system or make it unstable (i.e. telling the system to reindex hourly would be a bad option. - I'm guessing - what do I know? I can't see these things.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 22106] New: Column settings needs to include OPAC and Intranet holds (requests) tables
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '20

30 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22106 Bug ID: 22106 Summary: Column settings needs to include OPAC and Intranet holds (requests) tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- The hold request tables need to be included in the Column settings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3