March 2020 - Koha-bugs - lists.koha-community.org

[Bug 19652] New: Debug-level logging for response JSON
by bugzilla-daemon＠bugs.koha-community.org 29 Apr '20

29 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652 Bug ID: 19652 Summary: Debug-level logging for response JSON Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi Log response JSON in REST API log. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 25004] New: Search results place hold button not enabled when checking result checkboxes on opac-search.pl
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25004 Bug ID: 25004 Summary: Search results place hold button not enabled when checking result checkboxes on opac-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 0 - Make sure ability to place holds on OPAC is enabled (RequestOnOpac) 1 - Search on the opac to get multipel results 2 - Note place hold button is disabled 3 - Check a box next to a result 4 - Note place hold button not enabled -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 24941] New: Serials: Link to basket in acqusition details is broken
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24941 Bug ID: 24941 Summary: Serials: Link to basket in acqusition details is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When using 'order from a subscription', acquisition details will show in the serials module on the subscription detail page. The basketnumber is linked, but the URL is broken: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno= It's missing the basketno parameter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 24996] New: Unwanted CSS change unhides OPAC results sorting button
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Bug ID: 24996 Summary: Unwanted CSS change unhides OPAC results sorting button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 23915 With JavaScript enabled the "Go" button associated with the OPAC search results re-sort form should be hidden. Looks like I accidentally removed a line of CSS with Bug 23915 which needs to get put back. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 24900] New: 'MARC modification templates' does not delete all fields if there is a condition in template
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24900 Bug ID: 24900 Summary: 'MARC modification templates' does not delete all fields if there is a condition in template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Created attachment 100992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100992&action=e… test record To reproduce: Download the attached biblio record (try right-clicking -> save link as) Create a MARC modification template with the following action: Delete field 020 if field 020$z exists Import the record (Tools -> Stage MARC record for import) Under Use MARC modification template, select your template to modify the record Stage for import Once complete, go to Manage staged records Click the staged record to view the MARC Confirm only the 020$z field was deleted, even though we wanted all 020 fields to be deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 24365] New: Using strict from TmplTokenizer.pm broke the translator script
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Bug ID: 24365 Summary: Using strict from TmplTokenizer.pm broke the translator script Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation: kohadev-koha@5dbfd5c26b19:/kohadevbox/koha$ prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. 1/? # Failed test 'opac_bootstrap templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/nUR3OD9D9y:19466:8: invalid multibyte sequence # # msgmerge: found 1 fatal error # xt/author/translatable-templates.t .. 2/? # Failed test 'staff_prog templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/DdbDRQTBzl:6111:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:6122:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:10911:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:11301:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:49459:66: invalid multibyte sequence # # /tmp/DdbDRQTBzl:65223:27: invalid multibyte sequence # # /tmp/DdbDRQTBzl:88587:10: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:43: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:71: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94549:8: invalid multibyte sequence # # msgmerge: found 10 fatal errors # # Looks like you failed 2 tests of 2. xt/author/translatable-templates.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- xt/author/translatable-templates.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=1, Tests=2, 8 wallclock secs ( 0.02 usr 0.01 sys + 8.55 cusr 0.08 csys = 8.66 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 24217] New: use Modern::Perl for modules
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Bug ID: 24217 Summary: use Modern::Perl for modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This is not done yet! We need that for modules (at least) ASAP -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 23577] New: OPAC - patron e-mail notification of new login location
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23577 Bug ID: 23577 Summary: OPAC - patron e-mail notification of new login location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org Would like to see e-mails sent to patrons alerting them of IP addresses or new machines the account was logged in from. The e-mail could include IP addresses, OS information, and browser information, as well as a time stamp. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 21761] New: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Bug ID: 21761 Summary: Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org If we're adding triggers at the code level all over the place by overloading the store method we need to never ever let dbic handle it.. by allowing the 'update' method through we are exposing ourselves to places in the codebase skipping the store triggers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 45

[Bug 24965] New: Koha::Object->to_api should handle undef counts
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '20

28 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 Bug ID: 24965 Summary: Koha::Object->to_api should handle undef counts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If to_api is requested to embed the count on a relation that might be undef (for example, if the relation is not just a FK on another table but linking table: sub current_item_level_holds { my ($self) = @_; my $items_rs = $self->_result->aqorders_items; my @item_numbers = $items_rs->get_column('itemnumber')->all; return unless @item_numbers; my $biblio = $self->biblio; return unless $biblio; return $biblio->current_holds->search( { itemnumber => { -in => \@item_numbers } } ); } it is possible to get exceptions for calling ->count on an undefined object. We should catch this situation and return zero. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13