October 2023 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #312 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Aleisha Amohia from comment #298) > > This means we need to adjust the column from 31 to 32, but I didn't write > > the follow-up for that, because I found what broke the behavior: > > > > * Turn on UnseenRenewals system preference > > > > It throws the column count...and then we are back at the default copying > > into the input field. > > > > Could you try to fix that? > > Hi Katrin, I've done a new fix for this. I noticed the UnseenRenewals circ > rule breaks a bunch of other rules in the same way, so maybe we can adopt > this new way of identifying those columns in another bug report. Hi Aleisha, thanks for that! I failed to come up with the right syntax :) I have filed a new bug to deal with the pre-existing problem for the other circulation rules: Bug 35182 - Activating "UnseenRenewals" causes problems in circulation rules editor Happy to pass QA now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157715|0 |1 is obsolete| | --- Comment #311 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158035&action=e… Bug 8367: (follow-up) Fix for circ rules editor Make sure holds pickup period field is empty when editing a 'default' rule. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157708|0 |1 is obsolete| | --- Comment #310 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158034&action=e… Bug 8367: (QA follow-up) Fix QA script * Add +x to atomic database update file * Perltidy * Add spans to rewritten tab label for translatability Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157707|0 |1 is obsolete| | --- Comment #309 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158033&action=e… Bug 8367: Add holds_pickup_period fallback circulation rule Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157706|0 |1 is obsolete| | --- Comment #308 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158032&action=e… Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157705|0 |1 is obsolete| | --- Comment #307 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158031&action=e… Bug 8367: (QA follow-up) Update message on Hold waiting pickup report Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=8367 Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157704|0 |1 is obsolete| | --- Comment #306 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158030&action=e… Bug 8367: (follow-up) possible to delete circ rule Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157703|0 |1 is obsolete| | --- Comment #305 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158029&action=e… Bug 8367: (follow-up) Remove unnecessary code and atomic update Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157702|0 |1 is obsolete| | --- Comment #304 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158028&action=e… Bug 8367: (follow-up) Fix tests Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '23

29 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157701|0 |1 is obsolete| | --- Comment #303 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 158027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158027&action=e… Bug 8367: (follow-up) Remove pickup delay message from OPAC It adds unnecessary complexity and information. Signed-off-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Kelly <kelly(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0