September 2026 - Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #894 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205004&action=e… Bug 10190: (follow-up) Complete Vue.js rewrite of Circulation Triggers administration interface This patch aims to resolve the following issues as reported by comment 193: - missing atomic update for overde_X_has_rules (amended to account for comment 227) - existing delays being overwritten by the client when a rule set is displayed - inability to save circulation overdue rule sets for context for which circulations rules where already set - address bug_10190.pl db script warnings (undef values were being concatenated with strings) - add a guard clause to bug_101090.pl: check that the tables the script pulls the data from do still exist, otherwise exit. - remove duplicate Letters options in the circulation triggers add / edit form Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #893 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205003&action=e… Bug 10190: (QA follow-up): Fix removal of tables Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #892 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205002&action=e… Bug 10190: Comprehensive Cypress tests for Circulation Triggers UI This patch significantly enhances the Cypress test coverage for the new Circulation Triggers administration interface, expanding from basic breadcrumb checks to comprehensive end-to-end testing. Test Coverage: - Initial page load and API error handling - Context filtering (library, patron category, item type) - View toggling between explicit and all applicable rules - Tab navigation between multiple triggers - Full CRUD operations (Create, Read, Update, Delete) - Rule set reset functionality - Letter template filtering by library context - Form validation and constraint checking - Loading states and empty states - Error handling for all operations - Browser navigation (back/forward buttons) - Complex scenarios with inheritance hierarchies New Features: - Mock data helper functions for test fixtures - Comprehensive API interception for all endpoints - Tests for both success and error paths - Placeholder value testing for fallback rules - Increment/decrement button testing - Multi-step form workflow validation - Confirmation dialog testing for destructive operations The tests follow Koha's Cypress testing patterns established in the ERM module, using proper API mocking, clear test descriptions, and organized test suites. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #891 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205001&action=e… Bug 10190: Update itiva script to reflect move to circ_rules Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #890 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205000&action=e… Bug 10190: Remove old overduerules interface This patch updates the link from the tools homepage to open the new circulation triggers administration page. We then remove the old overduerules controller and template, and finally we drop the no longer referenced C4::Overdues::GetOverdueMessageTransportTypes method and associated unit tests. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #889 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204999&action=e… Bug 10190: Migrate MarkIssueReturned test to circulation rules Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #888 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204998&action=e… Bug 10190: Update has_restricting_overdues to refer to circulation rules This patch updates the Koha::Patron->has_restriction_overdues method to refer to the migrated overdue rules. We also correct an oversight in the method prior to this patch that meant that not all overdues were being correctly checked for a restriction.. we were incorrectly filtering to only overdues at the current checkin branch. Finally, we also take account of the itemtype level addition here too. NOTE: There weren't any unit tests for this Koha::Patron method.. we should add some here! Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #887 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204997&action=e… Bug 10190: Complete Vue.js rewrite of Circulation Triggers administration interface This patch introduces a modern Vue.js-based interface for managing circulation triggers (overdue notice/status triggers), replacing the legacy Tools-based interface with a more intuitive, feature-rich administration page. New Features Enhanced Visibility & Navigation - Exhaustive effective rule lists showing all rules that apply to each context - Toggle between "all exhaustive rules" and "explicitly set rules" views - Advanced filtering by patron category and/or item type - Clear display of fallback/default rules for each context Rule Management Actions - Delete triggers (last trigger in a sequence for any given library) - Reset entire rule sets for a given context (with safeguards) - Edit existing triggers with improved context awareness - Add new triggers with intelligent delay constraints Improved User Experience - Multi-step form wizard with clear workflow progression - Context-aware letter template filtering (only shows applicable templates) - Placeholder values showing fallback rules when clearing inputs - Dynamic min/max constraints for delay values based on neighboring triggers - Real-time form validation and feedback - Partial page reloads (only reload affected sections, not entire page) - Specific loading messages for different operations Technical Improvements - Centralized Vuex store for state management - Reusable CirculationTriggersForm component - API clients for libraries, circulation rules, item types, and patron categories - Consistent async/await pattern throughout - Separation of repositories, utilities, and services - Improved naming consistency and code maintainability - "Dumb" TriggersTable component for better separation of concerns Test Plan Prerequisites 1. Log in to staff interface with appropriate permissions (tools_edit_notice_status_triggers) 2. Ensure you have test data: multiple libraries, patron categories, item types, and notice templates 3. Navigate to Administration > Circulation triggers (new interface) Part 1: Basic Navigation & Interface 1. Verify the new "Circulation triggers" link appears in Administration home under the Circulation section 2. Access the new interface and confirm it loads successfully 3. Verify the default view shows either "All libraries" or your logged-in library based on DefaultToLoggedInLibraryOverdueTriggers system preference 4. Confirm the interface displays a list of triggers organized by context (library/patron category/item type combinations) Part 2: Viewing and Filtering Rules 1. Toggle between "All exhaustive rules" and "Explicitly set rules" views - Verify "All exhaustive rules" shows inherited/fallback rules - Verify "Explicitly set rules" shows only rules you've specifically configured 2. Test the patron category filter: - Select a specific patron category - Confirm only rules for that category are displayed 3. Test the item type filter: - Select a specific item type - Confirm only rules for that item type are displayed 4. Test combined filters (patron category + item type simultaneously) 5. Clear filters and verify all rules display again Part 3: Adding New Triggers 1. Click "Add trigger" button 2. Step 1 - Confirm Context: - Select Library (required) - Select Patron category (required) - Select Item type (required) - Click "Confirm context" 3. Step 2 - Review Existing Triggers: - Verify existing triggers for this context are displayed - Note the trigger numbers and delays 4. Step 3 - Configure New Trigger: - Enter a delay value (should be constrained by neighboring triggers) - Try entering an invalid delay (too low or too high) - verify validation - Set "Restricts checkouts" (Yes/No/Fallback to default) - Note the placeholder showing the fallback value - Select a letter template - Verify only templates for the selected library context appear - Set "Debarring" options if desired - Select "Charged notice fees" if applicable 5. Submit the form 6. Verify the new trigger appears in the list without a full page reload 7. Verify success message is displayed Part 4: Editing Existing Triggers 1. Locate an existing trigger in the list 2. Click the edit icon/button 3. Verify the form pre-populates with existing values 4. Test delay modification: - Try changing the delay within valid bounds - should succeed - Try changing delay beyond neighboring triggers - should show validation error - Use the increment/decrement buttons to adjust delay 5. Test clearing values: - Clear a field (e.g., delay or restrict checkouts) - Verify placeholder shows the fallback/default value - Submit with cleared value - should save as null and inherit fallback 6. Change the letter template to a different valid template 7. Submit changes 8. Verify the trigger updates in the list without full page reload 9. Verify the changes persist after refreshing the page Part 5: Deleting Triggers 1. Identify a trigger that is the last in its sequence 2. Click the delete button/icon 3. Verify a confirmation dialog appears 4. Confirm deletion 5. Verify the trigger is removed from the list without page reload 6. Verify the deletion persists after page refresh 7. Test delete constraints: - Try to delete a trigger that's not the last in sequence - Verify appropriate error/warning message Part 6: Resetting Rule Sets 1. Locate a context with explicitly set rules (not just inherited) 2. Ensure this is not the only rule set for this trigger sequence 3. Click the "Reset" button for that context 4. Verify confirmation dialog explains what will be reset 5. Confirm the reset 6. Verify the explicit rules are removed and context now shows inherited rules 7. Verify changes persist after page refresh 8. Test reset constraints: - Try to reset when it would leave no rules for that trigger - Verify appropriate warning/prevention Part 7: Context-Specific Behavior 1. Test library-specific letter filtering: - Create/edit a trigger for a specific library - Verify only letter templates with matching branchcode or default templates appear - Switch to a different library context - Verify the letter list updates accordingly 2. Test default rules: - View rules for "All libraries" / "All patron categories" / "All item types" - Verify these are labeled as "Default rule for [context]" - Confirm these serve as fallback for more specific rules 3. Test DefaultToLoggedInLibraryOverdueTriggers preference: - Set preference to "Yes" - Reload circulation triggers page - Verify it defaults to your logged-in library - Set preference to "No" - Verify it defaults to "All libraries" Part 8: Form Workflow & Validation 1. Test required fields: - Try submitting add/edit form without selecting library - should fail - Try submitting without patron category - should fail - Try submitting without item type - should fail 2. Test stepper navigation: - Start adding a trigger - Verify you must confirm context before proceeding - Verify you see existing triggers before editing/adding - Verify trigger form only appears after context confirmation 3. Test cancellation: - Start adding/editing a trigger - Click Cancel - Verify you return to the list without changes - Verify no partial data was saved Part 9: Loading States & Messages 1. On slow connections or with many rules: - Verify "Loading context..." appears while fetching context data - Verify "Loading rule set information..." appears while fetching rules - Verify section-specific loading messages appear during updates 2. After form submission: - Verify appropriate success/error messages display - Verify loading indicators during async operations Part 10: Permissions 1. Log in as a user without tools_edit_notice_status_triggers permission 2. Verify the "Circulation triggers" link does not appear in Administration 3. Try accessing /cgi-bin/koha/admin/circulation_triggers directly 4. Verify access is denied Part 11: Data Integrity & Persistence 1. Create a complex set of rules with multiple triggers across different contexts 2. Refresh the page and verify all rules persist 3. Restart the Koha services 4. Verify all rules still display correctly 5. Check the database circulation_rules table: - Verify rules are stored with correct rule_name pattern (overdue_1_delay, etc.) - Verify null values are properly stored for inheritance - Verify the overdue_X_has_rules rule kind is present Part 12: Edge Cases 1. Test with no existing triggers - verify empty state message 2. Test with maximum trigger sequences (e.g., trigger 1, 2, 3) 3. Test rapid successive edits 4. Test with special characters in letter template names 5. Test browser back/forward buttons during form workflow Part 13: Comparison with Legacy Interface 1. Access the old interface if still available (via Tools menu) 2. Create a trigger using the new interface 3. Verify it appears correctly in the old interface (if applicable) 4. Create a trigger using the old interface (if still available) 5. Verify it appears correctly in the new interface Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #886 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204996&action=e… Bug 10190: Let the circulation_rules endpoint accept query parameters Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #885 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 204995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204995&action=e… Bug 10190: Rework logic of overdue_notices This patch enhances the overdue_notices script to understand the newly introduced itemtype level for overdue rules. The original logic for digesting overdues in the overdue notices script was flawed given the additional itemtype handling introduced in this patchset and the way in which it handles effective fallbacks for rules. This patch tidies the file and reworks the logic so that we fetch overdues by patron category and branch and then iterate through those comparing to the correct effective rules and combing them into digest groups based on notice + trigger level. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0