June 2016 - Koha-bugs - lists.koha-community.org

[Bug 16513] New: Improvements and fixes for quote upload process
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16513 Bug ID: 16513 Summary: Improvements and fixes for quote upload process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I have a few minor improvements and fixes for the Quotes editor and upload process: - Removing 'onclick' - Making the 'Cancel upload' button work correctly - Add a 'Cancel upload' button to the toolbar - Capitalization corrections -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 16494] New: Remove the use of "onclick" from some patron pages
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16494 Bug ID: 16494 Summary: Remove the use of "onclick" from some patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Several patron-related pages include the use of "onclick" attributes. These should be replaced in favor of defining events in JavaScript. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16490] New: Add an "add to cart" link for each search results in the staff client
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16490 Bug ID: 16490 Summary: Add an "add to cart" link for each search results in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/search.pl?q=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org On the OPAC search results page each line has an "add to cart" link. This lets the user select individual results without having to check a box and scroll all the way to the top. I propose to add this to the staff client search results. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16477] New: Improve staff client cart JavaScript and template
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 Bug ID: 16477 Summary: Improve staff client cart JavaScript and template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I'm working on a patch which will make several updates to the staff client cart template and JavaScript, including removal of "onclick," moving JS out of the template, and other template improvements. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 16469] New: Remove the use of "onclick" from some catalog pages
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '16

01 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 Bug ID: 16469 Summary: Remove the use of "onclick" from some catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Two catalog-related templates contain the use of "onclick" and should be modified to remove it: catalogue/results.tt and catalogue/imageviewer.tt. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16008] New: noisy "fatal" warning when new file is moved in another patch
by bugzilla-daemon＠bugs.koha-community.org 22 Jul '16

22 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Bug ID: 16008 Summary: noisy "fatal" warning when new file is moved in another patch Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com While working on Bug 15870, koha qa test tools gave this error fatal: ambiguous argument 't/db_dependent/RecordProcessor_ViewPolicy.t': unknown revision or path not in the working tree. This is in part, because a test file was moved/renamed and the files changed list includes the old filename. Gracefully handle the file no longer existing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 15824] New: 'Done' button is unclear on batch item modification and deletion
by bugzilla-daemon＠bugs.koha-community.org 21 Jul '16

21 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Bug ID: 15824 Summary: 'Done' button is unclear on batch item modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org To reproduce, go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) Click edit -> Edit items in a batch Click Save (you don't need to make any changes) Notice Done link at the bottom of the page is not very noticeable. This is the same with batch item deletion as well. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Bug ID: 15759 Summary: Allow Koha::Object derived objects to be used as hashrefs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16166] New: Improve L1 cache performance
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16166 Bug ID: 16166 Summary: Improve L1 cache performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org Bug 16044 introduced two-level caching mechanism to Koha::Cache. By default, get_from_cache() returns a deep copy of the data structures stored in L1 cache (aka "safe mode"). For extremely big and/or complex data structures (like MARC framework hash-of-hashes-of-hashes returned by GetMarcStructure() ), deep-cloning is currently very sub-optimal (i.e., 2-3x slower after Bug 16044); this patch addresses that particular issue. See also: Bug 16044 comments #18 - #23 -- You are receiving this mail because: You are watching all bug changes.

1 43

[Bug 16076] New: DBIx searches - performance issues
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 Bug ID: 16076 Summary: DBIx searches - performance issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org While testing Bug 11998 and Bug 15341, I did some quick & dirty comparisons on DBI vs DBIx search performace - how long does it take to fetch from the database: one small system preference (marcflavour) and all system preferences (545 rows). Results: 1) one syspref, DBI: 130 microseconds ( using 'SELECT value FROM systempreferences WHERE variable = ? LIMIT 1') 2) one syspref, DBIx: 1.25 miliseconds ( Koha::Config::SysPrefs->find($var)->value() ) 3) all preferences, DBI: 1.8 miliseconds ( 'SELECT variable, value FROM systempreferences' ) 4) all preferences, DBIx: 21 miliseconds ( Koha::Config::SysPrefs->search()->unblessed(), like in Bug 15341) If I use my $all_prefs_rs = Koha::Config::SysPrefs->search( undef, { columns => [qw/value variable/] } )->unblessed(); in 4), search is a bit quicker (17.1 ms). Maybe it can be improved somehow further, but I don't know how - any ideas? Those numbers may look not very significant at the first glanace, but remember that it's not uncommon for the Koha script to make 2000+ DBI calls (in such cases, they are usually very repetitive - small stuff fetched from uncomplicated tables, over and over again). -- You are receiving this mail because: You are watching all bug changes.

1 6