December 2017 - Koha-bugs - lists.koha-community.org

[Bug 18242] New: Remove primary key on old_issues.issue_id
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Bug ID: 18242 Summary: Remove primary key on old_issues.issue_id Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. -- You are receiving this mail because: You are watching all bug changes.

1 49

[Bug 17466] New: Show number of outstanding issues when checking in
by bugzilla-daemon＠bugs.koha-community.org 18 Jan '18

18 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Bug ID: 17466 Summary: Show number of outstanding issues when checking in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 18363] New: Delink analytical records is gone
by bugzilla-daemon＠bugs.koha-community.org 17 Jan '18

17 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18363 Bug ID: 18363 Summary: Delink analytical records is gone Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: verolencinas(a)yahoo.com.ar QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In Koha 16.05.11 you cannot "delink" analytical records. The link is gone and the action buttons don't display this option on the analytical record. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 19514] New: No Password restrictions in onboarding tool patron creation
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514 Bug ID: 19514 Summary: No Password restrictions in onboarding tool patron creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P3 Component: Installation and upgrade (web-based installer) Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When a superlibrarian user account is created in the onboarding tool there is no checking of the password other than checking the two inputted password values are matching. This means the password length, complexity and if it contains whitespace is not checked. This means users can enter in weak passwords causing a security vulnerability which is particularly bad in this case because a superlibrarian user is being created. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 19599] New: anonymise_issue_history can be very slow on large systems
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599 Bug ID: 19599 Summary: anonymise_issue_history can be very slow on large systems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When running anonymise_issue_history we now call it on a set of patrons from search_patrons_to_anonymise, however, this generates a slow SQL query that can take hours to run. UPDATE `old_issues` SET `old_issues`.`borrowernumber` = '9807' WHERE ( `issue_id` IN ( SELECT * FROM ( SELECT `old_issues`.`issue_id` FROM ( SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`, `me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`, `me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`, `me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang`, `me`.`login_attempts`, `me`.`overdrive_auth_token` FROM `borrowers` `me` LEFT JOIN `old_issues` `old_issues` ON `old_issues`.`borrowernumber` = `me`.`borrowernumber` WHERE ( ( `old_issues`.`borrowernumber` IS NOT NULL AND `privacy` <> '0' AND `returndate` < '2017-05-13 00:00:00' ) ) GROUP BY `borrowernumber`) `me` JOIN `old_issues` `old_issues` ON `old_issues`.`borrowernumber` = `me`.`borrowernumber` WHERE ( `returndate` < '2017-05-13 00:00:00' ) ) `_forced_double_subquery` ) ) I think anonymise_issue_history should be a standalone function taking the same params as search_patrons_to_anonymise to eliminate nesting of queries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 19830] New: Add the Koha::Patron->old_checkout method
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830 Bug ID: 19830 Summary: Add the Koha::Patron->old_checkout method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 17833] New: Memcached silently fails to _initilize_memcached() on the second time it is invoked
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Bug ID: 17833 Summary: Memcached silently fails to _initilize_memcached() on the second time it is invoked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When _initilize_memcached() is called the first time, it sets the 'ismemcached'-key and returns 1. When _initilize_memcached() is called the second time, the 'ismemcached'-key already exists and '' is returned (this default to False in Perl). Koha thinks that memcached is not in use and decides to use some other caching mechanism instead. Cache::Memcached::Fast returns undef on server error: https://metacpan.org/pod/Cache::Memcached::Fast#add Koha MUST listen to undefined, instead of False to define whether or not memcached is properly working. Also added simple helpful diagnostics to help identify and log when this memcached server connection problem arises. Here is a small test run to verify this behaviour: root@kohadev:~# echo "fresh memcached start" fresh memcached start root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '1' getkey: 'text' root@kohadev:~# echo "val already cached" val already cached root@kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '' getkey: 'text' root@kohadev:~# echo "memcached killed and not responding" memcached killed and not responding root@kohadev:~# perl l.pl undef getkey: '' root@kohadev:~# echo "The return value is undefined" The return value is undefined root@kohadev:~# Here is the code snippet used to test the Memcached-server in the previous example output: kivilahtio@koha_ci_1 /h/k/Koha> cat t.pl use Cache::Memcached::Fast; use Modern::Perl; my $memd = new Cache::Memcached::Fast({ servers => [ '/lxcBindMount/tmp/memcached.sock' ], namespace => 'koha_ci_1:', connect_timeout => 0.2, io_timeout => 0.5, close_on_error => 1, max_failures => 3, failure_timeout => 2, ketama_points => 150, nowait => 1, hash_namespace => 1, }); # Get server versions. my $versions = $memd->server_versions; while (my ($server, $version) = each %$versions) { print "$server $version\n"; } # Store scalars. my $rv = $memd->add('skey', 'text'); print "undef\n" if not defined $rv; print "def : '$rv'\n" if defined $rv; print "getkey: '".$memd->get('skey')."'\n"; -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 19304] New: Move C4::Members::GetNoticeEmailAddress to Koha::Patron-> notice_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19304 Bug ID: 19304 Summary: Move C4::Members::GetNoticeEmailAddress to Koha::Patron->notice_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 19303] New: Move C4::Members::GetFirstValidEmailAddress to Koha:: Patron->first_valid_email_address
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19303 Bug ID: 19303 Summary: Move C4::Members::GetFirstValidEmailAddress to Koha::Patron->first_valid_email_address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This new Koha::Patron->first_valid_email_address already exists, it should be called directly. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19300] New: Move C4::Reserves:: OPACItemHoldsAllowed to the code namespace
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '18

16 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300 Bug ID: 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the code namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 25