October 2018 - Koha-bugs - lists.koha-community.org

[Bug 18720] New: Get rid of "die" in favor of exceptions in C4:: Acquisition::GetBasketAsCsv
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Bug ID: 18720 Summary: Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org See bug 8612: (Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 21080] New: patron attribute classes break patron's edit view
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Bug ID: 21080 Summary: patron attribute classes break patron's edit view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 7154 When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154 [Bug 7154] Group borrower attributes and link between patron category and attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 21242] New: Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 Bug ID: 21242 Summary: Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The code seems to make the assumption that if we come from circ, we only want to view the borrowers info, however, it provides the full form, indicating you can search for more info. To recreate: 1 - Pull up a patron 2 - Click 'Modification log' 3 - You see info about patron 4 - Change the form, moving Object to Info 5 - You are sent to a blank circ page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 21634] New: "Circulation" option is lost when viewing patron's logs
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21634 Bug ID: 21634 Summary: "Circulation" option is lost when viewing patron's logs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: - View a patron detail page - Click "Modification log" - Notice that the url has "modules=MEMBERS&modules=circulation", but the "Circulation" option is not selected in the "Modules" dropdown list. This is because of uppercase vs lowercase. The bug: - Right after you click "Modification log" you will see all the "members" and "circulation" logs - Submit the form without changing any input/select from the form => Now you only see the "members" logs. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 21349] New: Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21349 Bug ID: 21349 Summary: Instructors with special characters (e.g. $, ., :) in their cardnumber cannot be removed from course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org To recreate: - create a patron with a barcode that contains a character that is meaningful for CSS/jQuery selectors: comma, $, ., :, [, ], =, or @ - create a course and add them to it as an instructor - on /cgi-bin/koha/course_reserves/course.pl?course_id={{course_id}} click the "remove" link attempting to remove them from the course - ...nothing happens The source of this issue is the RemoveInstructor JavaScript function in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt - it accepts a single "cardnumber" parameter which isn't sanitized before being used in a jQuery selector. Therefore if punctuation that's meaningful in a selector appears in a patron's barcode, the function throws an error. Here's an actual example from our Koha instance: Uncaught Error: Syntax error, unrecognized expression: #borrower_PCAC000029831$ at Function.fa.error (jquery-2.2.3.min.js:2) at fa.tokenize (jquery-2.2.3.min.js:2) at fa.select (jquery-2.2.3.min.js:2) at Function.fa [as find] (jquery-2.2.3.min.js:2) at n.fn.init.find (jquery-2.2.3.min.js:2) at n.fn.init.a.fn.find (jquery-migrate-1.3.0.min.js:2) at a.fn.init.n.fn.init (jquery-2.2.3.min.js:2) at new a.fn.init (jquery-migrate-1.3.0.min.js:2) at n (jquery-2.2.3.min.js:2) at RemoveInstructor (course.pl?course_id=39:224) The solution to this is to sanitize the cardnumber before using it, as described by this article for instance: https://learn.jquery.com/using-jquery-core/faq/how-do-i-select-an-element-b… I'll send along a patch shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 21654] New: Installer is loading a non-existing file
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Bug ID: 21654 Summary: Installer is loading a non-existing file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql But this file has been removed by 14048 -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 21629] New: List sort on call number does not use cn_sort
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Bug ID: 21629 Summary: List sort on call number does not use cn_sort Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: mkstephens(a)lancasterseminary.edu QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When viewing a list in the staff client, one can click on the "Call Number" column to have the list sort to call number order. I am noticing that the order does not sort correctly by cn_sort value. For example, we use LC Classification in our library. When clicking the "Call Number" column to sort in ascending order, Koha put these call numbers in this (incorrect) order: - BV4011.3 .W55 2016 - BV5 .W54 1980 - BV811.2 .W44 1980 - BV825.2 .W54 1981 This problem also appears when a list's settings are set to order by call number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 21639] New: Phone notice transports do not exist for new installs
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Bug ID: 21639 Summary: Phone notice transports do not exist for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org SELECT * FROM message_transports; there are no phone transports Enable TalkingTechItivaPhoneNotification and EnhancedMessagingPreferences Open a patron Note you can see phone as an option, but not check it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 21603] New: Remove Group by clause in SearchCourses
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Bug ID: 21603 Summary: Remove Group by clause in SearchCourses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org I am not certain we can simply remove here, but the GROUP by seems to stem form adding course instructors, though we fetch the instructors for each course after this query 971 $query .= " 972 LEFT JOIN course_instructors ci 973 ON ( c.course_id = ci.course_id ) 974 LEFT JOIN borrowers b 975 ON ( ci.borrowernumber = b.borrowernumber ) 976 LEFT JOIN authorised_values av 977 ON ( c.department = av.authorised_value ) 978 WHERE 979 ( av.category = 'DEPARTMENT' OR av.category = 'TERM' ) 980 AND 981 ( 982 department LIKE ? OR 983 course_number LIKE ? OR 984 section LIKE ? OR 985 course_name LIKE ? OR 986 term LIKE ? OR 987 public_note LIKE ? OR 988 CONCAT(surname,' ',firstname) LIKE ? OR 989 CONCAT(firstname,' ',surname) LIKE ? OR 990 lib LIKE ? OR 991 lib_opac LIKE ? 992 ) 993 AND 994 c.enabled LIKE ? 995 GROUP BY c.course_id 996 "; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 21612] New: Incorrect GROUP BY in Koha::Virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '18

28 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Bug ID: 21612 Summary: Incorrect GROUP BY in Koha::Virtualshelves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record for get_private_shelves, get_public_shelves and get_some_shelves -- You are receiving this mail because: You are watching all bug changes.

1 12