December 2018 - Koha-bugs - lists.koha-community.org

[Bug 18377] New: Add Plack/PSGI file for dev install
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Bug ID: 18377 Summary: Add Plack/PSGI file for dev install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated (you need 2 plack servers running — 1 for opac and 1 for intranet — and the REST API is not enabled in it) I'll attach a new one, based on debian/templates/plack.psgi but suited for a dev install -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 16733] New: Adjust or make flexible some paths in debian scripts
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Bug ID: 16733 Summary: Adjust or make flexible some paths in debian scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 66

[Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key?
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Bug ID: 18003 Summary: Should deletedborrowers.borrowernumber be a primary key? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17782 (Raised from bug 17782) DBIC needs a primary key to work correctly. We could be tempt to make borrowernumber a primary key, but a use case could bring thing. Indeed if a table is empty and the mysql (mariadb behaves identically) server restarted, the Auto Increment (AI) is reset. Problematic use case: 1. Install Koha 2. Create a patron (borrowers.borrowernumber = 1) 3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2 4. Restart mysql => borrowers is empty so AI is reset 5. Create a patron (borrowers.borrowernumber = 1) 6. Delete it => We will try to insert a new row with an existing borrowernumber (1) into the deletedborrowers table: BOOM Solution 1: Do not care about this problematic use case and prevent to delete the last patron. Solution 2: Add a AI primary key (id) to deletedborrowers => The 2 tables borrowers and deletedborrowers will differ, bugs will be expected Solution 3: Deal with that at code level: when a patron is created, guess the borrowernumber it will get and check if it does not already exist in the deletedborrowers table. If so, force it before inserting it Solution 4: Do not enforce this constraint at DB level but set the primary key to DBIC schema: Koha::Schema::Result::Deletedborrower: __PACKAGE__->set_primary_key("borrowernumber"); Problem: Koha::Database->new->schema->resultset('Deletedborrower')->find(42); will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single" if 42 is duplicated, and the first matching row will be picked Another solution? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 16636] New: t/00-load.t warning from C4/External/BakerTaylor.pm
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Bug ID: 16636 Summary: t/00-load.t warning from C4/External/BakerTaylor.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset(a)hotmail.com Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 16342] New: Placks breaks Baker and Taylor cover images
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342 Bug ID: 16342 Summary: Placks breaks Baker and Taylor cover images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org BakerTaylorImageURL is constructed through C4/External/BakerTaylor.pm under plack the initialisation/passing of these variables doesn't work To recreate (you do not need a B&T account): Put any old values into: BakerTaylorBookstoreURL BakerTaylorUsername BakerTaylorPassword and set BakerTaylorEnabled to 'Add' With plack off: Images should be constructed with URL like: http://contentcafe2.btol.com/ContentCafe/Jacket.aspx?UserID=$user&Password=… With plack enabled you get img src=BakerTaylorLinkURL... -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 21219] New: NULL values in updated_on field break the Patrons REST API
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219 Bug ID: 21219 Summary: NULL values in updated_on field break the Patrons REST API Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)jsense.co.uk The swagger definition does not allow for updated_on to be NULL but the database does allow this. If a patron has a null value then the REST service call fails. The history of this is as follows: Bug #10459 (released in 16.05.01) - updated_on field added to borrowers table, NULL allowed Bug #17651 (released in 16.11) - fix swagger definition to allow for NULL "updated_on": { - "type": "string", + "type": ["string", "null"], "description": "time of last change could be useful for synchronization with external systems (among others)" }, Bug #16330 (released in 18.05) - removes the null option from the definition "updated_on": { - "type": ["string", "null"], + "type": "string", "format": "date-time", "description": "time of last change could be useful for synchronization with external systems (among others)" }, You can see that the last push undid the previous bug fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 21089] New: Bad floats in Ordering information on acqui/supplier.pl
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21089 Bug ID: 21089 Summary: Bad floats in Ordering information on acqui/supplier.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org I haven’t checked master yet, but in the 17.xx versions, I’m noticing it is really difficult to click the dropdown for “List prices are:” in “Ordering information” on /cgi-bin/koha/acqui/supplier.pl. When I look using the F12 tools in Chrome, I see that later “ol” elements are overlapping earlier “li” elements. So the “ol” for the tax options is sitting on top of the “li” for “List prices are:”. Only a tiny part of the “li” is clickable underneath that “ol”. It looks like the floats in the “li” element are causing the sizing of the “ol” to be no good. See https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_con…. There are a number of strategies for fixing this but I’m not sure what the best one would be here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley(a)catalyst.net.nz Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 16231] New: Correct permission handling in subscription edit menu
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Bug ID: 16231 Summary: Correct permission handling in subscription edit menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The "Edit" toolbar menu for serials contains three items, "Edit subscription," "Edit as new (duplicate)" and "Delete subscription." Each item should be wrapped in its own check for the "CAN_user_serials_*" permission. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 21013] New: Missing itemtype for checkut makes patron summary print explode
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013 Bug ID: 21013 Summary: Missing itemtype for checkut makes patron summary print explode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If there is a checkout on the patron account for an item without item type (item level itemtypes), then the 'print summary' will explode into an Internal server error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11