March 2018 - Koha-bugs - lists.koha-community.org

[Bug 19474] New: Convert staff client CSS to SCSS
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Bug ID: 19474 Summary: Convert staff client CSS to SCSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I propose a new workflow for handling CSS in the staff client based on the work in Bug 15522 which adds a client-side asset processing workflow. My patch will be designed to work independently from that bug but use the same framework so that the two can be merged easily. - Uses yarn (https://yarnpkg.com) to manage installation of npm dependencies - Uses gulp (https://gulpjs.com) to process client-side assets. In this case, conversion of SCSS to CSS, auto-prefixing of CSS, minification of CSS. This patch will add a configuration file for sass-lint (https://github.com/sasstools/sass-lint) to help standardize how we write SCSS. The version I'm working with is pretty much the default, and I hope it won't be controversial. I'm using this configuration file in conjunction with my editor's linting plugin. We might later plug sass-lint into the gulp build process. The patch will include a conversion of staff-global.css to SCSS and remove staff-global.css from git. -- You are receiving this mail because: You are watching all bug changes.

1 101

[Bug 17140] New: Incorrect rounding in total fines calculations, part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Bug ID: 17140 Summary: Incorrect rounding in total fines calculations, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: larit(a)student.uef.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 15741 fixes some rounding issues but not all, for example trying to paying a fine of 1.14 still does not work (also 1.39). To replicate bug: 1. Go to patron's fines tab, make sure there are no outstanding payments. 2. Via "Create manual invoice" tab, create one fine of 1.14 3. Go to Pay fines tab 4. Click "Pay amount" and confirm. 5. Observe error message "You must pay a value less than or equal to 1.14." 6. Go to Pay fines tab 7. Click "Pay selected" and confirm 8. Observe error message "You must pay a value less than or equal to 1.14." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 77

[Bug 19524] New: Share patron lists between staff
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Bug ID: 19524 Summary: Share patron lists between staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse(a)bywatersolutions.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Some libraries would like to allow arbitrary lists to be used by all librarians with the 'manage_patron_lists' permission. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 18736] New: Problems in order calculations (rounding errors)
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Bug ID: 18736 Summary: Problems in order calculations (rounding errors) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The way we are calculating and/or storing our prices in acquisitions is causing some odd issues. For example: Place an order (no tax, let's not even deal with that right now please) listprice/rrp = 16.99 discount = 42% quantity = 8 estimated calculated at 9.85 but order total is 78.83, but 8 times 9.85 = 78.80 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 215

[Bug 18344] New: Allow overdue fines cap at replacement price, and cap by amount to work together
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Bug ID: 18344 Summary: Allow overdue fines cap at replacement price, and cap by amount to work together Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 19915] New: Inventory tool doesn't use cn_sort for callnumber ranges
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Bug ID: 19915 Summary: Inventory tool doesn't use cn_sort for callnumber ranges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When doing an inventory a range of GT90 to GT100 for LC callnumbers the results won't include GT95 We should convert the numbers and use the cn_sort column for fetching items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 85

[Bug 19383] New: Add ability to print hold receipts automatically
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19383 Bug ID: 19383 Summary: Add ability to print hold receipts automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Some libraries don't wish to require librarians to confirm each hold during checkin. Instead they would like to only be alerted that a hold was filled. To implement this we should: 1) Implement new system preference to automatically confirm holds 2) Implement new system preference to automatically print confirmed hold receipts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 17171] New: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Bug ID: 17171 Summary: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Work to be done: 1) Add new system preference AutoReturnCheckedOutItemForNewCheckout ( or something more terse ) 2) Add new system preference AutoReturnCheckedOutItemForNewCheckoutForgiveFine 3) Modify circulation.pl to accept these new parameters and report what happened (yellow box) instead of prompting for confirmation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 42

[Bug 19893] New: Alternative optimized indexing for Elasticsearch
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Bug ID: 19893 Summary: Alternative optimized indexing for Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com At our library perhaps owning to a larger than average number of biblios a full re-index takes an unacceptable amount of time complete (> 24h). We also had an issue with indexing becoming increasingly slower when new mappings are added. After some profiling using NYTProf it became clear most of this overhead is in Catmandu::Store::ElasticSearch and Catmandu::MARC. After giving it some thought the simplest way to resolve this issue actually seemed to be to replace these libraries with Koha-specific code, since the functionality provided is actually not that hard to re-implement in a more efficient manner. Due to the complexity of Catmandu optimizing these libraries would most likely be more challenging (and some parts are not actually possible to optimize because of limitations owing to the architecture of Catmandu/Fix). Main benefits include: 1) Increased indexing performance (about twice as fast, six times as fast if comparing time spent in update_index()), due to more efficient json-conversion and fewer Elasticsearch requests. 2) With Catmandu indexing speed decreases as more mappings are added, with the alternative algorithm indexing is kept more or less constant no matter how many mappings you add. 3) Neglectable indexing start-up time. For example we have an issue with the book drop machine, each return taking a couple of seconds because of the catmandu start-up overhead. 4) More transparent code and less complexity compared with Catmandu. With this patch the largest bottleneck is instead Marc::Record::as_xml_record, to use marc21 as serialization format would probably be a lot faster but still chose marc-xml because of the binary format length limitation (which could be exceeded with many items). Still, I will probably try to look into faster marc-xml serialization options in the future to address this. I also attach profiling results with and without the patch applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 293

[Bug 20006] New: Adapt /v1/holds to new naming guidelines
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '20

12 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Bug ID: 20006 Summary: Adapt /v1/holds to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51