March 2019 - Koha-bugs - lists.koha-community.org

[Bug 21422] New: Create logging for any action triggered by a staff override
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '19

08 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21422 Bug ID: 21422 Summary: Create logging for any action triggered by a staff override Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com E.g. log checkouts overridden by AgeRestrictionOverride AllFinesNeedOverride AllowFineOverride AllowNotForLoanOverride AllowRenewalLimitOverride AllowTooManyOverride or holds overridden by AllowHoldPolicyOverride -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 20671] New: Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20671 Bug ID: 20671 Summary: Adding "surname" to instructions. import_borrowers.pl / import_borrowers.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: jesse(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It appears that surname is now a required field when importing a file with patron data. According to the instructions, however, only 'branchcode' and 'categorycode' are required. Latter should be amended if surname is now required as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 18377] New: Add Plack/PSGI file for dev install
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377 Bug ID: 18377 Summary: Add Plack/PSGI file for dev install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Koha lacks a proper Plack file for dev install. debian/templates/plack.psgi is for package install and misc/plack/koha.psgi seems a bit outdated (you need 2 plack servers running — 1 for opac and 1 for intranet — and the REST API is not enabled in it) I'll attach a new one, based on debian/templates/plack.psgi but suited for a dev install -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 16733] New: Adjust or make flexible some paths in debian scripts
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Bug ID: 16733 Summary: Adjust or make flexible some paths in debian scripts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 66

[Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key?
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Bug ID: 18003 Summary: Should deletedborrowers.borrowernumber be a primary key? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17782 (Raised from bug 17782) DBIC needs a primary key to work correctly. We could be tempt to make borrowernumber a primary key, but a use case could bring thing. Indeed if a table is empty and the mysql (mariadb behaves identically) server restarted, the Auto Increment (AI) is reset. Problematic use case: 1. Install Koha 2. Create a patron (borrowers.borrowernumber = 1) 3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2 4. Restart mysql => borrowers is empty so AI is reset 5. Create a patron (borrowers.borrowernumber = 1) 6. Delete it => We will try to insert a new row with an existing borrowernumber (1) into the deletedborrowers table: BOOM Solution 1: Do not care about this problematic use case and prevent to delete the last patron. Solution 2: Add a AI primary key (id) to deletedborrowers => The 2 tables borrowers and deletedborrowers will differ, bugs will be expected Solution 3: Deal with that at code level: when a patron is created, guess the borrowernumber it will get and check if it does not already exist in the deletedborrowers table. If so, force it before inserting it Solution 4: Do not enforce this constraint at DB level but set the primary key to DBIC schema: Koha::Schema::Result::Deletedborrower: __PACKAGE__->set_primary_key("borrowernumber"); Problem: Koha::Database->new->schema->resultset('Deletedborrower')->find(42); will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single" if 42 is duplicated, and the first matching row will be picked Another solution? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 16636] New: t/00-load.t warning from C4/External/BakerTaylor.pm
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 Bug ID: 16636 Summary: t/00-load.t warning from C4/External/BakerTaylor.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset(a)hotmail.com Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com Since the tests are expecting an initialize function, the initialize call was just moved outside of the INIT block. TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for hbyymmincr 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 16342] New: Placks breaks Baker and Taylor cover images
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16342 Bug ID: 16342 Summary: Placks breaks Baker and Taylor cover images Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org BakerTaylorImageURL is constructed through C4/External/BakerTaylor.pm under plack the initialisation/passing of these variables doesn't work To recreate (you do not need a B&T account): Put any old values into: BakerTaylorBookstoreURL BakerTaylorUsername BakerTaylorPassword and set BakerTaylorEnabled to 'Add' With plack off: Images should be constructed with URL like: http://contentcafe2.btol.com/ContentCafe/Jacket.aspx?UserID=$user&Password=… With plack enabled you get img src=BakerTaylorLinkURL... -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 21219] New: NULL values in updated_on field break the Patrons REST API
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '19

07 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21219 Bug ID: 21219 Summary: NULL values in updated_on field break the Patrons REST API Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)jsense.co.uk The swagger definition does not allow for updated_on to be NULL but the database does allow this. If a patron has a null value then the REST service call fails. The history of this is as follows: Bug #10459 (released in 16.05.01) - updated_on field added to borrowers table, NULL allowed Bug #17651 (released in 16.11) - fix swagger definition to allow for NULL "updated_on": { - "type": "string", + "type": ["string", "null"], "description": "time of last change could be useful for synchronization with external systems (among others)" }, Bug #16330 (released in 18.05) - removes the null option from the definition "updated_on": { - "type": ["string", "null"], + "type": "string", "format": "date-time", "description": "time of last change could be useful for synchronization with external systems (among others)" }, You can see that the last push undid the previous bug fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 22575] New: Item type administration uses invalid error class for dialog
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Bug ID: 22575 Summary: Item type administration uses invalid error class for dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- If you try to delete an item type which is in use, the error message you get is displayed in a white dialog with red text. This happens because the message "type" passed from the script is "error," a CSS class which is undefined. The script should send "alert" instead. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 22444] New: currencies_manage permission doesn't provide link to manage currencies when selected alone
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '19

06 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Bug ID: 22444 Summary: currencies_manage permission doesn't provide link to manage currencies when selected alone Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Bug 7651 added the permission currencies_manage within the acquisitions permission subgroup. Giving a borrower just this permission and catalogue does make them technically able to load /currency.pl, but it doesn't provide them any link to get there. To Test: - create a patron - give them currencies_manage and catalogue permissions - log in as this patron - observe that there is no Currencies link out of Acquisitions and Administration doesn't appear on the home page or the More menu - give the patron any other admin permission - observe that the Currencies link now shows in Acquisitions - take away admin permissions and give the patron full acquisitions permissions - observe that a link to Currencies still appears in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16