April 2020 - Koha-bugs - lists.koha-community.org

[Bug 24538] New: REMOTE_USER set to undef if koha_trusted_proxies contains invalid value
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '20

08 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 Bug ID: 24538 Summary: REMOTE_USER set to undef if koha_trusted_proxies contains invalid value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org If koha_trusted_proxies contains an invalid or unparseable value, say due to a typo, like "1.1.1.", it'll treat it as a 0.0.0.0/0 mask and match against everything. In my tests, this leads to REMOTE_USER being set to undef. (On the plus side, at least a 0.0.0.0/0 mask leads to zero privileges rather than all privileges.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 22823] New: Koha::Library needs a method for obtaining the incoming email address
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '20

07 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823 Bug ID: 22823 Summary: Koha::Library needs a method for obtaining the incoming email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There's a code pattern emerging (in bug 5770 and bug 22821 at least to my knowledge) where we grab a branches email address to send notifications to the branch. However, it's prone to make mistakes in the fallback order for assigning that address so we should factor it out into a method that can be called from Koha::Library. Should be as simple as >sub to_email { > my $self = shift; > return $self->branchreplyto || $self->branchemail || C4::Context->preference('ReplytoDefault') || C4::Context->preference('KohaAdminEmailAddress'); >} along with some appropriate POD and a walk of the codebase to replace existing occurrences of the pattern. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 46

[Bug 22296] New: Invoice adjustments are not populating to budget views
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '20

06 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Bug ID: 22296 Summary: Invoice adjustments are not populating to budget views Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When invoice adjustments were added they were made to populate spent.pl and ordered.pl, however, they are not taken into account on aqui-home.pl or aqbudgets.pl They must be added in to GetBudgetHierarchy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 18314] New: Account lockout
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '20

06 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Bug ID: 18314 Summary: Account lockout Change sponsored?: Sponsored Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To prevent brute force attacks on Koha accounts, staff and opac, we need to implement an account lockout process to Koha. After a number of failed login attempts a users account would become locked. The user would then need to use the reset password functionality to send a reset token to their email account. After a successful password reset the lockout flag would be removed. The number of failed login attempts before lockout will be configurable using a system preference. -- You are receiving this mail because: You are watching all bug changes.

1 60

[Bug 24417] New: Charges/Fees.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '20

05 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Bug ID: 24417 Summary: Charges/Fees.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I cannot recreate locally, but Jenkins has a failing test on Koha_19.11_U18, run 29: koha_1 | # Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 362. koha_1 | # got: '6' koha_1 | # expected: '5' koha_1 | koha_1 | # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Monday (96h - 24h * 0.25u)' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 396. koha_1 | # got: '24' koha_1 | # expected: '18' koha_1 | # Looks like you failed 2 tests of 7. koha_1 | koha_1 | # Failed test 'accumulate_rentalcharge tests' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 403. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 24353] New: privacy_guarantor_checkouts incorrectly shows No on moremember.pl
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '20

05 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Bug ID: 24353 Summary: privacy_guarantor_checkouts incorrectly shows No on moremember.pl Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To Test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl - Confirm patron correctly shows "Yes" on memberentry.pl and opac-privacy.pl - Confirm patron correctly shows privacy_guarantor_checkouts=1 in database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 18421] New: Make Coce cover images available for staff search
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '20

03 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Bug ID: 18421 Summary: Make Coce cover images available for staff search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: arm(a)hanover.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When turned on, Coce cover images appear in the OPAC only, not staff interface. (Coce Cover images - settings in enhanced content.) Desired setting would be like Amazon cover settings - the ability to turn on Coce images for the OPAC and/or the staff interface separately. Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC. While the Coce server is being populated with links it is desirable to have only the staff interface using Coce. After a time, when the Coce server has accumulated a large collection of links, it would then be turned on for public OPAC and used by both. I have Koha 3.22.07, and am testing with the Bywater Coce server. If this is under way or in more recent versions already, please comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 73

[Bug 18250] New: koha-common should start after memcached
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '20

03 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18250 Bug ID: 18250 Summary: koha-common should start after memcached Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 34

[Bug 25045] New: REST API public route accessible if OpacPublic is off
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '20

03 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Bug ID: 25045 Summary: REST API public route accessible if OpacPublic is off Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22061 There is RESTPublicAPI to deal with that, but both are enabled by default. One could think that turning OpacPublic off will make all the data non-accessible, but that's wrong. Maybe we need a note on OpacPublic to explain the situation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 [Bug 22061] Add route to change patron's password (public) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 56

[Bug 22470] New: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '20

03 Jul '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Bug ID: 22470 Summary: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: gveranis(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Target Milestone: --- UPDATE marc_subfield_structure SET kohafield='seriestitle' - it's missing the table name it should be $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle' WHERE tagfield='490' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.volume' WHERE tagfield='490' AND tagsubfield='v'" ); # empty old koha fields $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.volume' AND tagfield='440' AND tagsubfield='v'" ); lines 232-249 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20