August 2022 - Koha-bugs - lists.koha-community.org

[Bug 28420] New: Allow login via AzureAD OpenID-Connect
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 Bug ID: 28420 Summary: Allow login via AzureAD OpenID-Connect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: mark.jaroski(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Hi, At the World Health Organization our South-East Asian regional office uses Koha for their regional library, with access by all WHO staff in the region and selected staff worldwide. Since local user databases can present a security risk we require that all applications for staff be integrated with our identity provider which at the moment is Microsoft's AzureAD. AzureAD uses OpenID-Connect and is mostly drop-in compatible with Google's implementation, with the exception that in order to construct the URLs both for redirection and for validation you need to know the organization's Azure tenant ID. Because our system integrator is not interested in pursuing this integration I've taken it on myself, and so I've set up a development environment and have started working on the code. My plan is to set up the configuration parameters and to then use them in a very slightly altered copy of the current googleopenidconnect file. I think in the long run it would be better to have a generic OpenID-Connect configuration to allow integrations with other providers like Okta and OneLogin, but we don't need for the moment that so for now I'll just add the AzureAD provider. I'll read up on the rest of the contribution procedure, and I'll be back with a patch/PR in a few days. Best, Mark -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 30344] New: Changing a patron from a category that allows guarantors to one that doesn't should remove that link
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344 Bug ID: 30344 Summary: Changing a patron from a category that allows guarantors to one that doesn't should remove that link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If a child typo patron is changed to an adult type patron, it hides the patron's guarantors, but does not remove that link. We should be removing that link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 30351] New: Changing a patron type should warn librarian if a guarantor/guarantee relationship will be severed
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30351 Bug ID: 30351 Summary: Changing a patron type should warn librarian if a guarantor/guarantee relationship will be severed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Right now, if a librarian changes a child with guarantors to and adult, or an adult with guarantees to a child ( via Bug 30344 ), the relationship is severed automatically. It would be nice if there was a warning that this is going to happen. I'm thinking we could just have a warning show up beside the patron category selector if the new patron category would result in either guarantor relationships or guarantee relationships being severed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 31483] New: Minor UI problem in opac-reset-password.pl
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31483 Bug ID: 31483 Summary: Minor UI problem in opac-reset-password.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org When EnableExpiredPasswordReset is enabled, patrons can access a page to reset their password. In this page, the grey box that normally contains the breadcrumbs encompasses the whole form. To test: 1) Enable EnableExpiredPasswordReset 2) Find a patron and change their password so you know what it is supposed to be 3) In the database, expire the patron's password, e.g. UPDATE borrowers SET password_expiration_date = '2022-08-22' where borrowernumber = 21; 4) Go to the OPAC, try to log in with the patron's credentials 5) Click Reset your password => Note that the form is in the grey breadcrumbs box, you can compare with any other OPAC page, the grey box should only contain the breadcrumbs -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 20207] New: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207 Bug ID: 20207 Summary: Anonymous Purchase Suggestions show on OPAC even when OPACViewOthersSuggestions is set to Don't Show Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: jzairo(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When you enable AnonSuggestions and ALLOW patrons that aren't logged in to make purchase suggestions, once a suggestion has successfully been submitted, Anonymous Purchase Suggestions will show on OPAC even when system preference OPACViewOthersSuggestions, is set to Don't Show. The suggestions will show on opac-suggestions.pl. However, if you search for the title you suggested, you will get a message saying "You are not authorized to see pending purchase suggestions." -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 31177] New: Misplaced import in C4::ILSDI::Services
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Bug ID: 31177 Summary: Misplaced import in C4::ILSDI::Services Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Koha::I18N is not added where it should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 31489] New: Typo in EnableExpiredPasswordReset description
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31489 Bug ID: 31489 Summary: Typo in EnableExpiredPasswordReset description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This was noticed in Bug 29925 (comment 4 by Andrew) but it was pushed as is. The second sentence of the EnableExpiredPasswordReset system preference description is currently: If not enable patrons must either use the 'Forgot your password' feature or have staff reset their password. It should be: If not **enabled** patrons must either use the 'Forgot your password' feature or have staff reset their password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 18232] New: Koha::Cache::flush - Simply flush all caches
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232 Bug ID: 18232 Summary: Koha::Cache::flush - Simply flush all caches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org This is handy when upgrading Koha or fiddling with config. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 30988] New: Adding a more generic version of googleopenidconnect
by bugzilla-daemon＠bugs.koha-community.org 14 Nov '22

14 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988 Bug ID: 30988 Summary: Adding a more generic version of googleopenidconnect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: shi-yao.wang(a)inLibro.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Using any OpenID provider's discovery document, we could allow openid connections from more providers. There is Bug 21586 that already has a patch for generic OpenID implementation, but it uses a different approach from my proposed patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 68

[Bug 28507] New: Create Koha::Session wrapper to create consistent sessions throughout Koha
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '22

12 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28507 Bug ID: 28507 Summary: Create Koha::Session wrapper to create consistent sessions throughout Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org At the moment, there are a couple different places where authenticated sessions get created. One is checkauth() and another is check_api_auth(). I would also like to create consistently structured authenticated sessions from Koha Plugins. There should be a standard API for creating and fetching sessions. I propose a Koha::Session wrapper. It will define Koha's standard session key set and have some automatic population for things like 'ip' and 'lasttime'. There will also be a method for setting the C4::Context->userenv, which is something that gets done repeatedly in checkauth(), check_api_auth(), check_cookie_auth(), and other less relevant places (like checkpw_internal which is bizarre). I think that this is a reasonable step forward as we add AuthN and AuthZ to things like Koha plugins and Mojolicious controllers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9