October 2024 - Koha-bugs - lists.koha-community.org

[Bug 38278] New: Having access to subfund but not parent fund will break filters in acqui-home
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38278 Bug ID: 38278 Summary: Having access to subfund but not parent fund will break filters in acqui-home Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org If you have access to sub founds but not to the found they are children of, filters will be broken as soon as you try to access acqui-home. To reproduce: Prerequisites: 1 superlibrarian (S) and two staff members (A & B) 1 - Set permissions of A to: staff interface and budget_manage (do NOT check budget_manage_all). 2 - Set permissions of librarian B to: staff interface, acquisitions 3 - Create an active budget 4 - In this budget create a found (F1), give librarian B the ownership 5 - In this fund, create two subfound (SF1 and SF2), give librarian A the ownership 6 - create an inactive budget with a found (IF1) 7 - Log in as A, go to acquisition.pl, notice eveything works, you can see found F1, subfounds SF1 and SF2 and inactive found IF1, buttons "Expand all"," Collapse all","Hide inactive budgets ","Show inactive budgets" and dropdown menu work. 8 - Go to F1 and restrict the access to owner 9 - Repeat 6 -> the datatable is broken, you do not see F1 (expected) see SF1 and SF2 (expected) and see inactive found IF1 (unexpected), buttons "Expand all"," Collapse all","Hide inactive budgets ","Show inactive budgets" and dropdown menu do not work anymore + you have a js error in your console. This is very probably due to the tree structure not working since the parent node of owned subfounds is not returned by acqui-home.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Whilst this is very old style code, it's functional and was first submitted in 2015! I'd love to see export to RIS added as a button to the Modal (RIS is the standard for exporting data to citation management programs and is already supported in our bib export options) I'd also love to see this converted to using citeproc-js to allow csl profiles to be used for whatever citation style your institution mandates. But.. none of that is a fail for me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173524&action=e… Bug 14670: (QA follow-up) Tidy new code Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173523&action=e… Bug 14670: (QA follow-up) Add missing filter Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167535|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173522&action=e… Bug 14670: Fix tests and import Sponsored-by: Orex Digital Signed-off-by: Alexandre Noel <alexandre.noel(a)inlibro.com> Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167534|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173521&action=e… Bug 14670: Use 260 if 264 is empty Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167533|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173520&action=e… Bug 14670: Deal with empty publicatoin date Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167532|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173519&action=e… Bug 14670: Move modal code to an include file Also add an icon for the "Cite" entry. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167531|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173518&action=e… Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '24

28 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167530|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 173517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173517&action=e… Bug 14670: Fix earlier declaration in same scope Signed-off-by: Hugo Agud <hagud(a)orex.es> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0