December 2024 - Koha-bugs - lists.koha-community.org

[Bug 20053] New: Drop type attribute "text/javascript" used in OPAC template
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '26

06 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Bug ID: 20053 Summary: Drop type attribute "text/javascript" used in OPAC template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: indradg(a)l2c2.co.in QA Contact: testopia(a)bugs.koha-community.org If you run the Koha OPAC pages through the W3C validator it generates warnings about type attribute "text/javascript", since W3C now officially describes this as obsolete in HTML5 but still conforming to the standard with warnings [1] Since we are already pumping up HTML5 with <!DOCTYPE html>, I was thinking if we should consider an omnibus update to the following 47 templates so affected. The 47 templates: includes/calendar.inc includes/columns_settings.inc includes/datatables.inc includes/doc-head-close.inc includes/greybox.inc includes/opac-bottom.inc includes/password_check.inc includes/slip-print.inc modules/clubs/clubs-tab.tt modules/clubs/enroll.tt modules/opac-account.tt modules/opac-advsearch.tt modules/opac-auth-detail.tt modules/opac-auth-MARCdetail.tt modules/opac-auth.tt modules/opac-basket.tt modules/opac-course-details.tt modules/opac-course-reserves.tt modules/opac-detail.tt modules/opac-downloadshelf.tt modules/opac-full-serial-issues.tt modules/opac-idref.tt modules/opac-illrequests.tt modules/opac-imageviewer.tt modules/opac-MARCdetail.tt modules/opac-memberentry.tt modules/opac-messaging.tt modules/opac-overdrive-search.tt modules/opac-passwd.tt modules/opac-password-recovery.tt modules/opac-readingrecord.tt modules/opac-request-article.tt modules/opac-reserve.tt modules/opac-results-grouped.tt modules/opac-results.tt modules/opac-review.tt modules/opac-search-history.tt modules/opac-shareshelf.tt modules/opac-shelves.tt modules/opac-showreviews.tt modules/opac-suggestions.tt modules/opac-tags.tt modules/opac-topissues.tt modules/opac-user.tt modules/sco/help.tt modules/sco/printslip.tt modules/sco/sco-main.tt Reference: [1] https://www.w3.org/TR/2017/REC-html52-20171214/obsolete.html#warnings-for-o… -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 13580] New: item circ history has 'last seen' labeled wrong
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '26

05 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 Bug ID: 13580 Summary: item circ history has 'last seen' labeled wrong Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi =106124&itm=140197 OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: katrin.fischer(a)bsz-bw.de, sophie.meynieux(a)biblibre.com CC: katrin.fischer(a)bsz-bw.de CC: sophie.meynieux(a)biblibre.com On this page: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi=106124&itm=140197 the 'last seen' column is actually the timestamp - not the date last seen so it's confusing. The label should be changed or the value should be changed. --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- *** Bug 13581 has been marked as a duplicate of this bug. *** --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, it's not quite the timestamp either. It looks like a calculated date on when the item was 'last seen' in this library. It uses the newest date and time from issues, old_issues and branchtransfers. Maybe 'last seen at library'? --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, it's not quite the timestamp either. It looks like a calculated date on when the item was 'last seen' in this library. It uses the newest date and time from issues, old_issues and branchtransfers. Maybe 'last seen at library'? --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux(a)biblibre.com> --- The pb with this timestamp is that it is changed by anonymisation -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 37001] New: Locale ignored for serial numbering when using {MonthName} {DayName} substitutions
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37001 Bug ID: 37001 Summary: Locale ignored for serial numbering when using {MonthName} {DayName} substitutions Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Moved from bug 35646 comment 17. Tt doesn't work because we don't set Locale for the DateTime objects we create in Koha::DateUtils: https://metacpan.org/pod/DateTime#Locales We could easily pass through the 'locale' from the Serial (subscription table) however, I spot tested and got an error for 'Ethiopic'/'gez' though it is listed here: https://metacpan.org/pod/DateTime::Locale::Catalog Our list comes from here: https://www.loc.gov/standards/iso639-2/php/code_list.php Maybe our datetime modules need an update? Here is a full list of ones that throw an error: Invalid locale code or name: akk Invalid locale code or name: tut Invalid locale code or name: grc Invalid locale code or name: ave Invalid locale code or name: bnt Invalid locale code or name: bra Invalid locale code or name: cel Invalid locale code or name: chp Invalid locale code or name: cho Invalid locale code or name: chu Invalid locale code or name: syc Invalid locale code or name: cop Invalid locale code or name: cre Invalid locale code or name: prs Invalid locale code or name: dgr Invalid locale code or name: egy Invalid locale code or name: gez Invalid locale code or name: gem Invalid locale code or name: got Invalid locale code or name: gwi Invalid locale code or name: her Invalid locale code or name: hit Invalid locale code or name: inc Invalid locale code or name: iku Invalid locale code or name: ipk Invalid locale code or name: ira Invalid locale code or name: jrb Invalid locale code or name: csb Invalid locale code or name: lad Invalid locale code or name: lat Invalid locale code or name: myn Invalid locale code or name: dum Invalid locale code or name: enm Invalid locale code or name: frm Invalid locale code or name: gmh Invalid locale code or name: mga Invalid locale code or name: mul Invalid locale code or name: nah Invalid locale code or name: zxx Invalid locale code or name: nya Invalid locale code or name: arc Invalid locale code or name: ang Invalid locale code or name: fro Invalid locale code or name: goh Invalid locale code or name: peo Invalid locale code or name: pro Invalid locale code or name: ota Invalid locale code or name: pal Invalid locale code or name: pli Invalid locale code or name: pbr Invalid locale code or name: pra Invalid locale code or name: roa Invalid locale code or name: rom Invalid locale code or name: sam Invalid locale code or name: sem Invalid locale code or name: den Invalid locale code or name: sla Invalid locale code or name: wen Invalid locale code or name: sux Invalid locale code or name: syr Invalid locale code or name: tgl Invalid locale code or name: tet Invalid locale code or name: uga Invalid locale code or name: mis -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 33302] New: Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Bug ID: 33302 Summary: Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle(a)bywatersolutions.com, tomascohen(a)gmail.com A bit much to put in the description, but the problem is about item level holds failing to be placed silently in the OPAC. To test: With the sample data in ktd or sandboxes: 1) Enforce library transfer limits (UseBranchTransferLimits) on itemtypes (BranchTransferLimitsType). 2) In administration > branch transfer rules: disallow transfer from Midway to any other library for item type BK (Books) 3) Search for a record with at least one item in Midway in staff 4) Try to place an item level hold on a Midway item. I used: Intermediate Perl, biblionumber 126 For the Midway item, only Midway will show as possible pickup-location This is correct. 5) Switch to the OPAC 6) Try to place an item level hold there on the Midway item, for pick-up at Centerville. 7) Place a hold on the Midway item for pick-up at any non-Midway location 8) Verify the page saves without error, but the hold was not placed. - The basic issue here is that item specific pickup locations != record-specific pickup locations. In the staff interface we have a separate pull down "allowed pick-up locations" for each item in the list. I think we should implement the same in the OPAC to help the users see what is allowed and what not. And deacticate the pull down on top when an item is selected. But: At least we should give proper feedback that a hold could not be placed because of the pick-up location instead of failing silently! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 35617] New: Make phone number as match point in in Identity providers
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35617 Bug ID: 35617 Summary: Make phone number as match point in in Identity providers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: slavashishkin(a)gmail.com Reporter: slavashishkin(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Depends on: 31378 Currently, the system supports match points by -email, -userid, and -cardnumber. Many external authorization systems have the authentication by phone number, which is also required for libraries. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 22762] New: Collection codes not displayed on receiving
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Bug ID: 22762 Summary: Collection codes not displayed on receiving Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 27834] New: CircControl syspref is used wrong in TooMany function C4::Circulation
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27834 Bug ID: 27834 Summary: CircControl syspref is used wrong in TooMany function C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)helsinki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The CircControl syspref description says > Use the checkout and fines rules of > PickupLibrary: the library you are logged in at. > PatronLibrary: the library the patron is from. > ItemHomeLibrary: the library the item is from. This is mostly true but there is one exception in the TooMany function where it actually doesn't just change which libraries rules are used but how the the calculation is performed. With PatronLibrary set the behaviour is as expected by reading the syspref description. However with the setting PickupLibrary the behaviour changes now, instead of just using the rules of the pickup library we also only take into account the loans in the pickup library when calculating whether we are over the checkout limit or not. The same happens with ItemHomeLibrary where we instead calculate the patron's checkouts in the home library of the item being checked out. We should really try to fix this either by a) showing that ItemHomeLibrary and PickupLibrary is unacceptable and no one actually wants that, that would allow then making the behaviour similar as what it is to PatronLibrary (so just selecting the right circ rule instead of changing calculation method). b) Provide a new syspref for changing the calcutation method when PickupLibrary or ItemHomeLibrary CircControl values are used, and set it on upgrade enabled as default. Ps. svc/letters/preview might use CirControl wrongly as well, I'm not 100% I didn't quite understand but as for other usages of CircControl syspref I grepped where it was used and it correctly only changed the circ rules to be used instead of changing behaviour. So in addition to TooMany we might have to do some changes to svc/letters/preview if it turns out it changes behaviour as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 46

[Bug 37060] New: KOCT cannot send circulation data due to missing csrf token
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '26

04 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37060 Bug ID: 37060 Summary: KOCT cannot send circulation data due to missing csrf token Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: bibliothek(a)th-wildau.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Just tried using the firefox offline circulation tool (koct) and ran into these console errors: ==> /var/log/koha/kohadev/plack-intranet-error.log <== [2024/06/10 11:55:12] [WARN] Programming error - No CSRF token passed for POST http://localhost:8081/intranet/offline_circ/service.pl (referer: No referer) at /kohadevbox/koha/Koha/Middleware/CSRF.pm line 82. To reproduce: a) install firefox addon linked in http://localhost:8081/cgi-bin/koha/circ/circulation-home.pl b) in the plugin settings: server: http://localhost:8081 Login: koha Password: koha c) test login d) check logs for [WARN] Programming error - No CSRF token passed for POST http://localhost:8081/intranet/offline_circ/service.pl (referer: No referer) at /kohadevbox/koha/Koha/Middleware/CSRF.pm line 82. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 62

[Bug 22436] New: add move or copy control field from or to subfield in MARC modification templates
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '26

03 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 Bug ID: 22436 Summary: add move or copy control field from or to subfield in MARC modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- MARC modification templates does not allow to mix control field and the subfield of a regular field, we should allow that. But of course not the mix of an entire regular field and the subfield of a regular field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 38757] New: Adding order from a staged file - "Some required subfields are unset"
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '26

03 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38757 Bug ID: 38757 Summary: Adding order from a staged file - "Some required subfields are unset" Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org When ordering from a staged file that contains item data, we have the option to edit or confirm the individual items on the "Select to import" tab, or import all items with identical information from the "Item information" tab. When importing individualized item data from the "Select to import" tab, clicking Save triggers an error: "Some required subfields are unset". Setting the Koha item type in the "Item information" tab fixes this error - but it shouldn't be necessary to set the item type in that tab if all items in the "Select to import" tab already have an item type specified. To replicate: 1. Go to Acquisitions and find or open a basket 2. Click Add to basket 3. Click Add from new file 4. Upload a MARC file containing item data 5. When the upload completes, click "Add to basket" 6. In the "Select to import" tab that comes up by default, check the checkbox next to one or more titles in the file --> This will expand the item data for those titles 7. Look over the item data, and confirm that all items have a homebranch, holdingbranch, and item type defined 8. Click "Save" --> An error pops up: "Some required subfields are unset" 9. Navigate to the "Item information" tab 10. Select a value for y - Koha item type 11. Click "Save" again --> The orders are imported successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12