August 2024 - Koha-bugs - lists.koha-community.org

[Bug 36898] New: Elasticsearch indexer error log needs more information
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '24

22 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36898 Bug ID: 36898 Summary: Elasticsearch indexer error log needs more information Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au Fairly regularly I'm seeing the following message showing up in /var/log/koha/instance/es-indexer-output.log [2024/05/20 09:28:13] [WARN] Update of elastic index failed with: Exception 'Koha::Exceptions::Elasticsearch::BadResponse' thrown 'Bad response received when submitting request to Elasticsearch' with details => [https://hostname:9300]-[599] Timed out while waiting for socket to become ready for reading, type => Timeout main::catch {...} /usr/share/koha/bin/workers/es_indexer_daemon.pl (229) But this doesn't really tell me anything useful. It's not clear what records failed to update or what the job number was, so there's no way to re-try and fix the missing indexed data. Also, I've updated the request_timeout from 30 to 60, so it's a fairly long timeout. Generally speaking, there was a fair amount of indexing activity, but around 09:27:13 there wasn't. Although there was 6 jobs at 09:28:13, so maybe it's not the request_timeout that needs tweaking... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 37481] New: Some operations that do not affect data should be submitted as POST requests
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '24

22 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37481 Bug ID: 37481 Summary: Some operations that do not affect data should be submitted as POST requests Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Summarizing from bug 37197: There are limits to URL size that make POST preferable to GET in some instances. We can handle this with fake cud- operations "cud-show" or by allowing "show" and "cud-show" options to do the same things We have links that append the data - these could be made to use our new JS form submission We need to decide on a path here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 37614] New: Printing patron cards from patron lists broken by CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '24

22 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37614 Bug ID: 37614 Summary: Printing patron cards from patron lists broken by CSRF protection Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)gmail.com, oleonard(a)myacpl.org Blocks: 36192 Steps to reproduce: 1. Tools - Patrons lists, if you don't already have one then New list, name and save, Search for patrons, add at least one patron, then return to Patron lists. 2. In the Actions menu for your patron list, select Print patron cards 3. In that perfectly normal looking popup, click Export. You now have a popup with an Loading throbber, which will hang forever, and in your console you have a 403 error from trying to GET patroncards/print.pl. If you go back and inspect the page where you clicked Export, you'll find that it is a button type='submit' in a form with method='post' which makes the GET seem a bit odd. To see that it sometimes posts, 1. Tools - Patron card creator - New card batch - Add at least one patron 2. Export card batch 3. You get a popup with a lovely Windows 95 aesthetic courtesy of greybox.inc, but it is that same form method='post' with the same type='submit' Export button. Click Export and you will POST to patroncards/print.pl and things will work just fine. Not at all clear to me how opening the popup one way turns the POST to a GET, but it does. There's a FIXME in patroncards/print.pl saying that the op=cud-export looks sus, which it does. You could try to make the case that it's sensible to POST because in the case where you have selected some but not all of the patrons in a label batch, the number of label_id params in the URL could be so high that it exceeds Apache's max URL length, but then the result of the POST is a link to create the PDF that is the actual "print" export, and that link is a GET which contains all of them with an over-escaped &label_id= param for each one. So a pragmatic fix would be to just change from a POST to a GET, change cud-export to export, and not worry about why called one way it POSTs and called another way it GETs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 36801] New: Allow un-resolving of a catalog concern
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36801 Bug ID: 36801 Summary: Allow un-resolving of a catalog concern Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl We didn't allow for re-opening a resolved catalog concern before, but with the introduction of the update status's I think we managed to change the logic a bit and the 'Update' button now displays. This effectively allows for re-opening a resolved ticket; However, the actual ticket state isn't properly updated and should be so the new state is properly reflected in the display table and filtering options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 37055] New: WaitingNotifyAtCheckout should only trigger on patrons with waiting holds
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37055 Bug ID: 37055 Summary: WaitingNotifyAtCheckout should only trigger on patrons with waiting holds Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When one patron has a waiting hold, Koha pops up a modal when checking out to any patrons. To recreate: - enable WaitingNotifyAtCheckout - have or create a waiting hold for a patron - check out an item to a different patron who does not have a waiting hold - Koha says "This patron has waiting holds that are available for checkout" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32

[Bug 36276] New: Cannot edit Identity Provider after creation
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Bug ID: 36276 Summary: Cannot edit Identity Provider after creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: olivier.hubert(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Once an identity provider is created, it is no longer possible to easily edit it, as the form for editing the identity provider contains no value. Moreover, the provider's name is replace with " (quotation mark). Steps to reproduce: 1. Launch KTD or Koha instance using up-to-date master branch. 2. In the Administration menu, go to the Identity Providers page. 3. Click on the button to create a new identity provider. 4. Fill in the required fields, using test data. 5. Save the identity provider. 6. Click the "Edit" button for the newly created identity provider. 7. Notice that the form's fields are empty and the provider's name has been changed to ". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 37612] New: Batch modifying patrons from patron lists broken by CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37612 Bug ID: 37612 Summary: Batch modifying patrons from patron lists broken by CSRF protection Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 36192 Patron lists have an Actions menuitem to Batch edit patrons, which sends a GET to tools/modborrowers.pl?patron_list_id=1&op=show. But because the other two ways to modborrowers are to upload a file of borrowernumbers or to stick a possibly-huge number of borrowernumbers into a textarea, both of which require a POST, the op is now cud-show, not because it does anything CUD, but because it has to accept POSTs. It just needs the same solution as https://git.koha-community.org/Koha-community/Koha/src/commit/99c2064126978… to accept both cud-show and show. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 30470] New: Apply CheckPrevCheckout logic when placing a hold on the OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30470 Bug ID: 30470 Summary: Apply CheckPrevCheckout logic when placing a hold on the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Bug 20421 introduced CheckPrevCheckout logic when placing a hold on the staff client. It would be useful to have the same CheckPrevCheckout logic implemented for patrons when placing a hold on the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 37548] New: Race condition in CHECKIN notices
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37548 Bug ID: 37548 Summary: Race condition in CHECKIN notices Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On bug 15854 we introduced a lock on the messages table to avoid generating too many checkin digest notices. We saw on a live site a different issue recently. A patron had a checkin notice with 17 items process_message_queue ran and picked the contents of that notice for sending, but had not yet marked it sent The patron returned 10 additional items These were added to the notice in the DB process_message_queue sent the digest with the contents from the initial fetch in the while loop process message queue marked the notice as sent Result: Patron received notice of 17 items checked in DB notice had 27 and is marked sent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 34668] New: Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '24

21 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34668 Bug ID: 34668 Summary: Add syspref to popup warn librarians of waiting holds for the patrons whose items they are checking out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: shi-yao.wang(a)inLibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Add a modal popup when checking out items of a patron that has waiting holds available with a syspref to enable or disable the feature. Would make it more obvious than the simple display of "Holds waiting here" comment on top right of the checkout page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 55