September 2026 - Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #934 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205044&action=e… Bug 10190: (QA follow-up): UI/UX bug fixes - phase two Fix: handle exiting modal - prevent data reload when the user exits the modal - as preparation for the above: refactor to use one handler only Fix: new trigger saves with delay defined - Identified an old refactor omission - we were still passing 'i' despite the from now relying on this.triggerNumber Fix: return to correct trigger tab after save or reset Fix: restore delete button and bold italic info - restore display, fixes a regression introduced by the previous UI/UX patch set Fix: order dropdown options by description or name (not code) Fix: circ rule resets - restore reset funtionality (mtt was still occasionally passed as a string, and would then get compared to an array. Ensure this is not the case.) - do not trigger the data refresh if the current ruleset did not get deleted - make sure triggerNumber is defined when navigation is caused by reset - add the notice code in brackets to letter names for display (eg. Overdue notice (ODUE)) Assisted-by: Claude Opus 4.6 (Anthropic) AI used to help trace back potential bug sources and draft fixes. Changes were reviewed, tweaked, and commited manually and gradually (with a pre-submission commit squash) Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #933 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205043&action=e… Bug 10190: (QA follow-up) UI/UX improvements and fixes - Refactor (prepation): Extract form sub-components for better maintainability - Template stucture improvements (eg. consistent fieldset use) - Ensure triggerNumber is always cast to integer from query params - Add/Edit trigger form UI/UX improvements/fixes: - Restore add/edit button functionality on trigger tables in the form - Update Context section title to dynamically change depending on whether editing or displaying - Display trigger context as informational when not in confirmContext mode - Hide required labels and validation on view-only context fields - Always display trigger context at the top of the form - Add renewal/autorenewal summary (renewals allowed, automatic renewal) to circulation rules summary panel - Sort notice letter dropdowns by name rather than code - Update Circulation rules summary title to be more descriptive - Scroll behaviour improvements: - Extract scrollToElementById to store with polling and null guard - Block page scroll when modal is open - Disambiguate duplicate trigger-table element ids (trigger-table-main vs trigger-table-form) to fix unpredictable scroll-to behaviour Assisted-by: Claude Sonnet 4.6 (Anthropic) Experimenting a little here - not quite certain where we draw the line for substantial use so I thought I would add a description in case it's useful, especially since the AI code guidelines are quite fresh: AI was used primarily to help parse longer Vue templates (CirculationTriggersFormAdd.vue) and help isolate elements for extractions as well as highlight template formatting inconsistencies and propose improvements. The refactoring itself was achieved starting from AI-proposed changes which were then thoroughly re-worked manually towards the code changes submitted. I also trialled using it (currently experimenting with this) for minor coding tasks where there is a clear precedent (for example, to add renewal/autorenewal information and do so in a way that follows exactly what we had written). In those cases, each code change made by AI was the outcome of multiple iterations with direct feedback (which it did require a fair amount of) from me to ensure the output matched what I would have written myself. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #932 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205042&action=e… Bug 10190: (follow-up): feat: indicate mtt is required Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #931 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205041&action=e… Bug 10190: (follow-up): fix: handle fallbacks in edit/add Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #930 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205040&action=e… Bug 10190: (follow-up): fix: reset rule info message The information message showing in the reset modal still referred to an earlier version of the UI. Update it to correctly name the relevant filter. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #929 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205039&action=e… Bug 10190: (follow-up): fix: mtt formating: handle unset This is needed to handle creating new triggers for libraries for which all earlier triggers are defaults (do not exist in the DB , are not explicitly set) Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #928 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205038&action=e… Bug 10190: Add manage_circ_triggers permission for notice trigger access Replaces the broad manage_circ_rules permission requirement on the circulation triggers page with a new dedicated manage_circ_triggers sub-permission (under parameters, flag 3). - Add manage_circ_triggers to userpermissions.sql - Update atomicupdate to add the permission, grant it to existing edit_notice_status_triggers users, and remove the old permission - Update admin/circulation_triggers.pl to require manage_circ_triggers - Add manage_circ_triggers as an OR option on all circulation_rules API endpoints (GET/PUT /circulation_rules, /kinds, /config) - Restrict manage_circ_triggers users in the API controller to overdue_* rule names only on write Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #927 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205037&action=e… Bug 10190: (follow-up) Add missing CSP nonce to inline script tag Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #926 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205036&action=e… Bug 10190: (follow-up) mtt formatting The Transport Type options when displaying in 'edit' mode were showing as a comma separated string rather than as separate options (as they do when being set). Ammends this so that they display as separate options consistently. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '26

04 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #925 from Chloé Zermatten <chloe.zermatten(a)openfifth.co.uk> --- Created attachment 205035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205035&action=e… Bug 10190: Fix false conflict error when editing specific trigger rules When editing a specific rule (e.g. */Kids/Books) alongside an all/all/all rule, the conflict check incorrectly reported a conflict. The effective=true API response always returns context as */*/* (fallback), so ruleSetInDb.context differed from currentRuleSet.context (which was overridden to the real context). Fix by overriding ruleSetInDb.context before the hasConflict comparison, consistent with the existing pattern in setCurrentRuleSet. Signed-off-by: Michaela <michaela.sieber(a)kit.edu> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0