- Koha-bugs - lists.koha-community.org

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #54 from David Nind <david(a)davidnind.com> --- Testing notes (using koha-testing-docker): 1. Tests pass for me: prove t/db_dependent/Circulation/maxsuspensiondays.t 2. Use the same test plan as in comment#49 Maybe the code changes made need to be tidied using Perltidy? (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy and https://wiki.koha-community.org/wiki/Perltidy) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159277|0 |1 is obsolete| | --- Comment #53 from David Nind <david(a)davidnind.com> --- Created attachment 159504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159504&action=e… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34174] New: Saving RIS results to Error 505
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '23

02 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174 Bug ID: 34174 Summary: Saving RIS results to Error 505 Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: eugenegf(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org When exporting records to RIS in the OPAC as well as in the administration panel, it results to Error 505. In plack-opac-error-log, we are getting this error: [2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 166. [2023/06/30 22:30:04] [WARN] print() on closed filehandle _GEN_51 at /usr/share/koha/opac/cgi-bin/opac/opac-export.pl line 179. [2023/06/30 22:30:04] [WARN] seek() on closed filehandle _GEN_51 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. Also in plack-intranet-error-log, when trying out to export to RIS a particular record: [2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 84. [2023/06/30 22:29:21] [WARN] print() on closed filehandle _GEN_38 at /usr/share/koha/intranet/cgi-bin/catalogue/export.pl line 87. [2023/06/30 22:29:21] [WARN] seek() on closed filehandle _GEN_38 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 6819] Don't offer cancel order links for received order lines on basket summary
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34469 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6729] Block received order lines from editing
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34469 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0

[Bug 34469] New: Modifying an order line of a standing order will delete linked invoice ID
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Bug ID: 34469 Summary: Modifying an order line of a standing order will delete linked invoice ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When modifying a received order line from a standing order, the invoice id in the order line will be emptied out, leaving you with an order line that is complete, but not linked to an invoice (= inconsistent state, data loss) This cannot be resolved in the GUI, since you can't 'cancel receipt' for this order line, since it's not linked to an invoice any more. The only way to fix things is with SQL. And there is no way to find out which invoice the order line was originally received in. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 33346] New: Add Help link to Koha manual in ERM module
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346 Bug ID: 33346 Summary: Add Help link to Koha manual in ERM module Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: catrina(a)bywatersolutions.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com All other pages/modules in Koha show the Help button hyperlinked to the relevant portion of the manual. This link is missing throughout the ERM module and should be added in. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 34955] New: One Koha manual (to rule them all)
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34955 Bug ID: 34955 Summary: One Koha manual (to rule them all) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: aude.charillon(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The Documentation team, at our meeting on 27 September 2023, voted to move from one manual per Koha version to one manual for all versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 35454] New: A bad RENEWAL notice breaks the ability to renew items
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '23

01 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35454 Bug ID: 35454 Summary: A bad RENEWAL notice breaks the ability to renew items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: 1. Have an errouneous template in your RENEWAL notice. For example this template is missing an [% END %]: [% UNLESS borrower.branchcode == "ABC" %] The following items have been renewed: ---- <<biblio.title>> ---- 2. Have RenewalSendNotice set to 'Send' 3. Make sure a patron has the 'Item checkout' messaging pref set. 4. Checkout some items to that patron and try to renew them. 5. Nothing happens. 6. Fix the notice by adding the missing [% END %] 7. Now you can successfully renew. Bad templates should not complete break the ability to renew items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2