May 2019 - Koha-bugs - lists.koha-community.org

[Bug 22489] New: Onboarding tool fails due to inserting maxissueqty into IssuingRule
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '19

12 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Bug ID: 22489 Summary: Onboarding tool fails due to inserting maxissueqty into IssuingRule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: hayleymapley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- When going through the onboarding process, the tool fails on submit of Step 5 - creating an issuing rule. This is due to the maxissueqty column having been removed from the IssuingRules table and added to the CirculationRules table but redundant code still exists in onboarding.pl. As you can see below the maxissueqty variable is being added to the params hash which is used to make the new issuing rule. if ( $step == 5 ) { if ( $op eq 'add_validate_circ_rule' ) { #If no libraries exist then set the $branch value to * my $branch = $input->param('branch') || '*'; my $type = $input->param('type'); my $branchcode = $input->param('branch'); my $categorycode = $input->param('categorycode'); my $itemtype = $input->param('itemtype'); my $maxissueqty = $input->param('maxissueqty'); my $issuelength = $input->param('issuelength'); my $lengthunit = $input->param('lengthunit'); my $renewalsallowed = $input->param('renewalsallowed'); my $renewalperiod = $input->param('renewalperiod'); my $onshelfholds = $input->param('onshelfholds') || 0; $maxissueqty =~ s/\s//g; $maxissueqty = undef if $maxissueqty !~ /^\d+/; $issuelength = $issuelength eq q{} ? undef : $issuelength; my $params = { branchcode => $branchcode, categorycode => $categorycode, itemtype => $itemtype, maxissueqty => $maxissueqty, renewalsallowed => $renewalsallowed, renewalperiod => $renewalperiod, issuelength => $issuelength, lengthunit => $lengthunit, onshelfholds => $onshelfholds, }; my $issuingrule = Koha::IssuingRule->new($params); eval { $issuingrule->store; }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 22954] New: Minor markup error in OPAC messaging template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22954 Bug ID: 22954 Summary: Minor markup error in OPAC messaging template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There is a minor markup error in the OPAC's "your messaging" template (opac-messaging.tt). This triggers an error in the HTML validator: - "Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag." -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 22952] New: Markup error in OPAC suggestions template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Bug ID: 22952 Summary: Markup error in OPAC suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Target Milestone: --- There is a markup error in the OPAC suggestions template (opac-suggestions.tt) which is causing a validation errors: - "End tag div seen, but there were open elements." - "Unclosed element span." -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 22948] New: Markup error in OPAC bibliographic detail template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Bug ID: 22948 Summary: Markup error in OPAC bibliographic detail template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- There are quite a few validation errors coming from the OPAC detail template (opac-detail.tt), but I would like to address one with this patch: - "The aria-labelledby attribute must point to an element in the same document." -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 22099] New: "List requests" button displays when listing requests
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Bug ID: 22099 Summary: "List requests" button displays when listing requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Target Milestone: --- On the main ILL Requests page that lists all requests ("illlist" action), the "List request" button is displayed, which makes no sense since we're already listing requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 22955] New: Markup error in OPAC lists template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Bug ID: 22955 Summary: Markup error in OPAC lists template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Target Milestone: --- There is a minor markup error in the OPAC lists template: A missing "alt" attribute. It triggers this error: - "An img element must have an alt attribute, except under certain conditions." -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 22947] New: Markup error in OPAC preferences file
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Bug ID: 22947 Summary: Markup error in OPAC preferences file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Target Milestone: --- opac.pref contains a markup error which can cause errors in the display. On line 124: <code>OpenURLText<code> Should be: <code>OpenURLText</code> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 22950] New: Markup error in OPAC recent comment template
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Bug ID: 22950 Summary: Markup error in OPAC recent comment template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Target Milestone: --- There some invalid inline CSS in opac-showreviews.tt which causes validation errors: - "CSS: font-color: Property font-color doesn't exist." -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 23027] New: Suggestions.t is failing if no biblio in DB
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23027 Bug ID: 23027 Summary: Suggestions.t is failing if no biblio in DB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 20830] New: Make sure a fund is selected when ordering from staged file
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '19

11 Jun '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Bug ID: 20830 Summary: Make sure a fund is selected when ordering from staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When selecting orders from a staged file, we should check that a fund is set. - We only want to check entries that have been selected for order (checkbox) - We only want to complain, when the fund entry on the selected entry is empty and there is also no default fund set on the accounting details tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26