- Koha-bugs - lists.koha-community.org

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 206838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206838&action=e… Bug 12146: Automated Schema Update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 206837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206837&action=e… Bug 12146: Resize currency.isocode to CHAR(3) ISO 4217 alpha currency codes are always exactly three letters, but currency.isocode was a free-text varchar(5) with no format enforcement on the admin Currencies form (just maxlength="5", matching the column). That mismatch meant code relying on isocode being a valid ISO 4217 code (e.g. SIP2's fixed-width BH currency field) couldn't trust it. Resize the column to CHAR(3), normalizing existing data first: uppercase any value that already fits, and clear anything that doesn't so the resize can't silently truncate bad data. Shrink the admin form's ISO code field to match (maxlength="3"). Also fixes two Currencies.t test fixtures ('isoc1'/'isoc2') that no longer fit the new column width. Test plan: 1) prove t/db_dependent/Koha/Acquisition/Currencies.t 2) perl installer/data/mysql/updatedatabase.pl 3) Go to Administration > Currencies, edit a currency, confirm the ISO code field only accepts 3 characters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43291] New: SIP2 responses hardcode currency to USD regardless of library configuration
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43291 Bug ID: 43291 Summary: SIP2 responses hardcode currency to USD regardless of library configuration Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- C4::SIP::ILS::Transaction's sip_currency field (used for FID_CURRENCY in patron status and fee-related SIP2 responses) is hardcoded to 'USD' with a "FIXME: why hardcoded?" comment, regardless of the library's actual currency. Any library using a self-check/SIP2 integration outside the US gets an incorrect currency code in every fee-related SIP2 response. This patch uses Koha::Acquisition::Currencies->get_active's isocode when one is configured, falling back to 'USD' (the previous, and still sensible default, behaviour) when no active currency exists. Every C4::SIP::ILS::Transaction subclass calls SUPER::new() first and none of them override sip_currency in their own %fields, so this applies uniformly across checkout, checkin, renew, hold, and fee payment SIP responses. Test plan: 1. prove t/db_dependent/SIP/Transaction.t 2. With no active currency configured, confirm a SIP2 patron status response still reports USD (AY field / currency) 3. Mark a currency (e.g. GBP) as active in Administration > Currencies 4. Repeat step 2 and confirm the response now reports GBP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43291 [Bug 43291] SIP2 responses hardcode currency to USD regardless of library configuration -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|indradg(a)l2c2.co.in |martin.renvoize(a)openfifth.c | |o.uk --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Reviving this with a wider scope, prompted by review feedback on bug 43291 (SIP2 currency code): currency.isocode being a free-text varchar(5) with no format enforcement meant it couldn't be trusted to hold a valid ISO 4217 code. New patch series: 1) Resize currency.isocode to CHAR(3), matching the ISO 4217 alpha code format, normalizing any existing bad data first. 2) Automated schema update. 3) Populate the "Some basic currencies" sample dataset with the full set of active ISO 4217 currency codes (in addition to the original ask of just adding isocode to the existing curated entries). Bug 43291 will depend on this one and drop its own defensive isocode validation once this lands, since the schema itself now guarantees the format. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 206835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206835&action=e… Bug 12146: Add full ISO 4217 currency list to sample currency data The "Some basic currencies" optional sample dataset (installer/data/mysql/en/optional/parameters.yml) only offered four currencies (USD, GBP, CAD, EUR) and never populated currency.isocode, so every sample currency's ISO code was blank after install. Keep the existing curated set as-is (USD active by default, GBP/CAD/ EUR with their existing rates and symbols) and add the remaining active ISO 4217 currency codes as inactive options, each with isocode set to its own code. Precious-metal and special codes (XAU, XAG, XPD, XPT, XTS, XXX, XDR, XBA-XBD, XSU, XUA) are excluded as they don't represent real acquisitions currencies. rate is set to a neutral 1.0 placeholder for the generated entries, since a static sample file can't hold meaningful live exchange rates for 150+ currencies. Relies on the earlier commit in this series resizing currency.isocode to CHAR(3), so every isocode value here is guaranteed to fit. Test plan: 1) Run a fresh web installer, select "Some basic currencies..." under Optional data at the Default Settings step 2) Go to Administration > Currencies & Exchange rates 3) Confirm ~154 currencies are listed, each with a 3-letter ISO code, and only USD is active -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 206834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206834&action=e… Bug 12146: Automated Schema Update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12146] Add new ISO code column to currency sample files
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '26

25 Sep '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 206833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206833&action=e… Bug 12146: Resize currency.isocode to CHAR(3) ISO 4217 alpha currency codes are always exactly three letters, but currency.isocode was a free-text varchar(5) with no format enforcement on the admin Currencies form (just maxlength="5", matching the column). That mismatch meant code relying on isocode being a valid ISO 4217 code (e.g. SIP2's fixed-width BH currency field) couldn't trust it. Resize the column to CHAR(3), normalizing existing data first: uppercase any value that already fits, and clear anything that doesn't so the resize can't silently truncate bad data. Shrink the admin form's ISO code field to match (maxlength="3"). Also fixes two Currencies.t test fixtures ('isoc1'/'isoc2') that no longer fit the new column width. Test plan: 1) prove t/db_dependent/Koha/Acquisition/Currencies.t 2) perl installer/data/mysql/updatedatabase.pl 3) Go to Administration > Currencies, edit a currency, confirm the ISO code field only accepts 3 characters -- You are receiving this mail because: You are watching all bug changes.

1 0