March 2002 - Koha-devel - lists.koha-community.org

Bibliosubtitle table
by Chris Cormack 27 Mar '02

27 Mar '02

Hi all Im seriously considering combining the bibliosubtitle table with the biblio table. It seems like an unnessecary join to me, and is really slowing author searches down. Can anyone think of why this might be a bad idea. Im going to try it out on our test database. Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

1 1

1.1.2 Release
by Chris Cormack 27 Mar '02

27 Mar '02

Hi all Im beginning to think that 1.1.1 is so out of date, that we should release a 1.1.2 which tidies up at least all the missing files in 1.1.1 and the bugs. Perhaps leave the marc stuff out? What do ppl think? Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris(a)katipo.co.nz www.katipo.co.nz

2 2

CVS: koha pay.pl,1.2,1.3
by Chris Cormack 26 Mar '02

26 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv8133 Modified Files: pay.pl Log Message: Shifting writeoff code back into pay.pl (redirecting to writeoff.pl was breaking when the borrower owes a lot of fines) Index: pay.pl =================================================================== RCS file: /cvsroot/koha/koha/pay.pl,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -r1.2 -r1.3 *** pay.pl 2 Apr 2001 22:51:26 -0000 1.2 --- pay.pl 27 Mar 2002 00:02:40 -0000 1.3 *************** *** 9,15 **** use C4::Search; use C4::Accounts2; - my $input=new CGI; my $bornum=$input->param('bornum'); if ($bornum eq ''){ --- 9,18 ---- use C4::Search; use C4::Accounts2; + use C4::Database; + use C4::Stats; + my $input=new CGI; + #print $input->header; my $bornum=$input->param('bornum'); if ($bornum eq ''){ *************** *** 53,140 **** my $total=$input->param('total'); if ($check ==0){ if ($total ne ''){ recordpayment(\%env,$bornum,$total); } ! my ($numaccts,$accts,$total)=getboracctrecord('',\%bor); ! print $input->header; ! print startpage(); ! print startmenu('member'); ! print <<printend ! <FONT SIZE=6><em>Pay Fines for $data->{'firstname'} $data->{'surname'}</em></FONT><P> ! <center> ! <p> ! <TABLE CELLSPACING=0 CELLPADDING=5 border=1 > ! <TR VALIGN=TOP> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>FINES & CHARGES</TD> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>AMOUNT OWING</TD> ! </TR> ! <form action=/cgi-bin/koha/pay.pl method=post> ! <input type=hidden name=bornum value=$bornum> printend ; ! for (my $i=0;$i<$numaccts;$i++){ ! if ($accts->[$i]{'amountoutstanding'} > 0){ ! $accts->[$i]{'amount'}+=0.00; ! $accts->[$i]{'amountoutstanding'}+=0.00; ! print <<printend ! <tr VALIGN=TOP > ! <TD><input type=radio name=payfine$i value=no checked>Unpaid ! <input type=radio name=payfine$i value=yes>Pay ! <input type=radio name=payfine$i value=wo>Writeoff ! <input type=hidden name=itemnumber$i value=$accts->[$i]{'itemnumber'}> ! <input type=hidden name=accounttype$i value=$accts->[$i]{'accounttype'}> ! <input type=hidden name=amount$i value=$accts->[$i]{'amount'}> ! <input type=hidden name=out$i value=$accts->[$i]{'amountoutstanding'}> ! <input type=hidden name=bornum$i value=$bornum> ! <input type=hidden name=accountno$i value=$accts->[$i]{'accountno'}> ! </td> ! <TD>$accts->[$i]{'description'} $accts->[$i]{'title'}</td> ! <TD>$accts->[$i]{'accounttype'}</td> ! <td>$accts->[$i]{'amount'}</td> ! <TD>$accts->[$i]{'amountoutstanding'}</td> ! </tr> printend ; ! } ! } ! print <<printend ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=2><b>Total Due</b></td> ! ! <TD><b>$total</b></td> ! ! </tr> ! ! ! ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=3><b>AMOUNT PAID</b></td> ! <TD><input type=text name=total value="" SIZE=7></td> ! </tr> ! <tr VALIGN=TOP > ! <TD colspan=5 align=right> ! <INPUT TYPE="image" name="submit" VALUE="pay" height=42 WIDTH=187 BORDER=0 src="/images/pay-fines.gif"></td> ! </tr> ! </form> ! </table> ! ! ! ! ! ! ! <br clear=all> ! <p>   </p> printend ; ! print endmenu('member'); ! print endpage(); } else { ! my $quety=$input->query_string; ! print $input->redirect("/cgi-bin/koha/sec/writeoff.pl?$quety"); } --- 56,189 ---- my $total=$input->param('total'); if ($check ==0){ + print $input->header; if ($total ne ''){ recordpayment(\%env,$bornum,$total); } ! my ($numaccts,$accts,$total)=getboracctrecord('',\%bor); ! ! print startpage(); ! print startmenu('member'); ! print <<printend ! <FONT SIZE=6><em>Pay Fines for $data->{'firstname'} $data->{'surname'}</em></FONT><P> ! <center> ! <p> ! <TABLE CELLSPACING=0 CELLPADDING=5 border=1 > ! <TR VALIGN=TOP> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>FINES & CHARGES</TD> ! <td bgcolor="99cc33" background="/images/background-mem.gif" colspan=4><B>AMOUNT OWING</TD> ! </TR> ! <form action=/cgi-bin/koha/pay.pl method=post> ! <input type=hidden name=bornum value=$bornum> printend ; ! for (my $i=0;$i<$numaccts;$i++){ ! if ($accts->[$i]{'amountoutstanding'} > 0){ ! $accts->[$i]{'amount'}+=0.00; ! $accts->[$i]{'amountoutstanding'}+=0.00; ! print <<printend ! <tr VALIGN=TOP > ! <TD><input type=radio name=payfine$i value=no checked>Unpaid ! <input type=radio name=payfine$i value=yes>Pay ! <input type=radio name=payfine$i value=wo>Writeoff ! <input type=hidden name=itemnumber$i value=$accts->[$i]{'itemnumber'}> ! <input type=hidden name=accounttype$i value=$accts->[$i]{'accounttype'}> ! <input type=hidden name=amount$i value=$accts->[$i]{'amount'}> ! <input type=hidden name=out$i value=$accts->[$i]{'amountoutstanding'}> ! <input type=hidden name=bornum$i value=$bornum> ! <input type=hidden name=accountno$i value=$accts->[$i]{'accountno'}> ! </td> ! <TD>$accts->[$i]{'description'} $accts->[$i]{'title'}</td> ! <TD>$accts->[$i]{'accounttype'}</td> ! <td>$accts->[$i]{'amount'}</td> ! <TD>$accts->[$i]{'amountoutstanding'}</td> ! </tr> printend ; ! } ! } ! print <<printend ! <tr VALIGN=TOP > ! <TD></td> ! <TD colspan=2><b>Total Due</b></td> ! <TD><b>$total</b></td> ! </tr> ! <tr VALIGN=TOP > ! <TD colspan=5 align=right> ! <INPUT TYPE="image" name="submit" VALUE="pay" height=42 WIDTH=187 BORDER=0 src="/images/pay-fines.gif"></td> ! </tr> ! </form> ! </table> ! <br clear=all> ! <p>   </p> printend ; ! print endmenu('member'); ! print endpage(); } else { ! # my $quety=$input->query_string; ! # print $input->redirect("/cgi-bin/koha/sec/writeoff.pl?$quety"); ! my%inp; ! my @name=$input->param; ! for (my $i=0;$i<@name;$i++){ ! my $test=$input->param($name[$i]); ! if ($test eq 'wo'){ ! my $temp=$name[$i]; ! $temp=~ s/payfine//; ! $inp{$name[$i]}=$temp; ! } ! } ! my $bornum; ! while ( my ($key, $value) = each %inp){ ! # print $key,$value; ! my $accounttype=$input->param("accounttype$value"); ! $bornum=$input->param("bornum$value"); ! my $itemno=$input->param("itemnumber$value"); ! my $amount=$input->param("amount$value"); ! if ($accounttype eq 'Res'){ ! my $accountno=$input->param("accountno$value"); ! writeoff($bornum,$accountno,$itemno,$accounttype,$amount); ! } else { ! writeoff($bornum,'',$itemno,$accounttype,$amount); ! } ! } ! $bornum=$input->param('bornum'); ! print $input->redirect("/cgi-bin/koha/pay.pl?bornum=$bornum"); ! } ! ! ! sub writeoff{ ! my ($bornum,$accountnum,$itemnum,$accounttype,$amount)=@_; ! my $user=$input->remote_user; ! $user=~ s/Levin/C/; ! $user=~ s/Foxton/F/; ! $user=~ s/Shannon/S/; ! my $dbh=C4Connect; ! my $env; ! my $query="Update accountlines set amountoutstanding=0 where "; ! if ($accounttype eq 'Res'){ ! $query.="accounttype='Res' and accountno='$accountnum' and borrowernumber='$bornum'"; ! } else { ! $query.="accounttype='$accounttype' and itemnumber='$itemnum' and borrowernumber='$bornum'"; ! } ! my $sth=$dbh->prepare($query); ! # print $query; ! $sth->execute; ! $sth->finish; ! $query="select max(accountno) from accountlines"; ! $sth=$dbh->prepare($query); ! $sth->execute; ! my $account=$sth->fetchrow_hashref; ! $sth->finish; ! $account->{'max(accountno)'}++; ! $query="insert into accountlines (borrowernumber,accountno,itemnumber,date,amount,description,accounttype) ! values ('$bornum','$account->{'max(accountno)'}','$itemnum',now(),'$amount','Writeoff','W')"; ! $sth=$dbh->prepare($query); ! $sth->execute; ! $sth->finish; ! # print $query; ! $dbh->disconnect; ! UpdateStats($env,$user,'writeoff',$amount,'','','',$bornum); }

1 0

CVS: koha/updater updatedatabase,1.3,1.4
by Finlay Thompson 25 Mar '02

25 Mar '02

Update of /cvsroot/koha/koha/updater In directory usw-pr-cvs1:/tmp/cvs-serv25940/updater Modified Files: updatedatabase Log Message: added database patchs to the updater/updatedatabase script changes the type of the datesent and datearrived fields in the branchtransfers table from date to datetime. completely re-organises the branchcategories table. As this has previously been unused it shouldnt effect anyone. Index: updatedatabase =================================================================== RCS file: /cvsroot/koha/koha/updater/updatedatabase,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -r1.3 -r1.4 *** updatedatabase 19 Nov 2001 23:28:59 -0000 1.3 --- updatedatabase 26 Mar 2002 05:08:52 -0000 1.4 *************** *** 105,108 **** --- 105,157 ---- } + # extending the timestamp in branchtransfers... + my %branchtransfers; + + my $sth=$dbh->prepare("show columns from branchtransfers"); + $sth->execute; + while (my ($column, $type, $null, $key, $default, $extra) = $sth->fetchrow) { + $branchtransfers{$column}=$type; + } + + unless ($branchtransfers{'datesent'} eq 'datetime') { + print "Setting type of datesent in branchtransfers to datetime.\n"; + my $sti=$dbh->prepare("alter table branchtransfers change datesent datesent datetime"); + $sti->execute; + } + + unless ($branchtransfers{'datearrived'} eq 'datetime') { + print "Setting type of datearrived in branchtransfers to datetime.\n"; + my $sti=$dbh->prepare("alter table branchtransfers change datearrived datearrived datetime"); + $sti->execute; + } + + # changing the branchcategories table around... + my %branchcategories; + + my $sth=$dbh->prepare("show columns from branchcategories"); + $sth->execute; + while (my ($column, $type, $null, $key, $default, $extra) = $sth->fetchrow) { + $branchcategories{$column}=$type; + } + + unless ($branchcategories{'categorycode'} eq 'varchar(4)') { + print "Setting type of categorycode in branchcategories to varchar(4),\n and making the primary key.\n"; + my $sti=$dbh->prepare("alter table branchcategories change categorycode categorycode varchar(4) not null"); + $sti->execute; + $sti=$dbh->prepare("alter table branchcategories add primary key (categorycode)"); + $sti->execute; + } + + unless ($branchcategories{'branchcode'} eq 'varchar(4)') { + print "Setting type of branchcode in branchcategories to varchar(4).\n"; + my $sti=$dbh->prepare("alter table branchcategories change branchcode branchcode varchar(4)"); + $sti->execute; + } + + unless ($branchcategories{'codedescription'} eq 'text') { + print "Replacing branchholding in branchcategories with codedescription text.\n"; + my $sti=$dbh->prepare("alter table branchcategories change branchholding codedescription text"); + $sti->execute; + } $sth->finish;

1 0

New YAZ
by Nicholas Rosasco 25 Mar '02

25 Mar '02

New version of YAZ up at freshmeat.net http://software.freshmeat.net/projects/yaz/?topic_id=66,45,150,894 FYI -- I'll be pestering some of you for fill in information sooner or later for the new install (as my tinker-with-it linux box is in pieces and currently makes an excellent paperweight collection) -- nothing major. Nick

1 0

The Ghost Library (Field derived idea)
by finlay＠wilbur.katipo.co.nz 21 Mar '02

21 Mar '02

Hi Nick, I am working at the moment on a new improoved branch/circulations module. As a part of this work I will be introducing a "branchcode" field to the branches table, which will allow us to have hidden branches. So work in the direction you have suggested is already in the pipeline! Finlay Katipo Programmer

2 1

The Ghost Library (Field derived idea)
by Nicholas Rosasco 21 Mar '02

21 Mar '02

While getting my usual pulp murder mystery fix at my local library, I went hunting for a particular author... and discovered (after a confused moment with the brochure listing the branches in their system) that I was attempting to local a as-yet-nonexistant library. Specifically, a branch that did not exist in physical form, but rather in a warehouse while they waited for a building to be built -- and whose collections were listed even tho' unavailable. I can see other uses for the ability to create 'phantom branches' -- branches that do not ever show to patrons at all. After a brief discussion with the information desk, I found out that their existing app (I assume it is commercial, or commercially based -- it says DRA Web with a copyright notice) apparently can't suppress this phantom from patron viewing. You can, in fact, attempt this yourself http://206.15.40.1:8032/MARION is the library catalog, search for author "Roberts John Maddox" and try almost any of the "additional holdings" list -- anything you see that says Crofton isn't accessible even to the staff, being locked up somewhere. Nick

1 0

CVS: koha-html/opac-html index.html,1.1.1.1,1.2
by Chris Cormack 21 Mar '02

21 Mar '02

Update of /cvsroot/koha/koha-html/opac-html In directory usw-pr-cvs1:/tmp/cvs-serv5731 Modified Files: index.html Log Message: Syncing with tarball version Index: index.html =================================================================== RCS file: /cvsroot/koha/koha-html/opac-html/index.html,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 *** index.html 4 Feb 2001 20:52:50 -0000 1.1.1.1 --- index.html 21 Mar 2002 21:29:18 -0000 1.2 *************** *** 2,5 **** --- 2,7 ----   +  + <HTML> *************** *** 64,72 **** <tr valign=top > <td>    </td> ! <FORM ACTION="/cgi-bin/koha/opac-search.pl" name=catsearch> ! <td background=" " > ! <font size"+1" face="arial,helvetica" > ! <input type=text size="32" name="keyword"><br> </font> <b>Type in the box and press the enter key.</b><br> --- 66,74 ---- <tr valign=top > <td>    </td> ! <FORM ACTION="/cgi-bin/koha/search.pl" name=catsearch> ! <input type=hidden name=type value=opac> <td background=" " > ! ! <input type=text size="27" name="keyword"><br> </font> <b>Type in the box and press the enter key.</b><br>

1 0

CVS: koha showbudget.pl,1.1.1.1,1.2
by Chris Cormack 21 Mar '02

21 Mar '02

Update of /cvsroot/koha/koha In directory usw-pr-cvs1:/tmp/cvs-serv4530 Modified Files: showbudget.pl Log Message: Doesnt write to an include anymore Index: showbudget.pl =================================================================== RCS file: /cvsroot/koha/koha/showbudget.pl,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 *** showbudget.pl 19 Dec 2000 23:45:53 -0000 1.1.1.1 --- showbudget.pl 21 Mar 2002 21:24:54 -0000 1.2 *************** *** 11,16 **** my ($count,@results)=bookfunds; ! open (FILE,'>/usr/local/www/hdl/htdocs/includes/budgets.inc') || die "Cant open file"; ! print FILE <<printend <TABLE width="40%" cellspacing=0 cellpadding=5 border=1 > --- 11,16 ---- my ($count,@results)=bookfunds; ! ! print <<printend <TABLE width="40%" cellspacing=0 cellpadding=5 border=1 > *************** *** 33,37 **** my ($spent,$comtd)=bookfundbreakdown($results[$i]->{'bookfundid'}); my $avail=$results[$i]->{'budgetamount'}-($spent+$comtd); ! print FILE <<EOP <tr><td> $results[$i]->{'bookfundname'} </TD> --- 33,37 ---- my ($spent,$comtd)=bookfundbreakdown($results[$i]->{'bookfundid'}); my $avail=$results[$i]->{'budgetamount'}-($spent+$comtd); ! print <<EOP <tr><td> $results[$i]->{'bookfundname'} </TD> *************** *** 39,48 **** EOP ; ! printf FILE ("%.2f", $spent); ! print FILE "</TD><TD>"; ! printf FILE ("%.2f",$comtd); ! print FILE "</TD><TD>"; ! printf FILE ("%.2f",$avail); ! print FILE "</TD></TR>"; $total+=$results[$i]->{'budgetamount'}; $totspent+=$spent; --- 39,48 ---- EOP ; ! printf ("%.2f", $spent); ! print "</TD><TD>"; ! printf ("%.2f",$comtd); ! print "</TD><TD>"; ! printf ("%.2f",$avail); ! print "</TD></TR>"; $total+=$results[$i]->{'budgetamount'}; $totspent+=$spent; *************** *** 51,55 **** } ! print FILE <<printend <tr><td colspan=5> <hr size=1 noshade></TD></TR> --- 51,55 ---- } ! print <<printend <tr><td colspan=5> <hr size=1 noshade></TD></TR> *************** *** 59,69 **** printend ; ! printf FILE ("%.2f",$totspent); ! print FILE "</TD><TD>"; ! printf FILE ("%.2f",$totcomtd); ! print FILE "</TD><TD>"; ! printf FILE ("%.2f",$totavail); ! print FILE "</TD></TR>"; ! print FILE <<printend </table><br> Use your reload button [ctrl + r] to get the most recent figures. --- 59,69 ---- printend ; ! printf ("%.2f",$totspent); ! print "</TD><TD>"; ! printf ("%.2f",$totcomtd); ! print "</TD><TD>"; ! printf ("%.2f",$totavail); ! print "</TD></TR>"; ! print <<printend </table><br> Use your reload button [ctrl + r] to get the most recent figures. *************** *** 77,79 **** ; ! close FILE; --- 77,79 ---- ; ! #close ;

1 0

CVS: koha-html/intranet-html/reports index.html,1.1.1.1,1.2 dailyreport.html,1.1.1.1,NONE
by Chris Cormack 20 Mar '02

20 Mar '02

Update of /cvsroot/koha/koha-html/intranet-html/reports In directory usw-pr-cvs1:/tmp/cvs-serv19257/reports Modified Files: index.html Removed Files: dailyreport.html Log Message: Fixing broken include calls Index: index.html =================================================================== RCS file: /cvsroot/koha/koha-html/intranet-html/reports/index.html,v retrieving revision 1.1.1.1 retrieving revision 1.2 diff -C2 -r1.1.1.1 -r1.2 *** index.html 4 Feb 2001 20:52:50 -0000 1.1.1.1 --- index.html 20 Mar 2002 10:10:34 -0000 1.2 *************** *** 27,31 **** !  --- dailyreport.html DELETED ---

1 0