January 2020 - Koha-devel - lists.koha-community.org

String Freeze Notice
by Joy Nelson 12 Aug '22

12 Aug '22

Greetings! Just a quick note that string freeze will go into effect at the end of day 12/16/2019 for the maintenance branches. Maintenance releases scheduled for the 23rd. Translations can begin on the 17th. Thanks! -- Joy Nelson President, Koha Division ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>

3 3

update MARC::Transform in debian.koha-community.org
by Stéphane Delaune 08 Jun '20

08 Jun '20

Hello, I'm Stéphane Delaune (aka reiveune) from BibLibre I am the developer of the Perl module MARC::Transform ( https://metacpan.org/pod/MARC::Transform ), this module is in version 0.003008 since april but, in debian.koha-community.org, the version is only 0.003006 that is 5 years old (2 versions late, including a bugfix) I would like to know if someone is able to update this package in debian.koha-community.org (and in https://packages.qa.debian.org/libm/libmarc-transform-perl.html on which the version is 0.003007) thank you in advance Stéphane Delaune

3 4

Build the easy way throws error
by M.Wahls 09 Apr '20

09 Apr '20

hi folks, I'm new to: koha, this community and the debian-build process I'm familiar with: linux (archlinux), software development I'm struggling while building the koha package. And get the following errors (here are the last few lines the build-script throws): make[1]: Leaving directory '/tmp/buildd/koha-19.05.09+20200110003754.96ab4982' fakeroot debian/rules binary dh binary --fail-missing --with bash-completion dh_testroot -O--fail-missing dh_prep -O--fail-missing dh_installdirs -O--fail-missing /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 1: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: etc/koha/sites: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 2: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/cache/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 3: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/lib/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 4: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/log/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 5: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/lock/koha: not found /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: 6: /tmp/buildd/koha-19.05.09+20200110003754.96ab4982/debian/koha-common.dirs: var/spool/koha: not found dh_installdirs: problem reading debian/koha-common.dirs: debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 127 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 E: Failed autobuilding of package I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem I: cleaning the build env I: removing directory /var/cache/pbuilder/build//1505 and its subdirectories Don't know if it's problematic but following the build output there are a lot fail-missings: dh_auto_build dh_auto_clean dh_auto_configure dh_auto_test dh_binary dh_build dh_clean dh_installdirs dh_prep dh_testdir dh_testroot dh_update_autotools_config changing the compatability-level of pbuilder wasn't helpful. My VirtualBox looks like this: 4GB Ram, variable filesystem size (max 32GB). Debian 8 (Jessie) is used (but Stretch has the exact same issues). Used the default installation from Debian, but XFCE as desktop environment. These packages where installed by myself: git, libmodern-perl-perl, pbuilder, dh-make, gnupg2, devscripts, dput, build-essential, module-assistant As root: m-a prepare; mount /usr/lib/virtualbox/additions/VBoxGuestAdditions.iso sh /media/cdrom/VBoxLinuxAdditions.run adduser marco vboxsfsu mounting host partition under /media/sf_Share as root: pbuilder create --distribution jessie ...and as root (like in the tutorial for building packages the easy way): pbuilder --login --save-after-login echo "deb http://debian.koha-community.org/koha stable main" > /etc/apt/sources.list.d/koha.list apt-get install wget gnupg2 wget -O- http://debian.koha-community.org/koha/gpg.asc | apt-key add - apt-get update exit checkout koha: cd /media/sf_Share (mounted host-partition) git clone git://git.koha-community.org/koha.git git checkout -b 19.05.x origin/19.05.x cd /media/sf_Share cp -rf koha koha-build cd /media/sf_Share/koha-build as root: /media/sf_Share/koha-build/debian/build-git-snapshot -v 19.05.09 -d Thats all i did. What am i doing wrong? Any ideas or more information needed? Best wishes Marco

4 7

Give a try to RabbitMQ (background jobs rewrite) - POC!
by Jonathan Druart 26 Feb '20

26 Feb '20

Hi devs, I have submited a proof of concept (POC) on bug 22417 (Delegate background jobs execution). The idea would be to isolate our background jobs code (the one in the .pl) into module then use RabbitMQ to process them. More stuffs on the bug! https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Cheers, Jonathan

4 4

Coding guidelines
by Marcel de Rooy 17 Feb '20

17 Feb '20

Referring to the dev meeting and bug 22407, I propose the following rewording: PERL15 Using Koha::Object[s] PERL15(a) Code added to the Koha:: namespace should be object-oriented unless there is a very good reason to do otherwise. In that case the reason should be documented clearly. PERL15(b) Code in Koha::Object[s] should normally not refer back to C4. Obviously, this cannot be enforced harshly until the refactoring has been completed. PERL15(c) Use DBIC relations to (pre)fetch a related Koha object rather than searching it explicitly. (See bug 22407) PERL28 Other object oriented code guidelines (in addition to PERL15) I think we need to move the Accessor and idiom for -> new rules from PERL15 to another rule. I opened rule 28 for that depending on discussing the following: Class::Accessor is a great way to provide access to member variables. => My suggestion would be to remove this rule. It is true but we do not say that it is the only way to do it. (We are not even using Class::Accessor in Koha objects.) Or just say PERL28(a) To provide access to member variables, there are several ways including but not limited to using Class::Accessor. A useful idiom for the ->new() routine in object-oriented classes that do not need to process the arguments passed in as a hashref but merely need to save them for future processing => This suggestion is fine. It says use a parameter hash for sub new. We normally do that. Reworded: PERL 28(b) Use a hashref as second parameter in sub new when passing arguments. Any feedback? Marcel Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl Nu te zien: Operatie Nachtwacht Verwacht: Caravaggio-Bernini. Barok in Rome Dankzij Waller 2010-2020 T/m 18 jaar gratis Please think before you print

3 2

Elasticsearch recent works at BibLibre
by Claire Hernandez 31 Jan '20

31 Jan '20

Hi, This week, some devs work together to move forward concretely on Elasticsearch issues encountered. You will find below a focus on some points (some are at poc state today) written by Alex and Jajm from BibLibre. We would be glad to discuss these topics at hackfest in march and having user feedbacks too :) #1 Proof of concept for language analyzers bug 21357 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357#c32 It's an attempt at having a default ES configuration with stemming, elision, etc. that works with multi-languages catalogs You can read the comments and patch for more information. #2 Compatibilites for tomorrow Compatibility with latest version of Search::Elasticsearch - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552 Compatibility with Elasticsearch 7.x : Problem: Search::Elasticsearch is not yet compatible with ES 7.x, so we are stuck with ES 6.x (unless we use something else...) #3 Querying Elasticsearch in a better way POC query_string => boolean query https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 This POC is about replacing the use of full text queries (query_string) with Boolean queries for biblio search Advantage: => No search craches with special character ( "!", ")" etc...) => Separate query context and filter context: - Search scores are not altered by facets, - Ability to use range filter (i.e for publication date facet) Regards, Claire.

2 1

Write good commit messages
by Jonathan Druart 31 Jan '20

31 Jan '20

Hi devs, This is a gently reminder about the bug report titles and commit messages. At the last dev meeting we discussed if we should or not reinforce, at QA and RM step, the coding codeline about how commit messages are written. We voted yes :) Can you please read again the following wiki page:https://wiki.koha-community.org/wiki/Commit_messages And especially the "examples" section: https://wiki.koha-community.org/wiki/Commit_messages#Examples The main point is: the bug report title must describe what the bug is, while the commit title must describe what the patch does, so most of the time you must not copy the bug report title to the commit title. Previous message to the list: https://lists.koha-community.org/pipermail/koha-devel/2017-August/043991.ht… Cheers, Jonathan

1 0

Global Bug Squashing Day - February 14th 2020
by Renvoize, Martin 30 Jan '20

30 Jan '20

Hi All, At the last Koha Developers Meeting, it was proposed that we bring back regular Global Bug Squashing Day events to help keep the bug queue moving along and encourage more people to get involved. As such, we are arranging such a day to take place on the 14th of February. We hope to see some new names added to the list of contributors: Testing, Signoff, Quality Assurance, Patch Writing, Documentation additions all count, and there will be friendly developers available to help throughout the day on IRC <https://koha-community.org/get-involved/irc/>! If you have always wanted to get involved now is a good time, so spin up a devbox, try out a sandbox, or just visit us in IRC and ask everything you wanted to know about Koha and we will help as best as we can. Please see https://wiki.koha-community.org/wiki/2020-02-14_Global_bug_squashing_day for more information. *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager Community Release Manager (19.11, 20.05) *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize(a)ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info(a)ptfs-europe.com

1 0

Just a test
by Marcel de Rooy 30 Jan '20

30 Jan '20

Testing from another address.

1 0

Signoff request for bug 21190 [GDPR logging]
by Marcel de Rooy 30 Jan '20

30 Jan '20

Hi, See bug 21190. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 GDPR: Log successful/unsuccessful login attempts [part 1] Some people asked for it. I wrote something. I do not really need it myself. I waited three months, but to no avail. This is my last resort ;) If you are interested in such changes, please test and signoff. If no one is, I will not keep waiting but just happily close the report. Thanks, Marcel

1 0