December 2017 - Koha-devel - lists.koha-community.org

Write good bug report titles and commit messages
by Jonathan Druart 04 Apr '18

04 Apr '18

Hi devs, I would like to do a little reminder about the bug report titles and commit messages. For bugs: The bug report title must shortly tell what the *bug* is, whereas the commit messages must tell what the *fix* does. Sometimes they are not related at all. For instance: - bug report titles: "Feature X is not working correctly when Y is enabled", "Click on button 'Save' does not save the record", "Saving stuff on screen X does not work", "This script generates error logs", "Mystake is misspelled in this script", "Behaviour X no longer work as expected" etc. - commit messages: "Fix Feature X when Y is enabled", "Make sure behaviour is correct when button is clicked", "Remove warnings from this script", "Correct spelling of mistake in this script", "Fix regression on behaviour X" etc. For enhancements / new feature: We could have the same title and commit messages in some cases. - bug report titles: "Add new awesome feature", "Add the ability to do that", "Code is duplicated in method Koha::Stuff->method" - commit messages: "Add new awesome feature", "Add the ability to do that", "Remove code duplication in method Koha::Stuff->method" Note that "Address comment #42" is a terrible commit message. Then, I would like to standardize the commit messages a bit. We have "Bug 12345 - ", "Bug 12345: ", "Bug 12345" and "[follow-up]", "(follow-up)", "[QA Followup]", etc. I would suggest: "Bug 12345: you commit message" And reject any commit messages with only "follow-up" (or whatever how it is written), but accept "Bug 12345: (follow-up) same commit message as before" If you forgot something, even if "Bug 12345: (follow-up) This was missing" And QA follow-ups (added by QA team member): "Bug 12345: "(QA follow-up) Add/remove this stuff" I am going to suggest these change during the next dev meetings. If accepted I will change the bug report titles and commit messages before the push during few weeks, then ask authors to do it themselves (patches from new contributors will not be rejected for that reason). You should also read or re-read: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines https://wiki.koha-community.org/wiki/Commit_messages Cheers, Jonathan

6 6

Koha and Elastic Search used in production ?
by Paul Poulain 11 Jan '18

11 Jan '18

Hello all, Is there someone using Koha with ES in production ? bywater, PTFS-E, Catalyst-NZ, Theke, or any other support company, what's your plan ? BibLibre is planning to invest some effort to work on Koha-ES with UNIMARC in the next months, if there are things to share, we would be more than happy ! -- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries

3 2

MySQL 5.7 issues and Database Config
by Nick Clemens 27 Dec '17

27 Dec '17

HI All, At the last meeting it came up that the latest versions of MariaDB are enforcing sql strict mode: https://mariadb.com/kb/en/library/sql-mode/ This page on the wiki will need to be updated with the configuration tweaks needed for allowing koha to work: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04… We should also focus on solving the issues here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 If someone with the correct knowledge can update the wiki it would be appreciated. At the meeting folks were interested in helping anyone who can provide patches to work towards compatibility. Let us know if you can, what help you need, and let get this moving :-) -Nick (kidclamp)

2 1

REST api RFCs
by Tomas Cohen Arazi 21 Dec '17

21 Dec '17

Hi everyone. Following yesterday's dev meeting (I'm sorry I couldn't attend) it was clear there should be some votes on the changes that we belive need to be made. In order to organize the documentation on this decision making process, and have something more precise to vote on, I've put together a front wiki page: https://wiki.koha-community.org/wiki/REST_api_RFCs in which all endpoint-specific RFCs can be found. I have added the endpoints I've been, am and will be working on. Also endpoints I know Biblibre is working on. As the discussion was about the patrons endpoint specifically, I started by creating an RFC for it: https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC It is organized in two sections: actions and paths, and the object definition. The idea is that you can add your own column (put your name on it) with your personal proposal. Discussions can happen in other places like IRC or koha-devel. Please add your comments on each issue you think it is worth, and please contact me if you have any doubts or want to discuss specific stuffs. I will be spending the next days polishing this RFC and moving into the rest of them in the same way. Before adding new endpoints to that list, I would suggest we have a small conversation here in koha-devel to avoid polluting the front page with several variations of the same endpoints. This is just a suggestion, though. Thanks for your interest and feedback! Cheers -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

3 6

QA Sprint - Get your bugs ready!
by Katrin Fischer 19 Dec '17

19 Dec '17

Hi all, just a quick note: the QA team will have a QA sprint on 21 December. https://wiki.koha-community.org/wiki/2017-12-21_QA_Sprint_Day You might want to make sure your patches apply, polish your commit messages and update your test plans! :) Katrin

1 0

Recent TLS vulnerability (AKA ROBOT)
by Victor Grousset 15 Dec '17

15 Dec '17

Hi, Here is a quick and dirty summary of what I have found: https://framagit.org/snippets/1131 Has anyone found something contradictory or complementary? Cheers, -- Victor Grousset, dev support/maintenance BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Libre/Open Source software and services for libraries

1 0

Starman workers reload via signal
by Fridolin SOMERS 15 Dec '17

15 Dec '17

Hi, We recently found some interesting Starman feature. Since it is a master/workers software there is, like in Apache, a way to "gracefully" rebuild the workers without stopping master : kill -HUP 123 (123 being the master PID). Unlike stop/start of starman, the used workers will not be stopped until there task is done. During that idle workers will indeed be killed and rebuild. This is useful when one wants to refresh Plack persistence on a production running server. See : https://metacpan.org/pod/distribution/Starman/script/starman#SIGNALS We used this in our systemd service for starman : ExecReload=/bin/kill -HUP ${MAINPID} This may be usefull in koha-plack. Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre - software and system maintainer

1 0

Re: [Koha-devel] Bug 18539 - Forbid Koha::Objects->find calls in list context
by Julian Maurice 15 Dec '17

15 Dec '17

Probably, but that's not my point. I understand why the previous code needed to be fixed, which is to avoid that { a => Koha::Patrons->find("foo"), b => "bar" } would result in { a => "b", "bar" => undef } My question is: why the solution to this problem was to forbid calls in list context while we could simply return an explicit undef? It forces us to write 'scalar' in front of a call that should always return a single value, and in my opinion it's a "code smell" Le 13/12/2017 à 15:29, Marcel de Rooy a écrit : > i forgot to add scalar in the second.. > > probably you should > > if( $a = xxx->find ) > > push @b, $a > > > ------------------------------------------------------------------------ > *Van:* Julian Maurice <julian.maurice(a)biblibre.com> > *Verzonden:* woensdag 13 december 2017 15:20:34 > *Aan:* Marcel de Rooy > *Onderwerp:* Re: [Koha-devel] Bug 18539 - Forbid Koha::Objects->find > calls in list context > > This particular line will work (only the first, in the second, find is > still called in list context), but @a would contain one element (undef) > and the example code given by Jonathan will also fail, whether we call > find in list context or not. > > Le 13/12/2017 à 15:12, Marcel de Rooy a écrit : >> Are you sure ? >> >> push @a, scalar Koha..->find >> >> or @a = ( ...->find ) >> >> >> should work imo >> >> ------------------------------------------------------------------------ >> *Van:* koha-devel-bounces(a)lists.koha-community.org >> <koha-devel-bounces(a)lists.koha-community.org> namens Julian Maurice >> <julian.maurice(a)biblibre.com> >> *Verzonden:* woensdag 13 december 2017 15:07:11 >> *Aan:* Jonathan Druart >> *CC:* koha-devel(a)lists.koha-community.org >> *Onderwerp:* Re: [Koha-devel] Bug 18539 - Forbid Koha::Objects->find >> calls in list context >> >> Ok, but the proposed fix doesn't fix this code: >> >> @a = scalar Koha::Patrons->find('foo'); >> if (@a) { # still equals to 1 >> say $a[0]->borrowernumber; # still BOOM >> } >> >> And yes, that was the link ;) >> >> Le 13/12/2017 à 14:58, Jonathan Druart a écrit : >>> Hi Julian, >>> >>> >>>> @a = Koha::Patrons->find('foo'); # would result in @a = (undef) >>> >>> And that leads to issues: >>> if ( @a ) { # = 1 >>> say $a[0]->borrowernumber; # BOOM >>> } >>> >>> See also https://perlmaven.com/how-to-return-undef-from-a-function (was >>> it the link you were talking about?) >>> >>> Cheers, >>> Jonathan >>> >>> On Wed, 13 Dec 2017 at 10:34 Julian Maurice <julian.maurice(a)biblibre.com >>> <mailto:julian.maurice@biblibre.com>> wrote: >>> >>> Hi developers, >>> >>> I stumbled upon a line of code recently and I can't figure out why it >>> has be done this way. I hope you can help me :) >>> >>> The line in question is in Koha::Objects::find: >>> >>> croak 'Cannot use "->find" in list context' if wantarray; >>> >>> I read the two bugs (18539 and 18179) and the link given by Jonathan but >>> I still don't understand why the call in list context has been >>> forbidden. Why not simply return undef (an explicit undef) when no >>> records have be found ? It would work as expected in scalar and list >>> contexts. >>> >>> Here is a possible rewrite of 'find' to better explain what I mean: >>> >>> sub find { >>> my ( $self, @pars ) = @_; >>> >>> my $object = undef; >>> >>> @pars = grep { defined } @pars; >>> if (@pars) { >>> my $result = $self->_resultset()->find(@pars); >>> if ($result) { >>> $object = >>> $self->object_class()->_new_from_dbic($result); >>> } >>> } >>> >>> return $object; >>> } >>> >>> @a = Koha::Patrons->find('foo'); # would result in @a = (undef) >>> {a => K::P->find('foo'), b => 'bar'}; # would result in {a => undef, b >>> => 'bar'} >>> >>> Please tell me what you think. >>> >>> -- >>> Julian Maurice <julian.maurice(a)biblibre.com >>> <mailto:julian.maurice@biblibre.com>> >>> BibLibre >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel(a)lists.koha-community.org >>> <mailto:Koha-devel@lists.koha-community.org> >>> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website : http://www.koha-community.org/ >>> git : http://git.koha-community.org/ >>> bugs : http://bugs.koha-community.org/ >>> >> >> -- >> Julian Maurice <julian.maurice(a)biblibre.com> >> BibLibre >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel(a)lists.koha-community.org >> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ >> git : http://git.koha-community.org/ >> bugs : http://bugs.koha-community.org/ > > -- > Julian Maurice <julian.maurice(a)biblibre.com> > BibLibre -- Julian Maurice <julian.maurice(a)biblibre.com> BibLibre

3 4

Reminder string freeze for stable December 15th
by Nick Clemens 14 Dec '17

14 Dec '17

Hi All, I mentioned at the meetings yesterday but just sending a reminder not here. Pushing patches today and catching up now, string freeze tomorrow. -Nick (kidclamp)

1 0

Call for News: December 2017 Newsletter
by kohanews 14 Dec '17

14 Dec '17

I'm collecting news for the December newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events , **** one month back is the cut-off ****. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. Thank you! -- Chad Roseburg Editor, Koha Community Newsletter

1 0