November 2017 - Koha-devel - lists.koha-community.org

Write good bug report titles and commit messages
by Jonathan Druart 04 Apr '18

04 Apr '18

Hi devs, I would like to do a little reminder about the bug report titles and commit messages. For bugs: The bug report title must shortly tell what the *bug* is, whereas the commit messages must tell what the *fix* does. Sometimes they are not related at all. For instance: - bug report titles: "Feature X is not working correctly when Y is enabled", "Click on button 'Save' does not save the record", "Saving stuff on screen X does not work", "This script generates error logs", "Mystake is misspelled in this script", "Behaviour X no longer work as expected" etc. - commit messages: "Fix Feature X when Y is enabled", "Make sure behaviour is correct when button is clicked", "Remove warnings from this script", "Correct spelling of mistake in this script", "Fix regression on behaviour X" etc. For enhancements / new feature: We could have the same title and commit messages in some cases. - bug report titles: "Add new awesome feature", "Add the ability to do that", "Code is duplicated in method Koha::Stuff->method" - commit messages: "Add new awesome feature", "Add the ability to do that", "Remove code duplication in method Koha::Stuff->method" Note that "Address comment #42" is a terrible commit message. Then, I would like to standardize the commit messages a bit. We have "Bug 12345 - ", "Bug 12345: ", "Bug 12345" and "[follow-up]", "(follow-up)", "[QA Followup]", etc. I would suggest: "Bug 12345: you commit message" And reject any commit messages with only "follow-up" (or whatever how it is written), but accept "Bug 12345: (follow-up) same commit message as before" If you forgot something, even if "Bug 12345: (follow-up) This was missing" And QA follow-ups (added by QA team member): "Bug 12345: "(QA follow-up) Add/remove this stuff" I am going to suggest these change during the next dev meetings. If accepted I will change the bug report titles and commit messages before the push during few weeks, then ask authors to do it themselves (patches from new contributors will not be rejected for that reason). You should also read or re-read: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines https://wiki.koha-community.org/wiki/Commit_messages Cheers, Jonathan

6 6

SIG DIE in returns.pl
by Fridolin SOMERS 12 Dec '17

12 Dec '17

Hie, With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace. I found that there is in this page : use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ? Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre - software and system maintainer

6 6

REST api developments
by Tomas Cohen Arazi 06 Dec '17

06 Dec '17

Dear friends, I write this email to let you know me and the ByWater friends are committed to getting endpoints written, so development projects you are working on can succeed. With recent additions and specially all enhancements surrounding bug 19410, we should be able to start writing endpoints faster and easier. The REST api is top priority for us, and making it easier to code, one of our short-term goals. Let us know the endpoints your project might benefit from, we can commit to writing those endpoints, or help you in the process. We still need to have better documentation, but we'll be looking for 'REST api' tagged bugs trying to help. Kind regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F

4 5

Koha Community Newsletter: November 2017
by kohanews 30 Nov '17

30 Nov '17

Fellow Koha users: The Koha Community Newsletter for November 2017 is here: https://koha-community.org/koha-community-newsletter-november-2017/ Many thanks to the folks who submitted articles and news to this month's newsletter. Please feel free to email me with any corrections or suggestions. Thanks! -- Chad Roseburg Editor, Koha Community Newsletter

1 0

Looking for Koha System Admin
by MHE IT admin 29 Nov '17

29 Nov '17

Hi, We are looking for a Koha system admin to do two task for our university. 1. Back up and Upgrade our Koha 2. Fixing indexing for Arabic and Kurdish records both are RTL Our site is http://library.koyauniversity.org Thank you

1 0

Koha 16.05.19 released
by Mason James 29 Nov '17

29 Nov '17

The Koha community is proud to announce the release of Koha 16.05.19. This is a maintenance release of 16.05 and includes 5 enhancements and 15 bugfixes. The full release notes are available at https://koha-community.org/koha-16-05-19-release This will be my last release as the 16.05.x RMaint Thanks to everyone involved, and to Tomas and Jonathan for the new jenkins :0) cheers, Mason

3 3

Koha 17.05.03 released
by Fridolin SOMERS 27 Nov '17

27 Nov '17

The Koha community is proud to announce the release of Koha 17.05.03. This is a security release including 3 enhancements, 13 bugfixes and 16 security fixes. The full release notes are available at https://koha-community.org/koha-17-05-03-security-release/ Regards, -- Fridolin SOMERS Biblibre - Pôles support et système fridolin.somers(a)biblibre.com

2 4

Test: planned count or done_testing()
by Mark Tompsett 26 Nov '17

26 Nov '17

Greetings, While testing various bugs, frequently conflicts come up with tests where one bug adds a test, and another adds two tests, and the count difference causes the need to correct the test plan count while rebasing. So, I was wondering if perhaps when adding tests we could switch to just done_testing() and not actually use test counts, so adding and removing tests will not need fixing of line or lines that have a plan count. Thoughts? GPML, Mark Tompsett

6 5

Re: [Koha-devel] [Koha] Koha 16.11.14 released
by Jonathan Druart 26 Nov '17

26 Nov '17

5.018002 is Perl 5.18.2, so > 5.10 On Sat, 25 Nov 2017 at 01:57 SATISH <lis4satish(a)gmail.com> wrote: > Hi Katrin, > > Currently running Koha 16.11.11.000 on Ubuntu 14.04.5 LTS, which was > previously installed by package method (previous versions). > And about Koha page shows, Perl version as: 5.018002 > and It is mentioned that update from 16.11.11 to 16.11.14 requires Perl > 5.10 at https://koha-community.org/koha-16-11-14-release/ > Does update in Koha automatically brings Perl 5.10 or should it be manually > updated? > > Thank you > > Satish MV > Librarian > Govt. Engineering College, Hassan > Karnataka. > _______________________________________________ > Koha mailing list http://koha-community.org > Koha(a)lists.katipo.co.nz > https://lists.katipo.co.nz/mailman/listinfo/koha >

1 0

Wiki - please remove spammer Kcclibrary02 and pages they have added
by David Nind 24 Nov '17

24 Nov '17

Grr.... I let a spammer lose on the Wiki!! Could someone who has access block user Kcclibrary02 and remove the pages they have created? https://wiki.koha-community.org/wiki/Special:Contributions/Kcclibrary02 Apologies. They looked reasonably okay when I approved the account..... David Nind | david.nind(a)gmail.com PO Box 12367, Thorndon, Wellington, New Zealand 6144 m. +64 21 0537 847

2 2