April 2017 - Koha-devel - lists.koha-community.org

Expected behaviod when printing serials - add reserve?
by Jonathan Druart 25 May '17

25 May '17

Hi devs, I found an obvious bug in serials/routing-preview.pl. If the script is called with ok=1 (hum... yes...), the script will add or modify a hold placed on the bibliographic records existing in the routing list. So from /serials/serials-collection.pl?subscriptionid=1, click on "Print list" you get a pop-up with a print and close button. When the pop-up is generated, we already have the ok=1 and the go through: 66: my ($count2,@bibitems) = GetBiblioItemByBiblioNumber($biblio); Then later: 96 AddReserve($branch,$routing->{borrowernumber},$biblio,\@bibitems,$routing->{ranking}, undef, undef, $notes,$title); The problem is that GetBiblioItemByBiblioNumber will always return only 1 value (for obvious reasons) and @bibitems will always be empty => reserve is placed at bib level The thing is that this bug exists for ages (at least 2006, maybe always). What is the expected behaviour? No need to tell you that I was going to kick GetBiblioItemByBiblioNumber when I found that bug. Cheers, Jonathan

3 2

Koha 17.05 Dates
by Kyle Hall 17 May '17

17 May '17

Here is my planned timeline for the Koha 17.05 release: May 5 - Feature Slush May 12 - 1st Draft of Release Notes May 19 - Feature Freeze, Release Beta, 2nd Draft of Release Notes May 26th - Final Release If anyone sees a need to modify this timeline, please let me know! Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org )

4 6

Single character searches are slow when queryfuzzy and/or querystemming are enabled.
by Barton Chittenden 09 May '17

09 May '17

I've got an issue that we've seen periodically at ByWater; I want to file a bug, but I don't have a clear idea of how to replicate the issue, so I'm trying to solicit information from the community on how to narrow the scope of the problem and/or measure the performance problems that I'm seeing. The problem is that keyword searches (as you'd see from an un-modified masthead search on the opac, or the "search the catalog" search on the staff client) are markedly slow on some sites when a) The search term contains single letter words like "a" in "Once Upon A Time" and b) One or both of the QueryFuzzy or QueryStemming system preferences is enabled. We first ran across this issue when we moved a number our Koha instances to slower drives, and found that some (but not all) would time out when searching for "Once upon a time", "A swiftly tilting planet", "Hitchiker's Guide to the Galaxy" (where the 's' after the apostrophe is counted as a single word). I turned on 'request' logging in zebra, here's the query that timed out: find @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 "once upon a time" @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 "once upon a time" @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 "once upon a time" @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 "once upon a time" @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 "once upon a time" @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "onc? upon? a time? " @attr 4=6 @attr 9=14 @attr 2=102 "once upon a time" Sent searchRequest. I ran the PQF in zebra: Z> base biblios Z> find @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 "once upon a time" @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 "once upon a time" @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 "once upon a time" @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 "once upon a time" @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 "once upon a time" @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "onc? upon? a time? " @attr 4=6 @attr 9=14 @attr 2=102 "once upon a time" Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 119, setno 1 SearchResult-1: term=once upon a time cnt=3, term=once upon a time cnt=5, term=once cnt=94, term=upon cnt=63, term=a cnt=4876, term=time cnt=515, term=once cnt=168, term=upon cnt=125, term=a cnt=19801, term=time cnt=1507, term=once cnt=9830, term=upon cnt=960, term=a cnt=82237, term=time cnt=8524, term=onc cnt=1915, term=upon cnt=914, term=a cnt=82237, term=time cnt=7709, term=once cnt=1302, term=upon cnt=914, term=a cnt=68283, term=time cnt=5442 records returned: 0 Elapsed: 98.163583 The elapsed time is just under 100 seconds; I think Koha times out after 60. We looked at the disk I/O and found that the disk where the searches were occurring was getting hammered, so we migrated the sites that were having issues onto a server that had a much faster drive, and this did, at least solve the time-out issue. The issue keeps on popping up, however -- if not in actual timeouts, then at least in complaints of slowness in search. My hypothesis is that either QueryFuzzy or QueryStemming is expanding the one letter words, i.e. a search for "a" is returning results for either all words that start with "a" or all words contaning "a", and that all of these results are written to disk before any further filtering is done. When we were seeing timeout issues, I'm not clear on which sites were likely to have issues -- sites with a very small number of bibs didn't have issues, but the problem wasn't solely by collection size. So here's what I'd like to know, for the purposes of further testing, and/or to be able to replicate the issue: 1) Is there anyone who knows all about PQF who can tell me why the query above would run so slowly? 2) Is there part of the PQF that seems to be behaving particularly badly? Which parts of the query are returning "term=a cnt=82237", and can we avoid having that called twice? 3) How do I go about constructing a data set that illustrates this problem? 4) What's the best way to measure the performance problems and/or define what the problem is when I file a bug? 5) Are there any work-arounds, given that certain sites really want query stemming and queryfuzzy enabled? Thanks, --Barton

2 1

The interface "winks" when I check out a book after upgrading firefox
by Francois Charbonnier 05 May '17

05 May '17

Hi, I use Koha 16.05 and firefox 53. When I check out an item, the interface "winks". I tried this with firefox 52, the interface stays still. Have you noticed it as well ? Any advice to fix it ? Thanks! -- François Charbonnier, Bibl. prof. / Chef de produits Tél. : (888) 604-2627 francois.charbonnier(a)inLibro.com <mailto:francois.charbonnier@inLibro.com> inLibro | Spécialistes en technologies documentaires | www.inLibro.com <http://www.inLibro.com>

3 4

Koha and xhtml2pdf
by Fridolin SOMERS 05 May '17

05 May '17

Hie. We have some problems with xhtml2pdf on Ubuntu Xenial. This soft is used by misc/cronjobs/printoverdues.sh. First it is strange that the package containing this soft "python-pisa" is not in koha-deps. I see there is "html2pdf" but there is no CSS option. In jessie we have to use the jessie-backports repo and install several packages : python-pisa python3-reportlab python-html5lib python-pypdf python-imaging python-renderpm python-reportlab python-reportlab-accel On ubuntu Xenial, we install those same packages but we have a bug in python call. We found it can be corrected by installing xhtml2pdf from its GIT repo. We would prefere to avoid this. Any help is welcome. Best regards, -- Fridolin SOMERS Biblibre - Pôles support et système fridolin.somers(a)biblibre.com

4 5

Task schedulers and message queues for Koha
by David Cook 04 May '17

04 May '17

Hi all, In 2016, I worked on a Koha task scheduler for downloading and importing records via OAI-PMH. I have code which works, but it's lacking test coverage and I'm unsure that it will make it through QA and be accepted. I recall Chris Cormack suggesting I look at Gearman (http://gearman.org/) instead, and it looks pretty good at a glance, although Andreas and I had talked about having more control over the workers than Gearman seems to offer. Plus, it added another dependency to Koha where people already struggle with dependencies. Martin suggested that there were a lot of other implementations out there, but I haven't really found much else that provides everything we want out of the box. The one I have found is Celery (http://www.celeryproject.org/) which looks like exactly what I want I think, but it requires Python for its server and workers, and it requires a message broker like RabbitMQ or Redis. Lots of extra dependencies. Since my goal is to get our code into Koha, I really want to know what will work for people. Are people happy with a home grown solution? It's not really that complicated. My current version is essentially a task scheduler which forks a worker on demand when it's time to run a task (up to a configurable max of X tasks so you don't kill your server). It lets you submit tasks, tell the scheduler to start/schedule them, and you can even tell in progress tasks to stop (by having the scheduler tell the worker to stop and the worker decides where in its task it checks for stop commands from the scheduler). As I try to add test coverage and make this scheduler more palatable, I find myself thinking about the code more like Koha::Scheduler and Koha::Queue, and using the more scalable worker model used by others. The scheduler daemon would listen on a socket for tasks, it would create a Koha::Scheduler instance which would enqueue tasks to run once that task's time was met or exceeded. Now depending on the architecture. you could have a separate daemon or the same daemon with a Koha::Queue instance. It would accept tasks/messages from the scheduler, and it would dequeue tasks to available workers - which are separate processes - have previously registered against particular queues. In this way, you can have a oaipmh-download queue, oaipmh-import queue, a email-report queue, etc. I suspect that we could make use of Koha::Scheduler and Koha::Queue throughout much of Koha for doing background tasks. If we don't want to reinvent the wheel with Koha::Queue, we could use something like RabbitMQ. But I think we need *something*. I'm open to ideas. I already have the OAI-PMH download and OAI-PMH import handled. That's the easy part. Any worker can do that. The hard part is figuring out how the Koha Community will take up a task scheduler. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

4 8

Gender-neutral pronouns
by Eric Phetteplace 30 Apr '17

30 Apr '17

Hi list, I opened bug #18432 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18432 because I saw several places in the Koha codebase where the pronoun "he" was being used to refer to a generic third person who could be of any gender. Jonathan Druart noted that this should be a coding guideline, as otherwise new instances of gendered pronouns might continue to be added. Perhaps it belongs on the "Terminology" page of the wiki? So here's my proposal. I'm trying to be concise. ---- *Use gender neutral pronouns* When referring to a person who could be of any gender, you should use the words they/them/their. This goes for code comments, text in templates, and strings in tests. For example, here's a string from a patrons test updated to be gender neutral. Before*:* is( $total, $enrolmentfee_K + $enrolmentfee_J, "Kid growing and become a juvenile, he should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) ); After: is( $total, $enrolmentfee_K + $enrolmentfee_J, "Kid growing and become a juvenile, they should pay " . ( $enrolmentfee_K + $enrolmentfee_J ) ); Gender neutral terms are preferable for a few reasons. They're more welcoming, showing that Koha expects users and contributors to be of any gender. They're also more accurate. Inappropriately using a particular gender can cause confusion, leading someone to believe that code operates differently based on the value of borrowers.sex, for instance. ---- I hope that's clear. I'm happy to reword it, and to attend the next Koha developers meeting to explain further if need be. Best, Eric Phetteplace Systems Librarian California College of the Arts libraries.cca.edu | vault.cca.edu 510.594.3660 2>/dev/null

18 27

Global Bug Squashing Day (Bugs only edition) - GBSD, May 10th, 2017
by Nick Clemens 28 Apr '17

28 Apr '17

Hi All, At the last Koha Developers Meeting it was proposed to hold a special 'Bugs Only' Squashing Day in order to clean up things before the 17.05 release. We are hoping to get some new sign-offers, librarians, and developers involved in the process and make 17.05 the new hotness. There is a developers meeting that day as well, so there should be plenty of us available to help. We want your questions, we want to help! If you have always wanted to get involved now is a good time, so spin up a devbox, try out a sandbox, or just visit us in IRC and ask everything you wanted to know about Koha and we will help as best as we can I will follow with more info next week but wanted to at least get the date out before the weekend. -Nick (kidclamp)

1 0

Koha + Elasticsearch 5.x dependency packages
by Mirko Tietgen 28 Apr '17

28 Apr '17

Hi, it looks like I am done submitting and backporting dependencies for Koha and Elasticsearch 5.x. I ran it in a test repo and it works as far as I can see. Adding them to the unstable repository may or may not break Kohadevbox and other setups, so I thought I'd give you a warning before I do that. I will add the following packages: libapp-cmd-perl_0.331-1~kohadev1 libbusiness-isbn-perl_3.003-1~kohadev1 libcatmandu-marc-perl_1.09-1~kohadev1 libcatmandu-perl_1.0304-2~kohadev1 libcatmandu-store-elasticsearch-perl_0.0507-1~kohadev1 libcpanel-json-xs-perl_3.0225-1~kohadev1 liblog-any-perl_1.045-1~kohadev1 libmarc-lint-perl_1.50-1~kohadev1 libmoox-aliases-perl_0.001006-1~kohadev1 libmoox-role-logger-perl_0.005-1~kohadev1 libnamespace-clean-perl_0.27-1~kohadev1 libsearch-elasticsearch-perl_5.01-1~kohadev1 libmarc-spec-perl_0.1.2-1~kohadev1 libparser-mgc-perl_0.15-1~kohadev1 libref-util-perl_0.113-1~kohadev1 libtext-hogan-perl_1.04-1~kohadev1 liburi-template-perl_0.22-0.1~kohadev1 Tomas (and other people with Kohadevbox knowledge), I suppose you need to make changes to not CPAN stuff anymore? To pull in the new packages, it should be enought to apt-get install libcatmandu-store-elasticsearch-perl libcatmandu-marc-perl once they are in the repository. I plan to have the packages in the unstable repository next monday. Cheers, Mirko -- Mirko Tietgen mirko(a)abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de

3 4

Koha 16.11.07 released
by Katrin 28 Apr '17

28 Apr '17

The Koha community is proud to announce the release of Koha 16.11.07. This is a maintenance release of 16.11 and includes 38 bugfixes. The full release notes are available at https://koha-community.org/koha-16-11-07-release/ Packages will be available soon.

2 1