April 2007 - Koha-devel - lists.koha-community.org

Members : Code Cleaning
by Henri-Damien LAURENT 25 Apr '07

25 Apr '07

* Bornamesearch and GuarantornameSearch => SearchMember * GetMember, borrdata,getguarantordata => GetMember with a change in signature. * borrdata2 => GetBorrowerIssuesAndFines * GetMemberDetails No changes. * calcexpirydate =>GetExpiryDate * modmember => ModMember * newmember => AddMember * borrissues => GetPendingIssues * allissues => GetAllIssues * GetMembeReregistration => ExtendMemberSubscriptionTo * getboracctrecord =>GetMemberAccountRecords no longer takes env * GetBorrowersTitles => GetTitles * findguarantees => GetGuarantees * DeleteBorrower => MoveMemberToDeleted (move member data to deletedborrowers) And DelMember (delete member) * deletemembercompletely => DelMember * GetBorrowersFromSurname => GetMembersFromSurname * citycaracteristiques => GetCities * GetBorNotifyAcctRecord now takes borrnumber, and $notifyid and no longer env, param. * GetFlagsAndBranchFromBorrower is deleted.

1 0

code cleaning of Reserves.pm
by Paul POULAIN 24 Apr '07

24 Apr '07

* GlobalCancel : renammed to ModReserveCancelAll * OtherReserves : renamed to GetOtherReserves * MinusPriority : renamed to ModReserveMinusPriority and SQL improvement: 2 nested SQL read/update that could be done in 1 step * SetWaitingStatus : renamed to ModReserveStatus * GetReservations and FindReserves merged, API changed and resulting sub is GetReserves * GetFirstReserveDateFromItem removed (mered into GetReserves improved to return the branchcode that was the only field missing) * splitting GetReserves in 3 different sub : one for each parameter. Depending on the parameter (biblionumber / itemnumber / borrowernumber), the GetReserves sub returned differents things (2 var, 1 array ...) that is silly & hard to read. Splitting in 3 subs is not the most efficient, but it's more readable. Later, we could maybe merge them again by having a common returned result, but i'm not sure it would be possible * CountReservesFromBorrower renamed to GetReserveCount * CheckReserves : No change (see question below) * CancelReserve : name unchanged (it's not a reserve deletion, so I think DelReserve is wrong) * FillReserve renamed to ModReserveFill and variable names changed internally * FixPriority renamed to _FixPriority (internal sub) * WaitingReserves renamed to ModReserveAffect, POD & cleaned * GetWaitingReserves : removed (merged in BetReservesFromBorrowernumber) * CalcHLTReserveFee : removed (hardcoded specific rules for HLT. Don't ask me to reintroduce them, I will disagree : we can't have specific hardcoded code in Koha) * GetNextAccountNumber : removed (unused) * UpdateReserve : renamed to ModReserve * findgroupreserve : renamed to _findgroupreserve (internal sub) * CreateReserve : renamed to AddReserve (& opac-reserve call fixed : a undef parameter useless) * CalcReserveFee : renamed to GetReserveFee * GetReserveTitle : removed (useless) * FindReservesInQueue : removed (copy of GetReservesFromBiblionumber) * CheckReserves : removed $barcode parameter (never used) QUESTION 1 : what is reservecontraint table done for ? does it work ? It seems that the table is filled only in Reserves.pm, CreateReserve, only if constraint='o' or 'e' (dunno what it means). In the code, contraint seems to be possibly 'a', but I don't know how it can occur. QUESTION 2 : could someone explain exactly how reserves work (internally). I'm not sure i've got all cases. CONCLUSION : i'm not fully happy with this cleaning. I think a second tour could/should be done, mainly in Modxxx sub, as I think we could have a fewer number of subs. But I won't do it. -- Paul POULAIN et Henri Damien LAURENT Consultants indépendants en logiciels libres et bibliothéconomie (http://www.koha-fr.org) Tel : 04 91 31 45 19

1 0

code cleaning of circulation
by Paul POULAIN 23 Apr '07

23 Apr '07

Hi, hdl & me start cleaning circulation module. The goal will be to have : - C4/Circulation.pm => to deal with issues, returns, transfers - C4/Overdues.pm => to deal with overdues and fines - C4/Reserves.pm => to deal with Reserves thus : - C4/Circulation/ will disappear - most subs will be renamed - some subs will be moved from a package to another - some subs will be dropped (merged into another one) comments welcomed ;-) -- Paul POULAIN et Henri Damien LAURENT Consultants indépendants en logiciels libres et bibliothéconomie (http://www.koha-fr.org) Tel : 04 91 31 45 19

6 9

record into database from script?
by Jason Ronallo 20 Apr '07

20 Apr '07

Hi, I'm writing a command line script for rapid copy cataloging. At the moment it's very specific to my library, but I hope to make it more generic and useful for others. It adds on item level information, so I bulkmarcimport the saved files and the records are immediately active in the catalog. It also outputs a csv list that I use for printing labels in glabels. What I'm wondering is how I can get my script to push a MARC record into the active database or at least into the reservoir? I'm imagining that the script is being used by a copy cataloger and not the administrator of the machine, so calling bulkmarcimport won't work. Or would I be able to change group permissions on bulkmarcimport.pl, make the copy catalogers (who are on Linux boxes) members of the group, and then when they run the script their call to bulkmarcimport.pl will work? What other options are there? --Jason

1 0

Replace rel_2_2 with dev_week ?
by Bruffey, Mark 17 Apr '07

17 Apr '07

Reposting, because I think I made an error in the manner in which I posted it previously. Sorry. I'm trying to understand the relationship between the document "Updating KOHA" and the document "Installing and Configuring KOHA's Zebra Plugin." Following a fresh install of 2.2.8, I seem to have successfully implemented the instructions in "Updating KOHA." At least the interfaces come up. (I have inserted only one record into the database at this point; intranet db searching is fine, opac errors out in search iface but not a great concern at this point.) Comments: In "Updating KOHA" p.4, it would be helpful to clarify that $KOHA_WORKING_DIR ends up being $KOHA_WORKING_DIR/koha for the purpose of the symbolic links--or at least it did for me. Assuming I did get that right (I used MC to match contents of directories before executing ln -s in each case), I now want to "Install and Configure KOHA's Zebra Plugin." I've figured out the instructions up to _Prepare the Filesystem_, but now, stuck. I can't figure out if I am supposed to ditch all the symlinks I just created for cvs rel_2_2 in favor of dev_week. I have downloaded both into separate directories, but it looks like linking dev_week into /koha will overlap with rel_2_2 links. Should I just eliminate the rel_2_2 links and replace with the dev_week? Thanks, Mark L. Mark Bruffey Director Library Services Central Baptist Theological Seminary 900 Forestview Lane N Plymouth MN 55441 763 417 8264 (Tel) 763 417 8258 (Fax) mbruffey(a)centralseminary.edu Central Seminary www.centralseminary.edu <http://www.centralseminary.edu/> Fourth Baptist Church www.fourthbaptist.org <http://www.fourthbaptist.org/> WCTS Radio AM 1030 Online www.centralseminary.edu/wcts *************************************** Have you experienced the good news? "Every one who calls on the name of the Lord will be saved!" [Romans 10:13] ***************************************

2 1

where is opac-export.pl?
by Jason Ronallo 12 Apr '07

12 Apr '07

Hi, I'm wondering if anyone could direct me to opac-export.pl in cvs? I see from the live NPL opac-detail.pl pages that this is the script that runs when you select to save an individual record in various formats, but I can't find it in cvs. I'm trying to see if I can get this single record export to work in rel_2_2 (2.2.8 specifically). I know a little Perl, but still trying to find my way around cvs. A project I'm thinking about starting will rely on this functionality to succeed. --Jason

1 0

WebInstaller modification rel_30 [Important]
by Henri-Damien LAURENT 06 Apr '07

06 Apr '07

Adding Check for a systempreference Version Variable skips third party software check and mysql check to go to updatedatabase. Adding similar check to intranet and opac. BEWARE !!!!! You may be linked to install if you donot have Version variable set in your systempreferences table. If so, simply updatedatabase OR add Version 3.0 record to your systempreferences table. -- Henri-Damien LAURENT

1 0

Authorities MARC : Code Cleaning. Call for comment.
by Henri-Damien LAURENT 06 Apr '07

06 Apr '07

GetAuthType $result= &GetAuthType( $authtypecode) If $authtypecode is not "" then Returns hashref to authtypecode information else returns ref to array of hashref information of all Authtypes FindDuplicateAuthority $record= &FindDuplicateAuthority( $record, $authtypecode) return $authid,Summary if duplicate is found. Comments : an improvement would be to return All the records that match. BuildSummary $text= &BuildSummary( $record, $authid, $authtypecode) return HTML encoded Summary Comment : authtypecode can be infered from both record and authid. Moreover, authid can also be inferred from $record. Would it be interesting to delete those things ? BuildUnimarcHierarchy $ref= &BuildUnimarcHierarchy( $record, $class,$authid) return a hashref in order to display hierarchy for record and final Authid $authid "loopparents" "loopchildren" "class" "loopauthid" "current_value" "value" "ifparents" "ifchildren" Those two latest ones should disappear soon. merge $ref= &merge(mergefrom,$MARCfrom,$mergeto,$MARCto) Could add some feature : Migrating from a typecode to an other. For instance, a person into a Corporate Name, Topical to Toponymy. Then we should add some new parameter : bibliotargettag -- Henri-Damien LAURENT

1 0