May 2011 - Koha-devel - lists.koha-community.org

Re: [Koha-devel] Hacker's corner, week 19
by Chris Cormack 10 May '11

10 May '11

On 10 May 2011 07:55, "Dobrica Pavlinusic" <dpavlin(a)rot13.org> wrote: > > On Tue, May 10, 2011 at 06:43:11AM +1200, Chris Cormack wrote: > > Actually for 3.6.x the workflow has changed slightly. > > > > http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow > > Excuse me, but I don't quote understand how my batch of LDAP fixes > (Koha bugs 4993, 4994 and 6022) will get into bug/enhancement? You are doing the exact right thing bringing it up on the devel list. > > Would it help to merge all LDAP changes in single bug and submit that? > Linking them altogether with the depends feature would be good, can they be tested independently? If not noting that on the bug would be great. > I have been using this code for years, and it seems that only few users > use LDAP with auth_by_bind in Koha. I was recently contacted by one > library which had problem with it, so there is interest other than my > own library needs. > Excellent, the first step is finding someone to sign off. I have a client who uses auth by bind, so I am willing to do the initial sign off on these. I will attempt to do this today, if there is anything I need to know when testing please let me know. Finding the initial person to signoff can be tricky, but asking on the mailing list and/or irc is a perfect way to do it. Chris > -- > Dobrica Pavlinusic 2share!2flame dpavlin(a)rot13.org > Unix addict. Internet consultant. http://www.rot13.org/~dpavlin

2 1

Document to read
by Paul Poulain 09 May '11

09 May '11

Hello, chris gave this url on IRC, I think it's worth sharing : http://www.codesimplicity.com/post/open-source-community-simplified/ it's a great document. I think it's worth asking ourself : "what are we doing well, what could we improve" This question is specifically sent to new contributors: what did we well, what could be improve for new/future newbies ? -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08

1 0

3.2.x String Freeze and Roadmap Update
by Chris Nighswonger 09 May '11

09 May '11

Hi All, We are going to keep with May 15, 2011 for the 3.2.8 release which puts 3.2.x into a string freeze as of today. The 3.2.x branch has quite a few commits since 3.2.7, so this will be an important release. 3.2.x will thaw on May 16. Subsequent 3.2.x releases will be largely dependent upon commits available for back porting and patches submitted directly against the 3.2.x branch. At present, the plan is to support 3.2.x through 3.2.10 *if* there are commits/patches to do so. When we get to 3.2.10 or when it is clear we will not get there, I'll add a monthly IRC meeting agenda item to discuss EOL for the 3.2.x branch. As always: Thanks to all the individuals who have put time, effort, and money into making Koha a great ILS! Kind Regards, Chris Nighswonger 3.2.x/3.4.x Release Maintainer

1 0

What's the current state of Course Reserves?
by Kyle Hall 09 May '11

09 May '11

Hello All, Some months ago there was talk on the list about adding course reserves to Koha. I was just wondering if there was anyone actively developing this feature. I know that support for hourly loans is needed first, and that there is an RFC on the koha community wiki written by Ian. Is this feature in active development, or has it stalled? Thanks, Kyle http://www.kylehall.info Mill Run Technology Solutions ( http://millruntech.com ) Crawford County Federated Library System ( http://www.ccfls.org ) Meadville Public Library ( http://www.meadvillelibrary.org )

2 2

Re: [Koha-devel] [Koha-patches] [PATCH 5/5] Bug 6298 : Add optional dependency on Gravatar::URL 1.03
by Robin Sheat 09 May '11

09 May '11

However, the version now in the koha debian repositories should work (it's at 1.04.) Francois Marier schreef op zo 08-05-2011 om 11:20 [+1200]: > This CPAN module is needed for the ShowReviewerPhoto functionality. > > Unfortunately the version in Squeeze (1.02) is not sufficient so it > has to be installed from CPAN: > > sudo apt-get install libnet-dns-perl libtest-warn-perl > sudo cpan Gravatar::URL > > Signed-off-by: Francois Marier <francois(a)debian.org> > --- > C4/Installer/PerlDependencies.pm | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm > index 576dde4..63d14a6 100644 > --- a/C4/Installer/PerlDependencies.pm > +++ b/C4/Installer/PerlDependencies.pm > @@ -479,6 +479,11 @@ our $PERL_DEPS = { > 'required' => '1', > 'min_ver' => '2.22', > }, > + 'Gravatar::URL' => { > + 'usage' => 'Photos in OPAC reviews', > + 'required' => '0', > + 'min_ver' => '1.03', > + }, > }; > > 1; -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D

1 0

Enabling SSL for Koha staff view
by Altaf Mahmud 07 May '11

07 May '11

Hello, I'm trying to implement SSL in my Koha server running on Debian 6.0 (squeeze). I've implemented it for my OPAC view, I've created another file 'koha-ssl' in ../apache2/sites-available/ directory and enabled it. I've edited ../apache2/sites-available/koha like following: NameVirtualHost *:80 <VirtualHost 127.0.1.1:80> ..... ..... </VirtualHost> And ../apache2/sites-available/koha-ssl like following: NameVirtualHost *:443 <VirtualHost 127.0.1.1:443> ..... SSLEngine On SSLCertificateFile /etc/ssl/certs/ssl-cert-snakeoil.pem SSLCertificateKeyFile /etc/ssl/private/ssl-cert-snakeoil.key ..... </VirtualHost> Now https://127.0.1.1/ is showing the OPAC. But I can't figure it out how to implement it for staff-view <VirtualHost 127.0.1.1:8080> Request for port 80 is redirecting to port 443, how can I do that for port 8080? In fact, I don't have any prior idea on doing this; a descriptive suggestion is appropriate for me. Thanks. -- Altaf Mahmud System Programmer Ayesha Abed Library BRAC University Bangladesh.

1 0

[PATCH 1/2] Bug 6298 : Add avatar picture of comment author in OPAC
by Francois Marier 06 May '11

06 May '11

Use Libravatar::URL to pull the avatar picture for comment authors if we have an email address for them. Signed-off-by: Francois Marier <francois(a)debian.org> --- koha-tmpl/opac-tmpl/prog/en/css/opac.css | 3 +++ koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 3 +++ opac/opac-detail.pl | 10 ++++++++++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css index aa295c9..a1e1663 100644 --- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css +++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css @@ -1873,6 +1873,9 @@ a#MARCview, a#MARCviewPop, a#ISBDview, a#Normalview, a#Fullhistory, a#Briefhisto #comments .yours { background-color : #effed5; } +.commentline .avatar { + float : right; +} #comments #addcomment { margin : 0 -1em -1em -1em; padding : .3em 1em; diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index c063bb3..cfd23d0 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -675,6 +675,9 @@ YAHOO.util.Event.onContentReady("furtherm", function () { [% ELSE %] <div class="commentline"> [% IF ( ShowReviewer ) %] + [% IF ( review.avatarurl ) %] + <img class="avatar" src="[% review.avatarurl %]" height="80" width="80"/> + [% END %] <h5> Comment by [% review.title %] diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 3e4c76c..cf63a17 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -295,6 +295,13 @@ $template->param( ocoins => GetCOinSBiblio($biblionumber), ); +my $libravatar_available = 0; + +eval 'use Libravatar::URL'; +if (! $@) { + $libravatar_available = 1; +} + my $reviews = getreviews( $biblionumber, 1 ); my $loggedincommenter; foreach ( @$reviews ) { @@ -303,6 +310,9 @@ foreach ( @$reviews ) { $_->{title} = $borrowerData->{'title'}; $_->{surname} = $borrowerData->{'surname'}; $_->{firstname} = $borrowerData->{'firstname'}; + if ($libravatar_available and $borrowerData->{'email'}) { + $_->{avatarurl} = libravatar_url(email => $borrowerData->{'email'}, https => $ENV{HTTPS}); + } $_->{userid} = $borrowerData->{'userid'}; $_->{cardnumber} = $borrowerData->{'cardnumber'}; $_->{datereviewed} = format_date($_->{datereviewed}); -- 1.7.4.4

1 1

Undocumented Behaviour in C4::Dates
by Colin Campbell 04 May '11

04 May '11

Interesting, C4::Dates allows you to instantiate a Date with a day value of 00. Not sure why you really want this behaviour but nowhere does it actually document what this means. We assume that this is intended behaviour as t/Dates.t actually confirms it. But there's no documentation of what it does to a date. If you look at the output from t/Dates.t creating a date with 0/1/1952 (I'm using dmy here) returns a formatted version of 31/12/1951. i.e. ) has a "kind of -1" effect Odd? Confused? Poor Interface? C. -- Colin Campbell Chief Software Engineer, PTFS Europe Limited Content Management and Library Solutions +44 (0) 845 557 5634 (phone) +44 (0) 7759 633626 (mobile) colin.campbell(a)ptfs-europe.com skype: colin_campbell2 http://www.ptfs-europe.com

3 3

Weekly stuff to sign off email
by Chris Cormack 03 May '11

03 May '11

Hi All Ian (the QA manager) and I thought for 3.6.x it might be an idea to send an email each week, highlighting some bugs we would love people to look at. This is not to say, you shouldn't try to sign off all of them :-) But I will attempt to highlight ones that are critical, major, or just cool. Bug 4993 ldap search always uses anonymous when binding by auth Bug 5683 link_bibs_to_authorites.pl can corrupt records Bug 5995 Glitch with checkauth Bug 5724 Sometimes deletes aren't processed correctly by rebuild zebra Bug 5093 JS in IE8 when choosing authority record Bug 6034 Sheliving cart feature can wipe shelving location Bug 5872 Enhancemens to circulation management Bug 5905 Partial fine payments Bug 5184 Upgrade Jquery 1.4.2 Bug 5605 Add Support for SIP Fee Paid Message Bug 5572 refinements to function merge sub merge in C4::AuthoritiesMarc Bug 5009 add autocomplete="off" to borrowernumbers and barcode forms This is just a selection I pulled out, if you have time take a look, the earlier they get checked, the easier they are to merge :) Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand

3 2

related searches?
by Marcel de Rooy 02 May '11

02 May '11

Hi, Just a dumb question. grep -r -l --exclude=*.po "related_search" * on current master gives me 5 five template files: koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc koha-tmpl/opac-tmpl/prog/nl-NL/includes/opac-facets.inc koha-tmpl/opac-tmpl/prog/nl-NL/includes/masthead.inc koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc Apparently, the template vars related, related_search are not used (anymore) ? Does anyone know about it? Marcel

1 0