September 2014 - Koha-devel - lists.koha-community.org

Koha and DBIC
by Kyle Hall 17 Sep '14

17 Sep '14

As discussed in #koha, I think we are not using DBIC as well as we could. Right now we are only using it to replace hand written SQL queries. I would propose the following: 1) Allow find and simple searches in pl. 2) If a search is used more than once, it should be a ResultSet method 3) If a subroutine operates on a single table row, it should be a Result method 4) If a subroutine operates on a single table, it should be a ResultSet method 5) Any operation that works on tables linked by key constraints should take advantage of those DBIC relationships and also In this way we can do things like: $borrower->is_debarred or $borrower->has_overdues or @borrowers = $borrower->guarantees() Any search can be a method in the ResultSet such as $borrower->issue()->overdue_issues(); or my @records_with_holds = $schema->resultset('Biblio')->with_holds() I think in the long run this will make or code far more readable, testable, and efficient. What do you think? Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) Mill Run Technology Solutions ( http://millruntech.com )

11 46

Re: [Koha-devel] problem to perform a simple query (Adnier Rosello)
by Adnier Roselló Carrazana 17 Sep '14

17 Sep '14

Robin: apology not specify in my previous mail that my koha version is 3.0.6, which has a preference variable to not use the zebra (NoZebra), so the search of bibliographic records are handled directly by MySQL, grateful by the response, I hope to clarify the problem, Greetings Ad ----- Mensaje original ----- Send Koha-devel mailing list submissions to koha-devel(a)lists.koha-community.org To subscribe or unsubscribe via the World Wide Web, visit http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel or, via email, send a message with subject or body 'help' to koha-devel-request(a)lists.koha-community.org You can reach the person managing the list at koha-devel-owner(a)lists.koha-community.org When replying, please edit your Subject line so it is more specific than "Re: Contents of Koha-devel digest..." Today's Topics: 1. Re: Koha and DBIC (Marcel de Rooy) 2. Re: problem to perform a simple query (Robin Sheat) 3. VIAF and Koha 3.16.x (Partha Mukhopadhyay) ---------------------------------------------------------------------- Message: 1 Date: Mon, 15 Sep 2014 19:11:35 +0000 From: Marcel de Rooy <M.de.Rooy(a)rijksmuseum.nl> To: Koha Devel <koha-devel(a)lists.koha-community.org> Subject: Re: [Koha-devel] Koha and DBIC Message-ID: <809BE39CD64BFD4EB9036172EBCCFA31423D34C8(a)S-MAIL-1B.rijksmuseum.intra> Content-Type: text/plain; charset="iso-8859-1" > I am troubled by the idea that we should wrap all our dbic classes in yet more classes. Every example I've seen of this has more code by a factor of almost 10. I don't know if Koha is so complex that it requires a repository pattern. I think that it would require rewriting Koha. This changeover might just be too complex for us. > How much more difficult will this be for developers, and how much more overhead will it require if we wrap our objects in more objects? We'd have to fetch the Row objects, wrap them in KohaRow objects, wrap those in a KohaRowSet, and return them. Certainly, but far more complicated. I would say: Leave all storage related actions in Koha::Schema. KohaRow does not make sense to me. Furthermore, define the objects that actually have 'real' business logic and put that in some Koha::Object. Marcel

2 1

VIAF and Koha 3.16.x
by Partha Mukhopadhyay 16 Sep '14

16 Sep '14

2 1

Reminder: Koha Developer IRC meeting 16 September 2014 at 15:00 and 22:00 UTC
by Owen Leonard 16 Sep '14

16 Sep '14

There are two developer meetings today: 16 September 2014, 15UTC http://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+Developers+IR… 16 September 2014, 22UTC http://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+Developers+IR… The agenda is here: http://wiki.koha-community.org/wiki/Development_IRC_meeting,_16_September_2… I hope you can make it, Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

1 0

problem to perform a simple query
by Adnier Roselló Carrazana 16 Sep '14

16 Sep '14

hi all, I need to know if the search system koha have any character limitation to perform a simple query (without using zebra), I'm doing a search where the record title has 180 characters and the system does not respond so the browser (firefox) closes the connection, thanks for everything, I hope there is some solution, Greetings Concurso "Mi selfie por los 5". Detalles en http://justiciaparaloscinco.wordpress.com

2 2

KohaCon14
by Tomas Cohen Arazi 10 Sep '14

10 Sep '14

Hi, if you're coming to KohaCon14 please don't forget to fill your data here http://wiki.koha-community.org/wiki/Who_is_arriving_when at least the arrival time so we know you're arriving, safe adn happy in Cordoba. Regards To+ -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

1 0

TestBuilder - Pros & Cons
by Jonathan Druart 10 Sep '14

10 Sep '14

Hello developers, Yesterday the TestBuilder case has been discussed during the meeting [1] I will try to list the pros and cons points as objectively as I can: Pros: - the module meets a need: simplify the writing of tests Cons: - it's another tool to learn - it should be covered by unit tests - it should be maintain - it hides the way how it works under the hood - it is not hard to create required rows in dependent tables That was the objective part. Now, since I would like to see TestBuilder [2] integrated into master, I will try to provide arguments. The need is to simplify the writing of tests, especially for the acquisition module. An easy goal could be to be data agnostic, random data could be generated as the beginning of all test files. So yes, it is another tool to learn, but the way we are writing tests for now is not elegant and maintain them will be a pain. The tool has been provided (by Yohann) with its own unit tests, no need to write them (hopefully!). The api is quite easy to learn (only 2 public methods: build and clear). I don't think this module will hide "how it works under the hood", the guys who will use them are going to add/write/rewrite a new routine and already know the DB structure. I would like to add that I don't think this module should be mandatory. A developer should be free not to use to it. Some examples have already been provided, which will help developers who want to use it. I would add that it is not "hard" to manually generate dependencies, just a waste of time. And it adds useless complexity in the tests files. When you have to create a library, a bookseller, a basket and a biblio to create an order, sometime for 1 test, it does not encourage developers to write tests. I think the best example is bug 12604 [3]. It is the same if you want to issue an item to a patron, you will have to create a library, a patron category, a patron, a biblio and the item. Developers are lazy, they just want to tell "give me a patron and an item!". I am sure this is certainly not the best implementation. It has been done by an intern in 2 weeks. He didn't know perl or Koha 1 month before. Yohann provided a very good work. Moreover he based his work on a python library doing the same thing (I don't remember the name :-/) Note that some other modules already exist [4], but they won't work out of the box like TestBuilder. Maybe for our next intern :) Cheers, Jonathan Ps: to keep in mind whose this module will be useful, you can run the following command: python gitinspector.py ~/src --since=2013-01-01 --file-types=t It will generate statistics for test files by author since 2013 (for busy guys, you can see the result here: http://paste.koha-community.org/199) [1] http://wiki.koha-community.org/wiki/Development_IRC_meeting,_9_September_20… [2] Bug 12603 - TestBuilder - Module to simplify the writing of tests [3] Bug 12604: refactoring close_reopen_basket.t with TestBuilder [4] http://search.cpan.org/dist/DBIx-Class-Fixtures/lib/DBIx/Class/Fixtures.pm or Test::DBIx::Class:Factory

1 1

What purpose do the 003 and 005 tageditor popup anchors serve?
by Indranil Das Gupta 08 Sep '14

08 Sep '14

Hi, I noticed that 003 and 005 tageditors do not actually have a popup to back them up. That unlike LDR (000), 007, 008 the tags 003 and 005 do not call any window.open function and their respective Clictag_<number> functions are blank. what is the purpose for having these tageditor links around for these two? curious to know :) -- Indranil Das Gupta Phone : +91-98300-20971 Blog : http://indradg.randomink.org/blog IRC : indradg on irc://irc.freenode.net Twitter : indradg -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=- Please exchange editable Office documents only in ODF Format. No other format is acceptable. Support Open Standards. For a free editor supporting ODF, please visit LibreOffice - http://www.documentfoundation.org

2 4

problem with the title field in MARC 21
by Edisnel Carrazana Castro 04 Sep '14

04 Sep '14

Greetings to all. I have problems with the length of the title field (245-a) in MARC 21. When a very long title is entered, the application does not save the record in the database. I am using koha 3.0.6. Any help would come fine, thanks Concurso "Mi selfie por los 5". Detalles en http://justiciaparaloscinco.wordpress.com

2 1

Koha Community Newsletter: August 2014
by Koha News 03 Sep '14

03 Sep '14

Fellow Koha users: The Koha Community Newsletter for August 2014 is here: http://koha-community.org/koha-community-newsletter-august-2014/ Many thanks to all the folks who submitted articles and news to this month's newsletter. Please feel free to email us with any corrections or suggestions. Thanks! Chad Roseburg Joanne Dillon Editors, Koha Community Newsletter

1 0