October 2015 - Koha-devel - lists.koha-community.org

Feature slush about bug 7736 -EDI enhancement
by Tajoli Zeno 27 Oct '15

27 Oct '15

Hi to all, I'm working on sign-off bug 7736, to insert EDI support in Koha Acquisition. The bug add many files abut change in light way templates of Acqi. About C4 and cgi: C4/Acquisition.pm | 6 +- C4/Installer/PerlDependencies.pm | 10 + acqui/basket.pl | 77 ++ acqui/basketgroup.pl | 18 +- acqui/invoices.pl | 4 +- So it doesn't interfer much with other develops. So, can I use also tomorrow (27/10, CST time) to insert this enhancement in 3.22 ? Bye Zeno Tajoli -- Zeno Tajoli /Dipartimento Sviluppi Innovativi/ - Automazione Biblioteche Email: z.tajoli(a)cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)

1 1

Bug 7736 and t/db_dependent/TestBuilder.t
by Tajoli Zeno 27 Oct '15

27 Oct '15

Hi to all, working on bug 7736, after insert code and update db, I find problem with this test: prove t/db_dependent/TestBuilder This is the error that I receviee: t/db_dependent/TestBuilder.t .. 3/41 DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`edifact_messages`, CONSTRAINT `emfk_basketno` FOREIGN KEY (`basketno`) REFERENCES `aqbasket` (`basketno`)) [for Statement "DELETE FROM `aqbasket` WHERE ( `basketno` = ? )" with ParamValues: 0='37'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1593. DBIx::Class::ResultSet::delete_all(): Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`edifact_messages`, CONSTRAINT `emfk_basketno` FOREIGN KEY (`basketno`) REFERENCES `aqbasket` (`basketno`)) at /production/develops/t/lib/TestBuilder.pm line 94 DBIx::Class::Carp::__ANON__(): A DBIx::Class::Storage::TxnScopeGuard went out of scope without explicit commit or error. Rolling back. at /usr/share/perl5/DBIx/Class/Storage/TxnScopeGuard.pm line 132 # Looks like you planned 41 tests but ran 35. # Looks like your test exited with 255 just after 35. t/db_dependent/TestBuilder.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 6/41 subtests Test Summary Report ------------------- t/db_dependent/TestBuilder.t (Wstat: 65280 Tests: 35 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 41 tests but ran 35. Files=1, Tests=35, 9 wallclock secs ( 0.04 usr 0.01 sys + 7.54 cusr 0.24 csys = 7.83 CPU) Result: FAIL The bug 7736 add 3 table to Koha: edifact_ean table vendor_edi_accounts table edifact_messages vendor_edi_accounts with does constraints CREATE TABLE IF NOT EXISTS vendor_edi_accounts ( ... CONSTRAINT vfk_vendor_id FOREIGN KEY ( vendor_id ) REFERENCES aqbooksellers ( id ), CONSTRAINT vfk_shipment_budget FOREIGN KEY ( shipment_budget ) REFERENCES aqbudgets ( budget_id ) ... ) CREATE TABLE IF NOT EXISTS edifact_messages ( ... CONSTRAINT emfk_vendor FOREIGN KEY ( vendor_id ) REFERENCES aqbooksellers ( id ), CONSTRAINT emfk_edi_acct FOREIGN KEY ( edi_acct ) REFERENCES vendor_edi_accounts ( id ), CONSTRAINT emfk_basketno FOREIGN KEY ( basketno ) REFERENCES aqbasket ( basketno ) ... ) ALTER TABLE aqinvoices ADD COLUMN message_id INT(11) REFERENCES edifact_messages( id ); ALTER TABLE aqinvoices ADD CONSTRAINT edifact_msg_fk FOREIGN KEY ( message_id ) REFERENCES edifact_messages ( id ) ON DELETE SET NULL; CREATE TABLE IF NOT EXISTS edifact_ean ( ... CONSTRAINT efk_branchcode FOREIGN KEY ( branchcode ) REFERENCES branches ( branchcode ) ... ) The full update done by bug 7736 is here: https://github.com/colinsc/koha/blob/edifact_snapshot_150911/installer/data… As I see there is a problem on about this costraint of table edifact_messages: CONSTRAINT emfk_basketno FOREIGN KEY ( basketno ) REFERENCES aqbasket ( basketno ) Reading the code of t/db_dependent/TestBuilder.t I don't understand if there is problem on how the constraint is done or I need to change TestBuilder.t. Do you have any idea ? Where can i find more info about TestBuilder.t ? Bye Zeno Tajoli -- Zeno Tajoli /Dipartimento Sviluppi Innovativi/ - Automazione Biblioteche Email: z.tajoli(a)cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)

2 2

koha-qa - new check on css/less
by Jonathan Druart 25 Oct '15

25 Oct '15

Hi devs, It appears than opac.css and opac.less have diverged, it should not happen. I have added a new check in the koha-qa tools, please update. Tomas is going to push a patch to fix the problem on master. Cheers, Jonathan

3 4

Forgot to bring this up in the dev meeting today...
by Barton Chittenden 23 Oct '15

23 Oct '15

25006: nekls: longoverdue.pl development request -- changing overdue items to lost status, with patron category restrictions After bug xxxx was pushed to master, Heather and I had the following conversation: > Hooray! Now, comes the big logistical question -- what's the process > > to get this added to our server early? (but I don't want it yet -- we > > have to change some things here first). > > Heather, I'm going to bring that up in our dev meeting on Thursday. We've > been talking a lot about scheduling upgrades, and I know that Larry has > been working with you on your upgrade path -- we can discuss where > deploying this patch fits in with that. > > So... what do we want to do with this? --Barton

1 1

Translation very difficult if use some tags among text paragraph in html
by Hector Castro 23 Oct '15

23 Oct '15

Hi Koha Developers I don't know if we can use another style when write down paragraphs; some html tags among paragraph, for example if we use <code> <abbr>, , <acronym> etc., are split in different entries in the po files, and this do the translation very hard, for example this bug < http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671> In the new 3.22 exists another example: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt lines 262-264 <td>You are missing the <upload_path> entry in your koha-conf.xml file. Please add it, pointing to the configured file upload directory for your Koha instance. Also note that you need to properly set the OPACBaseURL preference for the file upload plugin to work.</td> The generated PO file #: intranet-tmpl/prog/en/modules/about.tt:255 #: intranet-tmpl/prog/en/modules/about.tt:262 #, c-format msgid "You are missing the " msgstr "Falta la entrada " #: intranet-tmpl/prog/en/modules/about.tt:255 #: intranet-tmpl/prog/en/modules/about.tt:262 #, c-format msgid "<upload_path>" msgstr "<upload_path>" #: intranet-tmpl/prog/en/modules/about.tt:262 #, c-format msgid "" "entry in your koha-conf.xml file. Please add it, pointing to the configured " "file upload directory for your Koha instance. Also note that you need to " "properly set the " msgstr "" #: intranet-tmpl/prog/en/modules/about.tt:264 #, c-format msgid "OPACBaseURL" msgstr "OPACBaseURL" #: intranet-tmpl/prog/en/modules/about.tt:264 #, c-format msgid "preference for the file upload plugin to work. " msgstr "" Finally this end up in a nonsensical translation IMHO, If developers can really take into consideration not to use this kind of paragraphs and -if possible- modify the coding guidelines in wiki page to reflect this. Or if there are another option to do life easy for translators?... Regards -- Atte, Hector Eduardo Castro Avalos

1 0

Disable MARC field edit
by akafortes 22 Oct '15

22 Oct '15

Is there a way to disable manual editing of a MARC field during cataloguing or when editing a MARC record? I have created a script to add the user that added a MARC record and I was wondering if there is a way to disable manual editing of that field and only allow the script to add values. Something similar to when you lock a field and force it to use authorities. -- View this message in context: http://koha.1045719.n5.nabble.com/Disable-MARC-field-edit-tp5857982.html Sent from the Koha-devel mailing list archive at Nabble.com.

1 0

Delay for 3.20.5 release
by Chris Cormack 22 Oct '15

22 Oct '15

Káà'rọ̀ It's the 22nd today here in Nigeria, but its also the cultural day for Kohacon. So I am planning to do the release either during the hackfest, or if I am too busy then, when I get back to NZ Chris

1 0

IMPORTANT: Plack stress test server
by Tomas Cohen Arazi 21 Oct '15

21 Oct '15

Hi everyone, as we mentioned on yesterday's dev meetings, ByWater provided a VM with good specs with the idea of testing Plack on packages in real life. I've set a plack-enabled instance on the server, with all the default data loaded, and created 100 superlibrarian users named test_1, test_2 and so on. You can login with the user name as password. The goal is to find all the bugs :-D So feel free to go and break it. The compromise is that you HAVE to fill a bug for each thing you broke or found broken :-D Bonus points if you provide a patch ;-) Remember you can use the kohadevbox branch that was created to test this on your box [1] (suitable for writing patches). The instance can be accessed on: Intranet: http://test-intra.plack.bywatersolutions.com/ OPAC: http://test.plack.bywatersolutions.com/ PS: It is set to use the indexer daemon with a 5 seconds frecquency, please try it, and try cataloguing, importing records, etc. [1] http://comments.gmane.org/gmane.education.libraries.koha.devel/12362 -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

5 12

Reminder: feature slush approaching
by Tomas Cohen Arazi 20 Oct '15

20 Oct '15

Hi everyone, just a gentle reminder: feature slush was set to October 26th on the last dev meeting [1]. When I get to a computer next monday, I will take a screenshot of the PQA queue and enhancements or features not on that list won't be elegible for 3.22. Regards [1] http://meetings.koha-community.org/2015/development_irc_meeting_14_october_… -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

1 0

URGENT: Feedback on bug 15005
by Tomas Cohen Arazi 15 Oct '15

15 Oct '15

While the patches fix the bug, we really need feedback on the approach. Places like this http://advent.plackperl.org/page/2/ (look for SCRIPT_NAME) recommend we don't hardcode paths, but use SCRIPT_NAME and PATH_INFO instead. The problem is we are not being able to make the reverse proxy config pass the right data and/or translate it for rendering. Link to the bug, with screenshot and explanation: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 This affects our plack integration. -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

1 0