December 2015 - Koha-devel - lists.koha-community.org

Get rid of item-level_itype?
by Jonathan Druart 23 Dec '15

23 Dec '15

Hi devs, Friday is a good day for this kind of questions, fasten your seat belt for a time travel. As many of you know, the item type is not correctly managed all around the different Koha modules. Sometimes it's, sometimes it's not. The main issue is that we deal with it at too many places and the code is not clean/centralised at all. So I have searched for previous discussions on this subject and I have found this "Abandoned RFC" on the wiki : http://wiki.koha-community.org/wiki/Mandate_item-level_circulation_rules_RFC filled from this koha-devel thread http://lists.koha-community.org/pipermail/koha-devel/2008-October/031144.ht… The questions are: 1/ Is this still valid? 2/ Is there something missing in the different steps described? 3/ Does someone have some other suggestions to do? I would be happy to provide this change but first I would like to get confirmation about it and get people involved in signoffing/QAing the possible patch set. Cheers, Jonathan

9 11

Perldoc website
by Nicolas Legrand 22 Dec '15

22 Dec '15

Hey, I'm a bit puzzled by the web perldoc, some changes are not effective on master. I bumped on this one: http://perldoc.koha-community.org/C4/Reserves.html#CanItemBeReserved CanItemBeReserved $error = &CanItemBeReserved($borrowernumber, $itemnumber) This function return 1 if an item can be issued by this borrower. The return values has changed in commit 51f0a0b7229c1e76699708a548a9e3e68c9953ad : http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=51f0a0b7229c1e7… $canReserve = &CanItemBeReserved($borrowernumber, $itemnumber) if ($canReserve eq 'OK') { #We can reserve this Item! } @RETURNS OK, if the Item can be reserved. ageRestricted, if the Item is age restricted for this borrower. [...] Cheers, -- Nicolas Legrand Administration technique et développements du système de gestion de la bibliothèque Bibliothèque universitaire des langues et civilisations 65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 18 22 www.bulac.fr

2 2

ElasticSearch
by Bouzid Fergani inLibro.com 18 Dec '15

18 Dec '15

Hi all, Right now, I work into ElasticSearch project. I applied all patch proposed by community in Catalyst, I think lots work left to do. Mappings and analyzers due out code and search do not simply full text. ElasticSearch propose lots mechanism for search and analyzer mode. Is what I can attach patch on catalyst or no? In my opinion, if we put in place ElasticSearch for all Koha search, it'll be a major advance. Best regards. Bouzid.

2 1

Sting Freeze for 3.20.x
by Frédéric Demians 18 Dec '15

18 Dec '15

Hi, Same as others, Julian & Liz, and as said in the subject. Season Greetings to all of you. Frédéric

1 0

String Freeze for 3.18.x
by Liz Rea 18 Dec '15

18 Dec '15

Hi, I'm calling a string freeze on the 3.18.x line in order for the translators to do their work. Hope you all have lovely holidays! Liz -- -- Liz Rea Catalyst.Net Limited Level 6, Catalyst House, 150 Willis Street, Wellington. P.O Box 11053, Manners Street, Wellington 6142 GPG: B149 A443 6B01 7386 C2C7 F481 B6c2 A49D 3726 38B7

1 0

Re: [Koha-devel] String freeze for 3.22.1
by Brendan Gallagher 17 Dec '15

17 Dec '15

Hi All - So when I got back from China (I was in Beijing for the worst pollution imaginable), I ended up getting pneumonia. I've been sleeping pretty much all week, so that is why you haven't seen much RM action. Once I am on my feet I will be attending to these. Thanks for the list Marc. Are any of those critical for a 3.22.1 release? I will do what I can. Once the antibiotics take care of me - I'll be back full force. Thanks, Brendan On Thu, Dec 17, 2015 at 6:58 AM, Paul Poulain <paul.poulain(a)biblibre.com> wrote: > They must be pushed to master first, cc-ing RM, in case he misses your > email ! > > Le 17/12/2015 15:32, Marc Véron a écrit : > >> Hi Julian, >> >> We have some translatability patches passed QA, it would be great to have >> them in the next release: >> >> 15361 Translatability: Fix issue on Administration Columns settings >> 15345 Translatability: fix issue in facets (Availability') >> 15340 Translatability: fix issue with 'or choose' splitted by <strong tag >> 15346 Translatability: fix sentence splitting issue in memberentrygen.tt >> 15301 Translatability: branchtransfers.tt: Remove ambiguous "To" and >> fix splitted sentence. >> 15233 Cataloging subfield editors: Clean up html and streamline text for >> better translatability >> 15300 Translatability: Replace ambiguous 'From' and 'To' in >> members-update.tt >> 15238 Better translatability for Installer Step 1 >> 15228 Patron card batches - Improve translatability >> 15236 Better translatibility in "Connect biblio.biblionumber to a MARC >> subfield" >> >> Thanks and regards >> Marc Véron >> >> >> >> >> Am 17.12.2015 um 14:59 schrieb Julian Maurice: >> >>> Hi all >>> >>> Koha 3.22.1 will be released in a week, so it's time for string freeze. >>> I won't push patches that have impact on translations until release. >>> >>> >> _______________________________________________ >> Koha-translate mailing list >> Koha-translate(a)lists.koha-community.org >> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-translate >> website: www.koha-community.org >> git: git.koha-community.org >> bugs: bugs.koha-community.org >> > > > -- > Paul Poulain, Associé-gérant / co-owner > BibLibre, Services en logiciels libres pour les bibliothèques > BibLibre, Open Source software and services for libraries > > -- --------------------------------------------------------------------------------------------------------------- Brendan A. Gallagher ByWater Solutions CEO Support and Consulting for Open Source Software Installation, Data Migration, Training, Customization, Hosting and Complete Support Packages Headquarters: Santa Barbara, CA - Office: Redding, CT Phone # (888) 900-8944 http://bywatersolutions.com info(a)bywatersolutions.com

1 0

Re: [Koha-devel] DateUtils / Zebra
by Paul A 16 Dec '15

16 Dec '15

At 10:49 PM 12/14/2015 -0300, Tomas Cohen Arazi wrote: >Take a look at commitÂ b529ca00e0cac093fc32a1d123cdbcc84582c155 for >Koha/DateUtils.pm and commitÂ 091a74de4c0fb6b0ff948eb716808dfc009a1207 for >C4/Search.pm Tomas (and Philippe B.), Thank you both very much ... problem cured. For the record, applying the commit above fails with 3.8 (both .5 and .24) [Note 1] However, using the DateUtils.pm from 3.16.13 (I happened to have the tar easily available) works flawlessly in 3.8.5 and 3.8.24 using either Perl 5.014002 or Perl 5.018002. There is actually an added benefit: rebuild_zebra gains an approx 20% time improvement under Perl 5.14 under our test conditions. While recognizing that 3.8.24 is unsupported (no maintainer?), it is still fairly recent (released 2014-06-04) and it would be somewhat trivial to put the 3.16.13 version of DateUtils into it. Again with my thanks -- Paul [Note 1: -- there are other diff's to the .pm (shown by the line numbering) and modding the relevant lines gives rise to supplemental errors such as "Global symbol "$dateonly" requires explicit package name at /usr/share/koha/lib/Koha/DateUtils.pm line 117 and "Global symbol "$time" requires explicit package name at /usr/share/koha/lib/Koha/DateUtils.pm line 118", and spills over into Reserves.pm line 40, Circulation.pm line 27, Search.pm line 28, AuthoritiesMarc.pm line 24, etc...] >Regards >Tomas > >2015-12-14 17:10 GMT-03:00 Paul A <paul.a(a)navalmarinearchive.com>: >At 10:41 PM 12/13/2015 -0300, Tomas Cohen Arazi wrote: >>You are running an antique version of Koha. And it used to use >>experimental features from Perl (that were removed later). It doesn't >>hurt to have those warnings anyway. > >Tomas -- tnx for the reply. > >Do you remember if this was a change to rebuild_zebra.pl or to >DateUtils.pm? As I said below, I couldn't find any documentation on the >subject -- and I'd like to look into getting rid of the warnings. > >Thanks -- Paul > > >>2015-12-13 20:09 GMT-03:00 Paul A <paul.a(a)navalmarinearchive.com>: >>(I found one email, no response, from 21 May 2014 on this subject; can't >>find anything 'DateUtils' with either 'Zebra' or 'catalog' in >>bugs.koha-community.org.) >>It's extremely rare nowadays that we do a complete re-index on the >>production servers, but I did one today after a direct (naughty me) tweak >>to MySQL (frameworks/itemtypes) to avoid a lengthy sandbox<==>production >>to and fro. I got the following: >>koha_account@my_production:/usr/share/koha$ >>./bin/migration_tools/rebuild_zebra.pl -b -r -v -x >>given is experimental at /usr/share/koha/lib/Koha/DateUtils.pm line 114. >>when is experimental at /usr/share/koha/lib/Koha/DateUtils.pm line 115. >>when is experimental at /usr/share/koha/lib/Koha/DateUtils.pm line 118. >>when is experimental at /usr/share/koha/lib/Koha/DateUtils.pm line 121. >>Smartmatch is experimental at /usr/share/koha/lib/C4/Search.pm line 492. >>Useless use of '\'; doesn't escape metacharacter '(' at >>/usr/share/koha/lib/C4/AuthoritiesMarc.pm line 917. >>Just thought I'd ask if anyone has any thoughts on this as I'm fairly >>sure I've never seen it before -- note, it doesn't *appear* to hurt anything. >>Tnx and regards -- Paul >>_______________________________________________ >>Koha-devel mailing list >>Koha-devel(a)lists.koha-community.org >>http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>website : http://www.koha-community.org/ >>git : http://git.koha-community.org/ >>bugs : http://bugs.koha-community.org/ >> >> >> >> >>-- >>TomÃÂ¡s Cohen Arazi >>Theke Solutions (http://theke.io) >>Ã¢ +54 9351 3513384 >>GPG:Ã B76C 6E7C 2D80 551A C765 Ã E225 0A27 2EA1 B2F3 C15F > >--- >Maritime heritage and history, preservation and conservation, >research and education through the written word and the arts. ><http://NavalMarineArchive.com> and <http://UltraMarine.ca> > >_______________________________________________ >Koha-devel mailing list >Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : http://www.koha-community.org/ >git : http://git.koha-community.org/ >bugs : http://bugs.koha-community.org/ > > > > >-- >TomÃ¡s Cohen Arazi >Theke Solutions (http://theke.io) >â +54 9351 3513384 >GPG:Â B76C 6E7C 2D80 551A C765 Â E225 0A27 2EA1 B2F3 C15F --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

1 0

The needs signoff queue is overloaded
by Jonathan Druart 16 Dec '15

16 Dec '15

Hi devs, The number of patches waiting for a signoff is around 220, which is really high to make things fluid. I know that everybody has the same issue and that it is part of my job to make it down but there is not a lot activities from other QAers. I am limited when signoffing patches as it makes me loose my QA token, so I cannot help too much. This month there were only 2 different QAers: Katrin and me so far. One of the main issue is that this queue is processed as a LIFO queue, which is, given the number of signoffers, the worst queue management we can offer. Please take the time to signoff a couple of patches per week, and send love to the old patches :) I have personally submitted some works to refactor and/or improve the code. I have focused on the admin scripts: Bug 14828 - Move the item types related code to Koha::ItemTypes Bug 15293 - Move the C4::Branch related code to Koha::Libraries Bug 15379 - Move the authority types related code to Koha::Authority::Type[s] Bug 15084 - Move the currency related code to Koha::Acquisition::Currenc[y|ies] Bug 13726 - Koha::Acquisition::Bookseller should use Koha::Object Note that the last one depends on the Tax rewrite patch set, which is (still) pending for QA. The goal of these patches is to 1. propose a common way to write simple scripts, 2. add tests where they were missing, 3. (really) start the move to the Koha namespace. The last is the most important as we can hope having a new Object Oriented Koha API in the next months. During the last years the project has suffered not to get funding for these kind of refactoring/rewrite work. Fortunately, I can now focus on that (thanks to Paul, Brendan and Nick), but, contrary to my earlier belief, these kinds of patches don't appeal to signoffers. What I can understand: it is not interesting to test that a patch set does not introduce regressions! :) But the thing is that I am stuck in the refactoring process. I know this problem very well and I know that if I continue without having the previous patches pushed, I will have to rebase this work for months/years. I am also afraid not to manage to find signoffers for important bug fixes. For instance Bug 13618 - Prevent XSS in the Staff Client and the OPAC has been written 6 months ago and did not reach the QA queue yet. In the past we have had to provide security release in a rush, because of potential XSS attacks. This patch set propose a global solution, to avoid them completely. I have already told about this patch several times on 1. koha-devel, 2. the bug report and 3. the IRC channel. It will be very hard to maintain it as *a lot* of files are impacted and I am planning to abandon it soon if I have to rebase it several times more. There is a critical one, waiting in the queue for almost 2 months now: Bug 15030 - Certain values in serials' items are lost on next edit Data lost possible... Some of you complain about performance issues, you can note that an omnibus report has been opened Bug 15342 - Performance 3.22 - Omnibus and some patches provided, for discussion, on the dependent bug reports. I know that Christmas is coming and that everybody is super busy, but hopefully 2016 will see an underloaded queue :) Cheers, Jonathan

1 0

Call for Development News: December Newsletter
by kohanews 15 Dec '15

15 Dec '15

Let the community hear what cool things you're working on! Send me some bugs that need testing, sign-offs and user feedback. Suggestions welcome! k o h a news AT gmail dot com Thank you! -- Chad Roseburg Editor, Koha Newsletter

1 0

Call for News: December Newsletter
by kohanews 15 Dec '15

15 Dec '15

Fellow Koha users ~ I'm collecting news for the December newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events -- **** one month back is the cut-off ***. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section.

1 0