June 2015 - Koha-devel - lists.koha-community.org

C4::Input
by Mark Tompsett 22 Jun '15

22 Jun '15

Greetings, While looking at bug 9006, I came across C4::Context->prepare in C4::Input. So, I just noticed that this checkdigit routine seems unused, and perhaps all of C4::Input could be removed. What do you think? Feedback and thoughts sought. GPML, Mark Tompsett

2 1

AGPL
by Mirko Tietgen 20 Jun '15

20 Jun '15

Hello everybody, there has been a short discussion about AGPL as a license for Koha on IRC http://irc.koha-community.org/koha/2015-06-10#i_1687231 I, for one, would welcome our new AGPL overlords -- or at least a discussion about it. I propose to start arguments and all things flame war here and now, and have a mannered summary/discussion (maybe even a vote, depending on what comes out of this) at the July 8 IRC meeting. I have added it to the agenda. Cheers, Mirko -- Mirko Tietgen mirko(a)abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de

1 1

Call for development news: June Newsletter
by kohanews 18 Jun '15

18 Jun '15

Let the community hear what cool things you're working on! Bugs that need testing, sign-offs and user feedback? ...I'll push them in the public's eye. Tips on how to help/contribute perhaps? k o h a news AT gmail dot com Thank you! -- Chad Roseburg Editor, Koha Newsletter

1 0

Call for news: June Newsletter
by kohanews 18 Jun '15

18 Jun '15

Fellow Koha users ~ I'm collecting news for the June newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria [ UPDATES ]: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events -- **** one month back is the cut-off ***. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the end of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. -- Chad Roseburg Editor, Koha Newsletter

1 0

Question about adding new email/print notifications
by Indranil Das Gupta 15 Jun '15

15 Jun '15

Hi all, When adding a new letter in mandatory/sample_notices.sql, what is the standard practise - add only in the 'en' or also copy it over into all the locale specific sample_notices.sql file? thanks in advance -indranil -- Indranil Das Gupta Phone : +91-98300-20971 Blog : http://indradg.randomink.org/blog IRC : indradg on irc://irc.freenode.net Twitter : indradg -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=- Please exchange editable Office documents only in ODF Format. No other format is acceptable. Support Open Standards. For a free editor supporting ODF, please visit LibreOffice - http://www.documentfoundation.org

2 1

String freeze for Koha 3.20.1
by Chris Cormack 14 Jun '15

14 Jun '15

Hi all It's that time again, string freeze. I will not be pushing any more patches that change templates (unless it is for security reasons) before the release on the 22nd. So once the po files are updated please feel free to start translating Chris

1 0

Issues with DBIx and nested transactions
by Tomas Cohen Arazi 12 Jun '15

12 Jun '15

I've just pushed bug 13967 [1]. It introduces a new package (Koha::Config::SysPrefs) that heavily relies on DBIx::Class to deal with the required CRUD for system preferences. It should be no surprise that the first widespread use of DBIx on Koha's codebase raises problems. Widespread means every call to anything is using it :-D. The point: it noticeably broke lots of our t/db_dependent/ tests. A first guess would point to the package itself. But such doesn't seem to be the case. It is highlighting an underlaying problem in how we deal with the DB: the errors are related to nested transactions taking place, so I would point to our (abuse?) of $dbh->{AutoCommit} = 0 on the tests. Actually, if you pick any db_dependent test that is currently failing on master and set the AutoCommit = 1 you will notice the tests work as expected (with the side effect of altering the DB of course). So, this is a call for all of you, whenever you find some time, to try to figure what's going on and possible solutions to this. I ain't no DBIx expert and will be doing my best but really need your help. Before someone says it: reverting the commits will put us back to the previous state, of course. But it will just hide the problem for a while. [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 5353750 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F

5 7

Plugin development question...
by Mark Tompsett 12 Jun '15

12 Jun '15

Greetings, Patches for Koha have a work flow in terms of sign offs, QA, and then pushing. Is there any kind of process for Plugins? I’m discussing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 with Indranil Das Gupta, and that seems to be the question on our minds. GPML, Mark Tompsett

1 0

Where should I put this?
by Mark Tompsett 11 Jun '15

11 Jun '15

Greetings, One of the bugs I was working on needs a function which is duplicated in a a couple places, so I was thinking it would be best to place it somewhere. The question is where? sub getUserBranchAndCategorycode { my $borrowernumber = 0; my $homebranch = q{}; my $categorycode = q{}; if (C4::Context->userenv) { $borrowernumber = C4::Context->userenv->{'number'} || 0; $homebranch = C4::Context->userenv->{'branch'} || q{}; } if ($borrowernumber) { $categorycode = C4::Members::GetBorrowerCategorycode($borrowernumber); } return { ‘branch’ => $homebranch, ‘categorycode’ => $categorycode }; } GPML, Mark Tompsett

3 3

viewlog bug
by long_sam.tw 11 Jun '15

11 Jun '15

Dear koha floks, I found viewlog bugs. If you turn on [ExtendedPatronAttributes], then view Home › Patrons › Modification log Software error: Undefined subroutine &main::GetBorrowerAttributes called at /usr/share/koha/intranet/cgi-bin/tools/viewlog.pl line 82. Bug fix modify viewlog.pl line 82 change my $attributes = GetBorrowerAttributes( $data->{'borrowernumber'} ); to my $attributes = C4::Members::Attributes::GetBorrowerAttributes( $data->{'borrowernumber'} ); Koha version : 3.16.11, 3.18.7, 3.20 Help me patch viewlogs next release version. Thanks a lot 龍山

3 3