April 2016 - Koha-devel - lists.koha-community.org

Re: [Koha-devel] NorwegianPatronDB
by David Cook 04 Apr '16

04 Apr '16

Hi Martin, Thanks for that info! I have a pause account already, so maybe I should look at tracking down one of those people… I probably won’t have time to work on this for a while, but a long-term fix might be to take over maintenance of that module… I suppose I’m not a bad option as I find encryption interesting and who doesn’t want to maintain a CPAN module? :p David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: Renvoize, Martin [mailto:martin.renvoize@ptfs-europe.com] Sent: Monday, 22 February 2016 7:22 PM To: David Cook <dcook(a)prosentient.com.au> Subject: Re: [Koha-devel] NorwegianPatronDB One can request to take over maintenence of abandoned cpan modules. You need a pause account obviously to start with, then need to find someone to add your commit bit to the repository for the abandoned module. There are a few such people around in the various perl irc channels. On 14 Feb 2016 10:21 pm, "David Cook" <dcook(a)prosentient.com.au <mailto:dcook@prosentient.com.au> > wrote: FYI, if you’re using the Crypt::GCrypt module from CPAN (ie you’re not using a Debian-based system with libcrypt-gcrypt-perl), Koha is probably going to be unable to load Koha::NorwegianPatronDB. The CPAN module has issues which the Debian team have patched, and the CPAN author appears to have zero interest in patching the CPAN version (or talking about it at all). I wonder what CPAN’s policy is on abandoned modules… My point is that if you’re not using the Debian package, you’re that Crypt::GCrypt dependency appears to always fail now. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: koha-devel-bounces(a)lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> [mailto:koha-devel-bounces@lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> ] On Behalf Of Tomas Cohen Arazi Sent: Saturday, 13 February 2016 2:52 AM To: Manos PETRIDIS <egpetridis(a)gmail.com <mailto:egpetridis@gmail.com> > Cc: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] NorwegianPatronDB I think we should ship with all the dependencies. We cannot make people's Koha break if they enable some feature. 2016-02-11 17:47 GMT-03:00 Manos PETRIDIS <egpetridis(a)gmail.com <mailto:egpetridis@gmail.com> >: Apparently libsoap-lite-perl, libcrypt-gcrypt-perl and libconvert-basen-perl should be/remain mandatory in 3.22, as they are required by a non-optional module, even if the functionality it provides is not used. 2016-02-11 5:06 GMT+02:00 Mark Tompsett <mtompset(a)hotmail.com <mailto:mtompset@hotmail.com> >: Greetings, It seems that “$debug && warn” is a popular style used in C4/Member already. I don’t think a system preference is needed. Just a $debug prepend, perhaps? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Sign it off, kill it, suggest a counter-patch, whatever. I do think this addresses the issue. GPML, Mark Tompsett From: David Cook <mailto:dcook@prosentient.com.au> Sent: Wednesday, February 10, 2016 6:40 PM To: 'Philippe Blouin' <mailto:philippe.blouin@inlibro.com> Cc: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] NorwegianPatronDB I think you’re right, Philippe. I’ve noticed the same thing. In fact, the “Unable to load Koha::NorwegianPatronDB” was added after the fact to stop the absence of those libraries causing Koha to die. I don’t necessarily see the point of having that warning there though, as most Koha users probably aren’t going to use the NorwegianPatronDB. Maybe that could have a system preference… so the warns (or the dying) only happens when the system preference is set? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: koha-devel-bounces(a)lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> [mailto:koha-devel-bounces@lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> ] On Behalf Of Philippe Blouin Sent: Thursday, 11 February 2016 8:47 AM To: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: [Koha-devel] NorwegianPatronDB Hi! I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl <http://admin-home.pl> : Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl I look at the code, and beside wondering why that custom feature is so profoundly imbricated into master Koha, I was wondering what is not working. So I hacked the code to add verbose => 1 on the can_load call, and found that NorwegianPatronDB was not compiling because it was missing the following libraries: apt-get -y install libsoap-lite-perl apt-get -y install libcrypt-gcrypt-perl apt-get -y install libconvert-basen-perl Those modules are specified as NOT mandatory in 3.22. As such, I should not be flooded with Norwegian errors because they are not available, for a module which I and most do not care for. Or am I getting it wrong? Thanks Philippe _____ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (http://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 <tel:%2B54%209351%203513384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

1 0

Re: [Koha-devel] NorwegianPatronDB
by David Cook 04 Apr '16

04 Apr '16

Hi Blou, The Debian package version should be fine. It’s the CPAN version which is not fine. While this isn’t a problem for Debian users, it is a problem for those of us who don’t use Debian. I’ve tried contacting the CPAN author but they’ve ignored or not received my messages. I see Martin has emailed as well though, so I’ll look at that now… David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: Philippe Blouin [mailto:philippe.blouin@inlibro.com] Sent: Tuesday, 16 February 2016 12:50 AM To: David Cook <dcook(a)prosentient.com.au>; 'Tomas Cohen Arazi' <tomascohen(a)gmail.com>; 'Manos PETRIDIS' <egpetridis(a)gmail.com> Cc: koha-devel(a)lists.koha-community.org Subject: [***SPAM*** Score/Req: 05.5/5.0] Re: [Koha-devel] NorwegianPatronDB Actually, I did fix it using the debian package on debian 7.5. Not sure if the module worked, but the warning disappeared (which then prompted my original email) Philippe Blouin, Responsable du développement informatique Tél. : (888) 604-2627 <mailto:philippe.blouin@inLibro.com> philippe.blouin(a)inLibro.com inLibro | pour esprit libre | <http://www.inLibro.com> www.inLibro.com On 02/14/2016 05:20 PM, David Cook wrote: FYI, if you’re using the Crypt::GCrypt module from CPAN (ie you’re not using a Debian-based system with libcrypt-gcrypt-perl), Koha is probably going to be unable to load Koha::NorwegianPatronDB. The CPAN module has issues which the Debian team have patched, and the CPAN author appears to have zero interest in patching the CPAN version (or talking about it at all). I wonder what CPAN’s policy is on abandoned modules… My point is that if you’re not using the Debian package, you’re that Crypt::GCrypt dependency appears to always fail now. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: koha-devel-bounces(a)lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Tomas Cohen Arazi Sent: Saturday, 13 February 2016 2:52 AM To: Manos PETRIDIS <mailto:egpetridis@gmail.com> <egpetridis(a)gmail.com> Cc: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] NorwegianPatronDB I think we should ship with all the dependencies. We cannot make people's Koha break if they enable some feature. 2016-02-11 17:47 GMT-03:00 Manos PETRIDIS <egpetridis(a)gmail.com <mailto:egpetridis@gmail.com> >: Apparently libsoap-lite-perl, libcrypt-gcrypt-perl and libconvert-basen-perl should be/remain mandatory in 3.22, as they are required by a non-optional module, even if the functionality it provides is not used. 2016-02-11 5:06 GMT+02:00 Mark Tompsett <mtompset(a)hotmail.com <mailto:mtompset@hotmail.com> >: Greetings, It seems that “$debug && warn” is a popular style used in C4/Member already. I don’t think a system preference is needed. Just a $debug prepend, perhaps? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15795 Sign it off, kill it, suggest a counter-patch, whatever. I do think this addresses the issue. GPML, Mark Tompsett From: David Cook <mailto:dcook@prosentient.com.au> Sent: Wednesday, February 10, 2016 6:40 PM To: 'Philippe Blouin' <mailto:philippe.blouin@inlibro.com> Cc: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] NorwegianPatronDB I think you’re right, Philippe. I’ve noticed the same thing. In fact, the “Unable to load Koha::NorwegianPatronDB” was added after the fact to stop the absence of those libraries causing Koha to die. I don’t necessarily see the point of having that warning there though, as most Koha users probably aren’t going to use the NorwegianPatronDB. Maybe that could have a system preference… so the warns (or the dying) only happens when the system preference is set? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: koha-devel-bounces(a)lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> [mailto:koha-devel-bounces@lists.koha-community.org <mailto:koha-devel-bounces@lists.koha-community.org> ] On Behalf Of Philippe Blouin Sent: Thursday, 11 February 2016 8:47 AM To: koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> Subject: [Koha-devel] NorwegianPatronDB Hi! I'm working on 3.22.02 and my logs are FILLED with the following warnings: Members.pm: Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/acqui/booksellers.pl admin-home.pl <http://admin-home.pl> : Unable to load Koha::NorwegianPatronDB at /blurred/C4/Members.pm line 46., referer: http://blurred/cgi-bin/koha/admin/preferences.pl I look at the code, and beside wondering why that custom feature is so profoundly imbricated into master Koha, I was wondering what is not working. So I hacked the code to add verbose => 1 on the can_load call, and found that NorwegianPatronDB was not compiling because it was missing the following libraries: apt-get -y install libsoap-lite-perl apt-get -y install libcrypt-gcrypt-perl apt-get -y install libconvert-basen-perl Those modules are specified as NOT mandatory in 3.22. As such, I should not be flooded with Norwegian errors because they are not available, for a module which I and most do not care for. Or am I getting it wrong? Thanks Philippe _____ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (http://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

1 0

Last failing test fixed...
by Mark Tompsett 01 Apr '16

01 Apr '16

Greetings, I continued looking at the failing tests more. Has anyone worked on solving the Circulation_Issuingrule test failure from http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680… If not, check out 16186 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186) 16185 and 16186 should be the last of the problems that need sign off. GPML, Mark Tompsett

2 1

Testing follow up...
by Mark Tompsett 01 Apr '16

01 Apr '16

Greetings, So, I figured I’d look at the failing tests more. Has anyone worked on solving the Guided Reports failure from http://jenkins.koha-community.org/view/Koha%20master/job/Koha_Master_D7/680… If not, check out 16185 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16185) Thanks to those who QA’d bugs 16173, 16174, 16176, and 16178. GPML, Mark Tompsett

1 0

Fw: Jenkins build is still unstable: Koha_Master_D7 #680
by Mark Tompsett 01 Apr '16

01 Apr '16

Greetings, I know that bugs 16173, 16174, 16176, and 16178 would solve 6 (I think) of the 9 remaining problems. They just need QA and pushing. GPML, Mark Tompsett -----Original Message----- [SNIP] Subject: Jenkins build is still unstable: Koha_Master_D7 #680 See <http://jenkins.koha-community.org/job/Koha_Master_D7/changes>

1 0