August 2016 - Koha-devel - lists.koha-community.org

Koha namespace architecture - calls for discussions
by Jonathan Druart 11 Aug '16

11 Aug '16

Hi devs (me again), During the last dev meeting, we discussed about the naming of a new module in our Koha namespace. The conclusion was to ask the ML in order to get more ideas (as there was not a lot of attendees...). I'd like to take this opportunity to bring other architecture problems I faced recently (Bug 16846 - Move patron related code to Koha::Patron). 1/ Import stuffs modules The initial discussion comes from 2 modules which have been added in 2 different bug reports about the same thought [1]. To provide a module to import patron, the author of bug 12598 chose Koha::Patrons::Import when I chose Koha::Exporter::Record on bug 14722 (the first one is about importing patrons, the second one is about exporting records (biblios, authorities)). We need to uniformise these 2 namespaces to keep consistency. The different possibilities are: a. Koha::Patrons::Import b. Koha::Importer::Patrons c. Koha::Importer::Patron d. Koha::Import::Patrons e. Koha::Import::Patron My opinion is that having Koha::Exporter|Importer::Objects will add the ability to have a Koha::Exporter|Importer module to group export/import methods, if we want to (Objects means Patrons, Records, Lists(Shelves), Reports, etc.) But we could imagine a generic Koha::Exporter|Importer modules with specific Koha::Object[s?]::Export|Import modules. 2/ Move C4::Members::GetBorrowersWithIssuesHistoryOlderThan to the Koha namespace This subroutine is supposed to return the patrons with an issue history older than a given date. I first chose to move this code to Koha::Patrons->search_with_issues_history_older_than But looking at the code you will find that the subroutine actually returns the borrowernumber with the number of old issues (matching the "older than" date). IMO it would make sense to return the patrons (Koha::Patron) instead of just the borrowernumber, but we will have to join the 2 tables, which can lead to a perf issue (ref needed). This idea is enforced by the fact that GetBorrowersWhoHaveNeverBorrowed and GetBorrowersToExpunge fit perfectly into Koha::Patrons. Otherwise we could decide to move the subroutine to a method of Koha::OldIssues, to avoid the join. But that sounds weird to me. 3/ Move C4::Ratings I have started to move C4::Ratings to Koha::Rating[s] Everything went fine until I decided to move C4::Rating::GetRating. It actually calculates the ratings avg for a record and returns a hashref with different values, and not a Koha::Rating object. I think we need to split up with Koha::Ratings->search({ biblionumber => $biblionumber })->calculate_avg (or something similar) and Koha::Ratings->search({ biblionumber => $biblionumber, borrowernumber => $borrowernumber }); # which will return a Koha::Rating object In that case, 1 call to C4::Ratings::GetRating will be replaced with 2 calls. Does that make sense? 4/ Move subroutines not directly related to a Koha::Object In some cases, the move is not very obvious. For instance we have C4::Members::checkcardnumber and C4::Members::get_cardnumber_length, they are strongly linked and I think we would like to keep them together. We could imagine a Koha::Patron::Cardnumber to move get_cardnumber_length in, but it does not represent a patron's cardnumber, so it could be confusing. checkcardnumber could go easily to Koha::Patron->check_new_cardnumber( $new_cardnumber ) 5/ patronflags? Any ideas what we could do with C4::Members::patronflags? :) Others will certainly come later! Cheers, Jonathan [1] http://meetings.koha-community.org/2016/development_irc_meeting_13_july_201… from 14:29:48 <cait> #info Topic: Koha::Patrons::Import (bug 12598) vs Koha::Exporter::Record (bug 14722)

4 4

Reminder: Koha Development IRC meeting - 19 UTC
by Katrin Fischer 09 Aug '16

09 Aug '16

Hi all, there is a Development IRC meeting scheduled for 10 August at 19 UTC. The agenda can as always be found on the wiki: https://wiki.koha-community.org/wiki/Development_IRC_meeting_10_August_2016 Please add the topics you want to discuss to the agenda! Hope to see you there, Katrin

1 0

Introducing Koha nightly packages
by Mirko Tietgen 08 Aug '16

08 Aug '16

Hello dev people, I have set up a build server and repository for automatic Koha nightly builds (Debian packages) of master, 16.05.x and 3.22.x. It also serves a live installation running the latest master build, unless it is broken. You can find it at https://apt.abunchofthings.net/koha-nightly/ Friendly word of advice: Kids, do not use this in production. It's just a development toy. Cheers, Mirko -- Mirko Tietgen mirko(a)abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de

2 1

Signoff request: bug 16929
by Marcel de Rooy 08 Aug '16

08 Aug '16

Hi all, Just rebased bug 16929. Two pending security fixes depend on this report. Not hard to test. I already verified that it resolves a possible delay on some virtual servers. If you do not experience that delay, your signoff still serves to assure that the script is working properly. Please add your signoff to get this further. Thanks, Marcel PS As a sidenote, there is still another problem with opac-memberentry. It is addressed on bug 16960.

1 0

Re: [Koha-devel] [Koha] General IRC Meeting 3 August 2016 / Kohacon 2017 bidder information
by Chris Cormack 03 Aug '16

03 Aug '16

On 3 August 2016 at 21:36, Joann Ransom <joann.ransom(a)gmail.com> wrote: > Is it too soon to bid KohaCon 2019 for NZ ? > We had 2010, how about 2020 to keep it round numbers :) Chris

1 1

Regarding the implementation of recommender system in koha
by ADITYA RAJ 03 Aug '16

03 Aug '16

Sir,In my college I am working on recommender system project and I want to implement it in koha search so I need some help Hoping positive response from you

2 1

Biblibre sandboxes out
by Fridolin SOMERS 03 Aug '16

03 Aug '16

Hie, Our sandboxes are broken (lets say on holiday) : https://wiki.koha-community.org/wiki/Sandboxes#BibLibre This is because there is a new dependency only existing since Jessie, and those machines can not upgrade. We are migrating all our servers to Ubuntu Xenial. We will tell you when sandboxes are done. Best regards, -- Fridolin SOMERS Biblibre - Pôles support et système fridolin.somers(a)biblibre.com

1 0

General IRC Meeting 3 August 2016 / Kohacon 2017 bidder information
by Mirko Tietgen 03 Aug '16

03 Aug '16

Hi everyone, the next general IRC meeting is next week, 3 August 2016, 10:00 UTC. Conversion to your local time: http://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+IRC+General+M… You can find the agenda here: https://wiki.koha-community.org/wiki/General_IRC_meeting_3_August_2016 This is the last meeting before we close bidding to host Kohacon 2017. It would be nice if bidders would join us at the meeting and tell a little about their plans. If the meeting is not an option, please send a message to the mailing list explaining that you are still interested in hosting Kohacon 2017, and please update your proposals in the Koha wiki now if necessary: Narrow down the proposed dates if possible, update conference locations, add contact emails(!). https://wiki.koha-community.org/wiki/KohaCon17_Proposals We are still open for proposals to host Kohacon 2017 until 10 August 2016 UTC. Cheers, Mirko -- Mirko Tietgen mirko(a)abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de

5 5

Reminder: General IRC meeting 3 August 2016 - 10 UTC
by Katrin Fischer 02 Aug '16

02 Aug '16

Hi all, there will be a General Koha IRC meeting in about 14 hours. As always the agenda and a link to find out your local meeting time can be found on the wiki: https://wiki.koha-community.org/wiki/General_IRC_meeting_3_August_2016 Hope to see you there! Katrin

1 0

Re: [Koha-devel] [Koha] search quits working
by Marcel de Rooy 02 Aug '16

02 Aug '16

Adding this comment to bug 16885. Thanks. ________________________________ Van: Koha <koha-bounces(a)lists.katipo.co.nz> namens Philippe Blouin <philippe.blouin(a)inlibro.com> Verzonden: dinsdag 2 augustus 2016 16:47 Aan: Scott Owen; Nombre CC: koha Onderwerp: Re: [Koha] search quits working (sorry, jumping into the thread) We've had this problem on 10% of our installations. I solved it by going nuclear with logrotate since that was really hurting the users to not have zebra working (it would appear like working on our monitor, but was actually just dying and restarting). Here is the postrotate I've end up with, after many iterations of Next Level Apocalypse You :) postrotate service apache2 reload find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service "$(basename "$0")" stop' {} \; sleep 3 find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service "$(basename "$0")" stop' {} \; sleep 3 pkill -9 zebra sleep 2 pkill -9 zebra sleep 2 find /etc/init.d/ -name "*zebra-daemon" -exec bash -c 'service "$(basename "$0")" start' {} \; endscript As you see, no subtlety, but I've had no problem for a year now... Philippe Blouin, Responsable du développement informatique Tél. : (888) 604-2627 philippe.blouin(a)inLibro.com <mailto:philippe.blouin@inLibro.com> inLibro | pour esprit libre | www.inLibro.com<http://www.inLibro.com> <http://www.inLibro.com> On 08/02/2016 10:08 AM, Scott Owen wrote: > Hi, > > I'm finally getting back to my Koha issues..... > > > "I'm going to test adding a line > > /bin/sleep 5 > > as first command in postrotate in logrotate.d/koha-common. I'll see > tomorrow." > > Nombre, did this work for you ?? > > or is the issue maybe fixed in the latest release ?? > > > -S > > > > > > > On Fri, Jul 22, 2016 at 7:52 AM, Nombre <d0a10(a)yahoo.es> wrote: > >> El 21/07/16 a las 14:55, Marcel de Rooy escribió: >>> Bug 16885 ? >> I'm going to test adding a line >> >> /bin/sleep 5 >> >> as first command in postrotate in logrotate.d/koha-common. I'll see >> tomorrow. >> >> Regards >> >>> -----Oorspronkelijk bericht----- >>> Van: Koha [mailto:koha-bounces@lists.katipo.co.nz] Namens Tomas Cohen >> Arazi >>> Verzonden: donderdag 21 juli 2016 14:27 >>> Aan: Scott Owen <sowen(a)edzone.net>; Paul A < >> paul.a(a)navalmarinearchive.com> >>> CC: koha <koha(a)lists.katipo.co.nz> >>> Onderwerp: Re: [Koha] search quits working >>> >>> I blame logrotate. >>> >>> El jue., 21 jul. 2016 a las 9:12, Scott Owen (<sowen(a)edzone.net>) >> escribió: >>>> Sorry.... >>>> Debian, latest version of Koha. >>>> >>>> problem *seems* to have only started when I updated to the latest Koha >>>> version. >>>> >>>> >>>> 3.22.06.000 >>>> Linux hskoha 3.16.0-4-686-pae #1 SMP Debian 3.16.7-ckt25-2 >>>> (2016-04-08) >>>> i686 >>>> >>>> >>>> The issue seems to be with the zebra server somehow coming to a halt, >>>> and bailing.....seemingly @ approx. 7:35 daily. >>>> >>>> a quick command of " koha-start-zebra <instance> " makes things >>>> all-good.....and I can search again. >>>> >>>> However, within a couple of days....the zebra server appears to die >> again. >>>> I have two servers, both at exactly the same rev. and they are both >>>> exhibiting this behavior. Starting to look at some of the cron.daily >>>> commands.....they seem the most likely suspect (in my eyes) >>>> >>>> >>>> >>>> cron.daily -->> >>>> >>>> #!/bin/sh >>>> # /etc/cron.daily/koha-common -- Daily housekeeping tasks for all Kohas. >>>> # Copyright 2010 Catalyst IT, Ltd >>>> # >>>> # This program is free software: you can redistribute it and/or modify >>>> # it under the terms of the GNU General Public License as published by >>>> # the Free Software Foundation, either version 3 of the License, or # >>>> (at your option) any later version. >>>> # >>>> # This program is distributed in the hope that it will be useful, # >>>> but WITHOUT ANY WARRANTY; without even the implied warranty of # >>>> MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU >>>> General Public License for more details. >>>> # >>>> # You should have received a copy of the GNU General Public License # >>>> along with this program. If not, see <http://www.gnu.org/licenses/>. >>>> >>>> koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/ >>>> overdue_notices.pl -t koha-foreach --enabled >>>> /usr/share/koha/bin/cronjobs/fines.pl >>>> koha-foreach --enabled --email /usr/share/koha/bin/cronjobs/ >>>> advance_notices.pl -c koha-foreach --enabled >>>> /usr/share/koha/bin/cronjobs/membership_expiry.pl >>>> -c >>>> koha-foreach --enabled /usr/share/koha/bin/cronjobs/holds/ >>>> cancel_expired_holds.pl >/dev/null 2>&1 koha-foreach --enabled >>>> /usr/share/koha/bin/cronjobs/services_throttle.pl > /dev/null 2>&1 >>>> koha-foreach --enabled >>>> /usr/share/koha/bin/cronjobs/cleanup_database.pl --sessions >>>> --zebraqueue 10 --list-invites koha-foreach --enabled --noemail >>>> /usr/share/koha/bin/cronjobs/ cleanup_database.pl --mail koha-foreach >>>> --enabled /usr/share/koha/bin/cronjobs/holds/ >>>> auto_unsuspend_holds.pl > /dev/null 2>&1 koha-foreach --enabled >>>> /usr/share/koha/bin/cronjobs/automatic_renewals.pl >>>> koha-run-backups --days 2 --output /var/spool/koha >>>> >>>> >>>> >>>> >>>> On Wed, Jul 20, 2016 at 6:41 PM, Paul A >>>> <paul.a(a)navalmarinearchive.com> >>>> wrote: >>>> >>>>> At 10:20 AM 7/20/2016 -0400, Scott Owen wrote: >>>>> >>>>>> Hi all, >>>>>> I'm having some issues with Koha searching from both the OPAC and >>>>>> the staff Intranet. >>>>>> I have tried several solutions for reindexing etc... >>>>>> including >>>>>> ---Koha-rebuild-zebra -f -v -b mylibrary and ---export >>>>>> PERL5LIB=/usr/share/koha/lib ---export >>>>>> KOHA_CONF=/usr/share/koha/koha-conf.xml >>>>>> ---perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -b -r >>>>>> -v -run-as-root >>>>>> >>>>> You don't say which version of Koha, nor what o/s you are using. >>>>> Assuming Debian/Ubuntu, what does printenv give you? You should see >>>>> something like (amongst other lines): >>>>> >>>>> me@my_server:/$ printenv >>>>> PERL5LIB=/usr/share/koha/lib >>>>> >>>>> >>>> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr >>>> /local/lib/perl >>>>> KOHA_CONF=/usr/share/koha/koha-conf.xml >>>>> KOHA_PATH=/usr/share/koha >>>>> >>>>> I'm also a little surprised by your "-run-as-root" -- in slightly >>>>> older versions of Koha, this was a "no-no", but may well have >>>>> changed >>>> (mpm-itk?) >>>>> There is also something I noticed in further emails: >>>>> >>>>>> your zebra error logs. >>>>> [snip] >>>>>> 20160713 07:36:11 dlpms-koha-zebra: client (pid 526) killed by >>>>>> signal >>>>> 15, stopping >>>>>> 20160713 07:40:07 dlpms-koha-zebra: client (pid 10116) killed by >>>>>> signal >>>>> 15, stopping >>>>> >>>>> What were the 9590 processes in the <4 minutes? That log entry would >>>>> certainly get my attention. >>>>> >>>>> Best -- P. >>>>> >>>>> >>>>> none of these commands produce any errors, however, they also do not >>>>> fix >>>>>> the issue. >>>>>> >>>>>> >>>>>> A reboot of the VM will cause the "search" to work again for a day >>>>>> or two....?? >>>>>> (I know....."it shouldn't make a difference" ...but it >>>>>> does...!?!?!?) >>>>>> >>>>>> >>>>>> I'm unsure of exactly where to start troubleshooting ??? >>>>>> >>>>>> Any advise on where to begin ?? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -S >>>>>> _______________________________________________ >>>>>> Koha mailing list http://koha-community.org >>>>>> Koha(a)lists.katipo.co.nz >>>>>> https://lists.katipo.co.nz/mailman/listinfo/koha >>>>>> >>>>> --- >>>>> Maritime heritage and history, preservation and conservation, >>>>> research and education through the written word and the arts. >>>>> <http://NavalMarineArchive.com> and <http://UltraMarine.ca> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Koha mailing list http://koha-community.org Koha(a)lists.katipo.co.nz >>>>> https://lists.katipo.co.nz/mailman/listinfo/koha >>>>> >>>> _______________________________________________ >>>> Koha mailing list http://koha-community.org Koha(a)lists.katipo.co.nz >>>> https://lists.katipo.co.nz/mailman/listinfo/koha >>>> >>> -- >>> Tomás Cohen Arazi >>> Theke Solutions (https://theke.io <http://theke.io/>) ? +54 9351 3513384 >>> GPG: B2F3C15F >>> _______________________________________________ >>> Koha mailing list http://koha-community.org Koha(a)lists.katipo.co.nz >> https://lists.katipo.co.nz/mailman/listinfo/koha >>> _______________________________________________ >>> Koha mailing list http://koha-community.org >>> Koha(a)lists.katipo.co.nz >>> https://lists.katipo.co.nz/mailman/listinfo/koha >>> >> _______________________________________________ >> Koha mailing list http://koha-community.org >> Koha(a)lists.katipo.co.nz >> https://lists.katipo.co.nz/mailman/listinfo/koha >> > _______________________________________________ > Koha mailing list http://koha-community.org > Koha(a)lists.katipo.co.nz > https://lists.katipo.co.nz/mailman/listinfo/koha _______________________________________________ Koha mailing list http://koha-community.org Koha(a)lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha

1 0