September 2016 - Koha-devel - lists.koha-community.org

Re: [Koha-devel] To React or not to React
by Paul A 21 Sep '16

21 Sep '16

At 08:34 AM 9/21/2016 -0600, Kyle Hall wrote: >Paul, that's not how it works. As I wrote earlier, if *I* sue Facebook I >could potentially lose my right to distribute software using React, but >you would be unaffected. Kyle -- not wanting to flog a dead horse (and as I wrote IANAL), but Koha is a prime example of open-source and has a track record of ensuring it remains so. Philosophically I like that. Practically, I run a charity (our members are the equity owners and I have no clue as to their love/hate relationship with Facebook) and would not want to take risks, nor have the budget to get a "legal opinion" (due diligence, and all that...) Best -- Paul >Kyle > > > ><http://www.kylehall.info>http://www.kylehall.info >ByWater Solutions ( <http://bywatersolutions.com>http://bywatersolutions.com ) >Meadville Public Library ( ><http://www.meadvillelibrary.org>http://www.meadvillelibrary.org ) >Crawford County Federated Library System ( ><http://www.ccfls.org>http://www.ccfls.org ) > >On Wed, Sep 21, 2016 at 8:30 AM, Paul A ><<mailto:paul.a@navalmarinearchive.com>paul.a(a)navalmarinearchive.com> wrote: >At 02:14 PM 9/21/2016 +0200, Mirko Tietgen wrote: >David Cook schrieb am 21.09.2016 > > The updated licence isnÃ¢t without controversy: > > > <<https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3…>https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3…> > > > https://discuss.reactjs.org/t/legal-department-did-not-allow-use-of-react/3… > > > > That said, I think the issue is that Facebook could revoke your > > licence to use React if you take legal action against Facebook. I > > donÃ¢t imagine the Koha community is going to do do that, so itÃ¢s > > > probably not a blocker. > >If you are right and that is the issue, does that mean Koha would >not be Free Software anymore unless everything React is reverted? > >That sounds like something I would not just push away with "i don't >imagine that happening", it sounds scary and not a way I want to go. > >I don't see how a license that can be revoked for whatever reasons >could work for us. > > >Agreed. But IANAL. However ISTR that are recent thread suggested "tens of >thousands" of potential libraries|users worldwide (based on downloads?) so >Murphy|Sod's Law will kick in sooner or later... > >Best -- P. > > >_______________________________________________ >Koha-devel mailing list ><mailto:Koha-devel@lists.koha-community.org>Koha-devel(a)lists.koha-community.org >http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >website : <http://www.koha-community.org/>http://www.koha-community.org/ >git : <http://git.koha-community.org/>http://git.koha-community.org/ >bugs : <http://bugs.koha-community.org/>http://bugs.koha-community.org/ > --- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>

1 0

Authentication field on borrower.
by Rodrigo Santellan 21 Sep '16

21 Sep '16

Hi, I'm trying to figure out where the field authentication of the borrowers table is used? Regards.

3 3

[Koha::Object] Related records and calling methods from templates
by Marcel de Rooy 21 Sep '16

21 Sep '16

Hi devs, I am seeing more Koha objects that include methods for related records like Koha::Patron, sub image referring to Koha::Patron::Images. As a second example, on bug 14610 (article requests), a biblio, item, branch and borrower method is added to Koha::ArticleRequest. Obviously, they all follow the same pattern. Could we generalize that, and keep our code cleaner? And do we always need the full Koha object? For use in a template we may need only a few columns. We start passing these objects to the templates now too, making it possible to call methods from the template. It is possible, but do we really want that? More code ends up in the template, maybe harder to find since you now use borrower.method instead of borrower->method etc. Secondly, reading borrower.something might not immediately tell you that something is a method instead of a column. In other cases we have added a sort of wrapper like Branches.GetName from the Branches plugin. I am interested to know if we want to enforce this wrapper approach for instance, or just continue on the current road. Thx, Marcel

6 9

PDF::Reuse
by Christopher Nighswonger 16 Sep '16

16 Sep '16

Hi all, I'm working toward a release of PDF::Reuse. I've applied several patches submitted and uploaded a dev release to CPAN: http://search.cpan.org/~cnighs/PDF-Reuse-0.36/ There are a few more bugs on CPAN which I hope to get resolved in this release. If you know of anything that needs to be addressed, please let me know. If you have time to test, that would be greatly appreciated. I am especially concerned that nothing in this proposed release breaks features Koha is dependent upon. So testing there would be helpful as well. Kind regards, Chris

1 0

Where the field studentnumber of borrower is?
by Rodrigo Santellan 16 Sep '16

16 Sep '16

Hi, I'm migrating from Koha 2 to 3 and the field studentnumber of the table borrowers has gone? It should be now on a patron custom type? Regards and thanks for the help!

2 2

Custom authentication
by Rodrigo Santellan 15 Sep '16

15 Sep '16

Hi, I need to authenticate using a custom LDAP and a custom Web Service authentication how will be the best to implement this without forking the code. I ask this because I'm trying to migrate an old Koha 2.2.3 that has gone astray from the community and I don't want to start doing that again. What I plan to do is copy the Auth_with_ldap.pm to Auth_with_ldap_custom.pm and do my changes there. But I don't know if that is the really the best way to implement that or there is a place to put the custom authentication? Another question is about debugging, when maintaining the old one I use a lot: my $logger = C4::Context -> get_logger('C4::Auth'); and then log the data. (I'm a newbie in Perl and Koha) How can I achieve the same in the new one? I saw the Koha::Logger but is not the same. Regards! And thank for any help!

1 0

Migrate/Upgrade from 2.2.3 to latest.
by Rodrigo Santellan 15 Sep '16

15 Sep '16

Hi, I'm trying to do a migration or upgrade from koha 2.2.3 to koha 3. I know is a daunting task that I have embarked but I'm trying to bring back a library to the latest updates of the community. So far this are the steps I have done: 1 - I dump an empty schema of the DB and create a new one with the name koha3. 2 - Apply the update22to30.pl 3 - Import all the tables I could, the one that not been deleted. 4 - Run updatedatabase.pl And now I'm stuck there, I'm missing the table: labels_templates and the table printers_profile is different. I have asked on the IRC channel and they say that table labels_templates is gone on 3.18. I'm heading on a good direction? Or I should do a clean install and then try to import all the old data? I will appreciate any help! Thanks in advance! Regards. Rodrigo Santellán.

3 13

Coding patterns discussion
by Tomas Cohen Arazi 15 Sep '16

15 Sep '16

I've been looking at our coding patterns, and noticed we haven't discussed/agreed on some stuff. Which is a good oportunity to just do it, now the Koha:: namespace is being filled with cool old-code rewrites with lots of test coverage. - Transactions on heavy business functions that should definitely be wrapped inside a transaction. Running $ cd Koha ; git grep txn is just sad. - Little use of Exceptions in Koha. We introduced them, but still don't extend its use. Maybe related to the next item. I think we should keep general exceptions (like Koha::Exceptions::ObjectNotFound) in the general Koha::Exceptions namespace. But move the package-specific ones into its own file. To aid maintenance. A good candidate are Koha::Exceptions::Virtualshelves - We don't use a Try/Catch library. It would make it easier to use Koha::Exceptions with a nice syntax. There are a couple interesting libraries: Try::Tiny and TryCatch. [1] I prefer the latter because the type check seems nicer to write and eval (instead of an if/ifelse cascade checking ref($exception) eq 'Something'. I have my opinions on this items, and it would be great to discuss it openly. There's code in bugzilla waiting for QA, and it'd be great to have some consensus on how to organize the code for the future. Regards [1] http://search.cpan.org/~ether/Try-Tiny-0.27/lib/Try/Tiny.pm and http://search.cpan.org/~ash/TryCatch-1.003002/lib/TryCatch.pm -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F

8 12

Circulation rule update
by Cybermon 14 Sep '16

14 Sep '16

Dear All, Actually, I was updated Koha circulation rules. But not changed default_branch_circ_rules field of database. How can I update from 3 to 10 default_branch_circ_rules fields ? Please see below library rules from mysql database. mysql> select * from default_borrower_circ_rules; +--------------+-------------+-------------------+ | categorycode | maxissueqty | maxonsiteissueqty | +--------------+-------------+-------------------+ | BILND | 10 | 10 | | BP | 10 | 10 | | IL | 10 | 10 | | K | 10 | 10 | | PA | 10 | 10 | | PT | 10 | 10 | | S | 10 | 10 | +--------------+-------------+-------------------+ 7 rows in set (0.00 sec) mysql> select * from default_branch_circ_rules; +------------+-------------+-------------------+-------------+-------------------------+--------------+ | branchcode | maxissueqty | maxonsiteissueqty | holdallowed | hold_fulfillment_policy | returnbranch | +------------+-------------+-------------------+-------------+-------------------------+--------------+ | UBPL | 3 | 3 | 1 | any | NULL | +------------+-------------+-------------------+-------------+-------------------------+--------------+ 1 row in set (0.00 sec) mysql>

1 0

What's on in Koha devel #4
by Jonathan Druart 14 Sep '16

14 Sep '16

Hi devs, No new topic this month. Please see bellow the progress of the regular ones. = Security issues = They are almost all pushed. Please see the following 2 omnibus to know what is left: bug 14568 - [OMNIBUS] XSS in Staff Client bug 17096 - [OMNIBUS] CSRF protections = Caching system = Last month I told you about bug 16579, it has been split into 2 bug reports: Bug 11921 - memcached configuration should be moved back to koha-conf.xml Bug 17189 - Add the ability to define several memcached namespaces They have been pushed to master. The conclusion of this is that the memcached configuration is now moved back to the koha-conf.xml file. Memcached will be used for cronjob scripts and Plack without the need to export environment variables. The next step is bug 17224 - Switch to Koha::Cache completely in Context.pm ? To help administrators, bug 17261 is going to display the memcached configuration info to about.pl to inform them if something is badly configured or if everything is ok. = RESTful API = Last month I have asked some general questions about the RESTful API and the different patches waiting for QA/SO. I did not receive any replies from people directly involved in the RESTful API patches. I have put this part aside last month (and certainly for the next month as well). As Marcel said: "If the community decides to push it, the community will have to maintain it". Ok so let's define "the community" :) = Refactoring = == Koha::Patrons == Still lot of things to test/qa, see bug 16846 - Move patron related code to Koha::Patron == C4::Branch == This one is, finally, removed. Bug 15293 - Move the C4::Branch related code to Koha::Libraries is now complete! The total diff is something like 1800+ for 3500- == Koha::AuthorisedValues == Lot of patches to test on bug 15799 (Move authorised values related code into Koha::AuthorisedValues - part 2) == Remove field biblioitems.marc == Following a discussion on koha-devel in July (http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html) I have submitted a patch on Bug 10455 - remove redundant 'biblioitems.marc' field and Bug 17196 - Move marcxml out of the biblioitems table This will need to be tested deeply. = Ubuntu 16.04 support = Note that we are still waiting for bug 16554 to support Ubuntu 16.04 and MySQL 5.7. But lot of other bugs exist and only few have been reported. See bug 17258 for the list of the known bugs. = Dev tools = I have sent 2 emails last week, you will find 2 smalls things for bugzilla, 1 for git-bz and 1 for plack: 3 tiny but very useful things - http://lists.koha-community.org/pipermail/koha-devel/2016-September/043023.… Restart plack when needed - http://lists.koha-community.org/pipermail/koha-devel/2016-September/043026.… = Miscellaneous = Tomas asked for feedback on transactions and exceptions a couple of days ago: Coding patterns discussion - http://lists.koha-community.org/pipermail/koha-devel/2016-September/043032.… Note that Paul sent a last call to register for the hackfest in Marseille - http://lists.koha-community.org/pipermail/koha-devel/2016-September/043046.… A dev meeting is planned on September 28th at 21 UTC (https://wiki.koha-community.org/wiki/Development_IRC_meeting_28_September_2…) Please have a look at the agenda and the different topics we will discussed. Cheers, Jonathan

2 1