October 2018 - Koha-devel - lists.koha-community.org

SQL-modes wiki page
by Jonathan Druart 26 Oct '18

26 Oct '18

Hi, I have opened a wiki page to try and explain the problems we are facing (and trying to fix) with the SQL modes. I let you read carefully this page and tell me if something is not clear enough:https://wiki.koha-community.org/wiki/SQL_modes Cheers, Jonathan

2 1

The order of "use"
by Mark Tompsett 25 Oct '18

25 Oct '18

Greetings, I was looking at bug 21641, and noticed the patch was explicitly stating C4::Accounts:: on the function in question. I vaguely recalled this sort of symptom shows itself in a knotted “use” mess. C4::Circulation –> C4::Members –> C4::Accounts C4::Circulation –> C4::Accounts C4::Circulation –> C4::Overdues –> C4::Accounts What is the best order to list these? C4::Accounts last? Is putting the C4::Accounts:: on the function in question still something we should do anyways? Feedback appreciated, Mark Tompsett

3 6

Re: [Koha-devel] Price format in order by email
by Holger Meissner 24 Oct '18

24 Oct '18

Thank you, Barton! [%- USE Price -%] [% <<aqorders.listprice>> | $Price %] did the trick :)

2 1

Price format in order by email
by Holger Meissner 24 Oct '18

24 Oct '18

Dear koha devs, when we send an order by email <<aqorders.listprice>> is formatted with decimal point and six decimal places, in spite of syspref CurrencyFormat set to EUR. Is anyone working on this? Is there some kind of workaround? koha version 17.11.10.000. Thanks, Holger

2 1

Koha 17.11.11 release
by Fridolin SOMERS 24 Oct '18

24 Oct '18

The Koha community is proud to announce the release of Koha 17.11.11. This is a maintenance release. The full release notes are available at https://koha-community.org/koha-17-11-11-release/ Debian packages will be upgraded in a few days. I've proposed to continue maitaining 17.11.x in Koha 19.05 roles. Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre, France - software and system maintainer

1 0

Generic OpenIDConnect client
by David Cook 24 Oct '18

24 Oct '18

Hi all, About 4 years ago, I wrote a generic OpenIDConnect client, and kept telling myself that I would upstream it but I never did. until now: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586. I wrote it for 1 specific client, so it exists heavily in a set of "Prosentient" namespaces and some of the code is legacy from 3.14 and could be replaced by modern code (I'm looking at you Koha::Prosentient::Borrowers), but maybe people can try it out and give me some feedback to make it worthy of a sign off, or people can adapt it and I can give feedback. (I already have some things I would like to change. I think I overuse base64url. but it is essential when working with JWTs. I think I just got carried away with a substitution command once.) I know we already have the GoogleOpenIdConnect. I actually wrote this code before that code existed, but I don't think my code would work for Google the way it is now. It would probably need some alterations. Anyway, I was sick of telling myself that I would upstream it one day, so I sat down and made a patch and now it's shared. Cheers, David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

3 4

Koha 18.05.05 release
by Renvoize, Martin 23 Oct '18

23 Oct '18

The Koha community is proud to announce the release of Koha 18.05.05. This is a maintenance release containing 67 bugfixes The full release notes are available at https://koha-community.org/koha-18-05-05-release/ Debian packages will be updated within a few days Many thanks to everyone involved, *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize(a)ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info(a)ptfs-europe.com

1 0

Questions about terminology
by Barton Chittenden 23 Oct '18

23 Oct '18

I've been looking at the Koha terminology page ( https://wiki.koha-community.org/wiki/Terminology) There are still a handful of occurrences of incorrect terminology throughout the '.tt' files. I'm starting with looking for instances of 'biblio', which should be 'Bibliographic record'. I'm wondering about instances of "Biblio number" in the text... I think that "Bibliographic number" is actually *less* clear... "Bibliographic Record Number" is better, but in most cases where Biblio number is used (e.g. the Marc Editor), Biblio number makes sense in its context. Cheers, --Barton

6 8

Bugs for 18.11
by Jonathan Druart 23 Oct '18

23 Oct '18

Hi devs, I have started using the 'rel_18_11_candidate' bugzilla keyword to keep track of the bugs we need to fix before the release. Here is the list: https://frama.link/koha_bz_rel_18_11_candidate They are either regressions or bug fixes for new features of 18.11. They should be considered as high priority (blocker for the release) for the next weeks. Cheers, Jonathan PS: You really should bookmark this link ;)

1 0

SQL queries showing data that will cause software errors.
by Barton Chittenden 19 Oct '18

19 Oct '18

When ByWater started upgrading our partners to 17.11 last spring, I noticed that we were getting a lot of errors of the form "can't call method * on an undefined value at ..." We're starting to see these errors because more and more of our code uses Koha objects, and these will fail if a method is called on an undefined object. I brought this up here: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044613.html I think that there was also another thread about this, which I can't find at the moment... Jonathan's opinion on this is that we should start creating queries which find data that will fail. This thread is for those queries, since I have an example: Circulating or holdable items without item type SELECT biblionumber, itemnumber, barcode, title, notforloan FROM items INNER JOIN biblio USING (biblionumber) WHERE notforloan < 1 AND itype IS NULL Once we have a few of these at hand, I'll start a page on the Koha wiki.

2 2