April 2018 - Koha-devel - lists.koha-community.org

Reminder: Development IRC meeting 11 April 2018
by Katrin Fischer 10 Apr '18

10 Apr '18

Hi all, tomorrow is our next Developer IRC meeting: https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_April_2018 Planned topics so far include: - voting on several REST API endpoints - discussion on Authentication for the REST API - discussion on improving update procedures Please add anything else you wish to discuss. See you all tomorrow! Katrin

1 0

Printing patron cards results in 100% cpu
by Sven Halm 10 Apr '18

10 Apr '18

Hello and happy Easter! I have a problem with the patronage card printing. I also described the problem in Bug 20077. I got a tip from Katrin to try the mailing list. When I try to print the patron cards, the /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl does not finish and runs with 100% CPU load. In plack-error.log I find the following lines: Use of uninitialized value $batch_id in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 68. Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. Use of uninitialized value in multiplication (*) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. Use of uninitialized value in addition (+) at /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. The problem first appeared in February 2018 after I started the Ubuntu updates. Unfortunately I don't remember what has been updated. Current system environment (no changes made to koha!): OS: Ubuntu 17.10 Koha-Version: 17.11.04.000 OS Version ('uname -a'): Linux koha 4.13.0-37-generic #42-Ubuntu SMP Wed Mar 7 14:13:23 UTC 2018 x86_64 Perl Interpreter: /usr/bin/perl Perl-Version: 5.026000 Perl @INC: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.0 /usr/local/share/perl/5.26.0 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base MySQL-Version: mysql Ver 15.1 Distrib 10.1.30-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 Apache-Version: Server version: Apache/2.4.27 (Ubuntu) Unfortunately I am not able to print patron cards at the moment. It would be great if there was a solution for this soon. Many greetings Sven

2 1

Default Elasticsearch behaviour wrong with Chinese: can't find complete title
by Nicolas Legrand 10 Apr '18

10 Apr '18

Good day devs, Nick spotted these one during last Marseille Hackfest. We made some test with our catalogue on master and find out how to reproduce it, how to break it and how to fix it, though the inner mechanics remains a mystery and we are not quite sure about what the default behaviour should be. We did our test with 中國翻譯 (Chinese Translators Journal) which have two words highly present in our Catalog: China and translation. First, the default Koha behaviour is to add a "*" at the end of the searched word, which lead to 0 results. It produces a query looking like this one: $ curl "http://localhost:9200/koha_robin_biblios/_search?pretty" -d '{"from": 0, "size": 0,"query":{"query_string":{"query": "中國翻譯*"}}}' { "took" : 1, "timed_out" : false, "_shards" : { "total" : 5, "successful" : 5, "skipped" : 0, "failed" : 0 }, "hits" : { "total" : 0, "max_score" : 0.0, "hits" : [ ] } } If we quote 中國翻譯 in Koha, it yields one answer, the right one. It produces a query looking like this one: $ curl " http://bouse02.prive.bulac.fr:9200/koha_robin_biblios/_search?pretty" -d '{"from": 0, "size": 0,"query":{"query_string":{"query": "\"中國翻譯\""}}}' { "took" : 5, "timed_out" : false, "_shards" : { "total" : 5, "successful" : 5, "skipped" : 0, "failed" : 0 }, "hits" : { "total" : 1, "max_score" : 0.0, "hits" : [ ] } } Note that if I write an Elasticsearch query without quotes or star, it yields too much results (9626), the “right” result isn't in the ten first results: $ curl " http://bouse02.prive.bulac.fr:9200/koha_robin_biblios/_search?pretty" -d '{"from": 0, "size": 0,"query":{"query_string":{"query": "中國翻譯"}}}' { "took" : 16, "timed_out" : false, "_shards" : { "total" : 5, "successful" : 5, "skipped" : 0, "failed" : 0 }, "hits" : { "total" : 9626, "max_score" : 0.0, "hits" : [ ] } } I'm not sure what the right behaviour needs to be. We felt adding quotes added a lot of relevance to our results no matter what the language is. What is certain is that adding a star to the search by default doesn't help us. We didn't have the problem with Elasticsearch while playing with it in 17.05. For us, it is a regression. I add the MARC of our test record. What do you think about it? Best regards, -- *Nicolas Legrand* Administration technique et développements du système de gestion de la bibliothèque [image: Logo BULAC] Bibliothèque universitaire des langues et civilisations 65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 *18 22* www.bulac.fr

2 3

Upcoming installation bumps...
by Mark Tompsett 09 Apr '18

09 Apr '18

Greetings! I attempted to install packages on Bionic Beaver (Ubuntu 18.04 which is coming out shortly). I had to: sudo apt-get install libxml-sax-perl cpan2deb Marc::Charset sudo dpkg -i libmarc-charset-perl_1.35-1_all.deb sudo apt-get install libmarc-perl cpan2deb Marc::XML sudo dpkg -i libmarc-xml-perl_0.4-1_all.deb -- strangely koha-common installed after this. But my initial attempt to call up the staff client for the web install steps triggered a nasty error requiring this: cpan2deb Marc::File::XML --version 1.0.5 sudo dpkg -i libmarc-file-xml-perl_1.0.5_all.deb Then I was able to get through the web installer steps, including onboarding. I'm no packaging guru, but could we get those into the packaging somehow? GPML, Mark Tompsett

1 0

Re: [Koha-devel] [Koha] RFC for MARC holdings record support
by Ere Maijala 09 Apr '18

09 Apr '18

Yes, that's also a possibility, but I'm trying to keep the initial implementation as simple as possible, so it doesn't currently include any changes to holds or circulation. It's a good candidate for future development. --Ere Hugh Rundle kirjoitti 6.4.2018 klo 8.55: > This sounds great. I'm assuming this would allow us to do things like group multiple copies of the same issue of a magazine. > > Ere, or someone else, are you able to advise whether this includes any holds functionality changes? i.e. if we have: > > Bib record > - Holdings record 1 > - item record A > - item record B > - Holdings record 2 > - item record C > - item record D > > We would want to be able to 'place hold on first available item on this Holding', rather than first available on Bib/Title, or forcing item-level holds. i.e. I want to place a hold on Holdings Record 1, and either of item A or item B would satisfy my hold, but item C or item D would not. > > This may also necessitate changes to the circulation rules section of Administration. > > thanks > > Hugh Rundle > Library Systems & Resource Coordinator > Community Learning & Participation > > Brimbank City Council > Brimbank Community and Civic Centre - 301 Hampshire Road, Sunshine > > T +61 3 9249 4170 > M +61 437 734 108 > F +61 3 9249 4351 > > www.brimbank.vic.gov.au > -----Original Message----- > From: Koha [mailto:koha-bounces@lists.katipo.co.nz] On Behalf Of Nick Clemens > Sent: Thursday, 5 April 2018 1:11 AM > To: Ere Maijala; Koha > Cc: Koha Devel > Subject: Re: [Koha] [Koha-devel] RFC for MARC holdings record support > > There was some discussion of this at the IRC meeting today, forwarding on to the general list as well for librarian input/feedback > > On Tue, Apr 3, 2018 at 3:33 AM Ere Maijala <ere.maijala(a)helsinki.fi> wrote: > >> Hi Katrin, >> >> Thanks for the comments. I'll try to clarify the RFC. >> >> --Ere >> >> Katrin Fischer kirjoitti 1.4.2018 klo 17.32: >>> Hi Ere, >>> >>> thx for your work on that! I've added some comments and questions at >>> the bottom of the RFC page. I think key is to break the big >>> development down into multiple steps that can be easily tested. >>> >>> Katrin >>> >>> >>> On 26.03.2018 12:58, Ere Maijala wrote: >>>> Hi Everyone, >>>> >>>> I've written an RFC for adding support for MARC holdings records, >>>> available here: >>>> <https://wiki.koha-community.org/wiki/MARC_Holdings_Records_RFC>. >>>> I'd be grateful for any feedback on this. I know there have been >>>> some initiatives to add (back) holdings records, but this proposal >>>> is a bit different in that it relies on the MARC format and I >>>> already have it working in a local custom branch apart from OPAC support. >>>> >>>> Regards, >>>> Ere >>>> >>> >>> _______________________________________________ >>> Koha-devel mailing list >>> Koha-devel(a)lists.koha-community.org >>> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >>> website : http://www.koha-community.org/ git : >>> http://git.koha-community.org/ bugs : >>> http://bugs.koha-community.org/ >> >> -- >> Ere Maijala >> Kansalliskirjasto / The National Library of Finland >> _______________________________________________ >> Koha-devel mailing list >> Koha-devel(a)lists.koha-community.org >> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel >> website : http://www.koha-community.org/ git : >> http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ >> > -- > Nick Clemens > Sonic Screwdriver (Development Support) > ByWater Solutions > IRC: kidclamp > _______________________________________________ > Koha mailing list http://koha-community.org Koha(a)lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha > -- Ere Maijala Kansalliskirjasto / The National Library of Finland

1 0

Exploration of Koha ElasticSearch implementation
by Claire Hernandez 06 Apr '18

06 Apr '18

Hi, I want to share a work with you. I knew we can now switch SearchEngine syspref to ElasticSearch in Koha community version, but I didn't know a lot more. I explored with some BibLibre guys what we can really do, if we can propose this feature to our users. It seems there is some work to do but it would be great to have a more solid version for 18.05 if we test and fix more things, a version for early adopters who want to try it in production. I began a document where I list the gap to this version, it is a work in progress. I integrated the items identified by Nick (kidclamp) in the wiki page (Elastisearch_status). Thanks. I could have put everything in bugzilla or wiki but it wasn't ideal to me at this time. Depending your feedback I can make it better. https://docs.google.com/spreadsheets/d/10VUKvIYZjlbJhE-oCLmInLe601su6vIRBRC… Notes about tabs: - Way to 18.05 : I wanted it "macro functionnal", but currently it lists features or issues that may be too small. I tried to evaluate the work in "complexity point", "1" can be one developper day or maybe more or less; - Questions : can be used as a faq, I dropped my questions, sometimes I answered myself and other time someone else answeredme; - Queries and behaviours : we did a lot of work to implement Solr in Koha (at BibLibre, it begun in 2011) and an advanced search version is always maintained. I think it can be asked, so I pasted a list of queries we work with, it is expected to be different, it is just examples; - Pros : quick list of advantages for ElasticSearch in Koha Please, feel free to read, add lines, add questions or whatever. I am often available on #koha (@clrh). Claire.

2 2

sources gitignore under versionning
by Fridolin SOMERS 05 Apr '18

05 Apr '18

Hi, Since Bug 20267 "Add basic .gitignore", there is a .gitignore in sources under GIT versionning. You may want to add more ignore globally with : https://help.github.com/articles/ignoring-files/#create-a-global-gitignore Or per repository with .git/info/exclude Regards, -- Fridolin SOMERS <fridolin.somers(a)biblibre.com> BibLibre - software and system maintainer

1 1

Write good bug report titles and commit messages
by Jonathan Druart 04 Apr '18

04 Apr '18

Hi devs, I would like to do a little reminder about the bug report titles and commit messages. For bugs: The bug report title must shortly tell what the *bug* is, whereas the commit messages must tell what the *fix* does. Sometimes they are not related at all. For instance: - bug report titles: "Feature X is not working correctly when Y is enabled", "Click on button 'Save' does not save the record", "Saving stuff on screen X does not work", "This script generates error logs", "Mystake is misspelled in this script", "Behaviour X no longer work as expected" etc. - commit messages: "Fix Feature X when Y is enabled", "Make sure behaviour is correct when button is clicked", "Remove warnings from this script", "Correct spelling of mistake in this script", "Fix regression on behaviour X" etc. For enhancements / new feature: We could have the same title and commit messages in some cases. - bug report titles: "Add new awesome feature", "Add the ability to do that", "Code is duplicated in method Koha::Stuff->method" - commit messages: "Add new awesome feature", "Add the ability to do that", "Remove code duplication in method Koha::Stuff->method" Note that "Address comment #42" is a terrible commit message. Then, I would like to standardize the commit messages a bit. We have "Bug 12345 - ", "Bug 12345: ", "Bug 12345" and "[follow-up]", "(follow-up)", "[QA Followup]", etc. I would suggest: "Bug 12345: you commit message" And reject any commit messages with only "follow-up" (or whatever how it is written), but accept "Bug 12345: (follow-up) same commit message as before" If you forgot something, even if "Bug 12345: (follow-up) This was missing" And QA follow-ups (added by QA team member): "Bug 12345: "(QA follow-up) Add/remove this stuff" I am going to suggest these change during the next dev meetings. If accepted I will change the bug report titles and commit messages before the push during few weeks, then ask authors to do it themselves (patches from new contributors will not be rejected for that reason). You should also read or re-read: https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines https://wiki.koha-community.org/wiki/Commit_messages Cheers, Jonathan

6 6

RFC for MARC holdings record support
by Ere Maijala 04 Apr '18

04 Apr '18

Hi Everyone, I've written an RFC for adding support for MARC holdings records, available here: <https://wiki.koha-community.org/wiki/MARC_Holdings_Records_RFC>. I'd be grateful for any feedback on this. I know there have been some initiatives to add (back) holdings records, but this proposal is a bit different in that it relies on the MARC format and I already have it working in a local custom branch apart from OPAC support. Regards, Ere -- Ere Maijala Kansalliskirjasto / The National Library of Finland

3 3

Koha General Meeting Reminder - 4 April 14UTC
by Owen Leonard 03 Apr '18

03 Apr '18

Hello all, This is a reminder that there will be a Koha general IRC meeting in about 24 hours, 4 April at 14UTC. Please add anything you want to discuss to the agenda. Please add your apologies if you can't make the meeting. Local time conversion: https://www.timeanddate.com/worldclock/fixedtime.html?msg=Koha+General+IRC+… Meeting agenda: https://wiki.koha-community.org/wiki/General_IRC_meeting_4_April_2018 See you there, Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org

1 0