February 2020 - Koha-devel - lists.koha-community.org

Coding guidelines
by Marcel de Rooy 17 Feb '20

17 Feb '20

Referring to the dev meeting and bug 22407, I propose the following rewording: PERL15 Using Koha::Object[s] PERL15(a) Code added to the Koha:: namespace should be object-oriented unless there is a very good reason to do otherwise. In that case the reason should be documented clearly. PERL15(b) Code in Koha::Object[s] should normally not refer back to C4. Obviously, this cannot be enforced harshly until the refactoring has been completed. PERL15(c) Use DBIC relations to (pre)fetch a related Koha object rather than searching it explicitly. (See bug 22407) PERL28 Other object oriented code guidelines (in addition to PERL15) I think we need to move the Accessor and idiom for -> new rules from PERL15 to another rule. I opened rule 28 for that depending on discussing the following: Class::Accessor is a great way to provide access to member variables. => My suggestion would be to remove this rule. It is true but we do not say that it is the only way to do it. (We are not even using Class::Accessor in Koha objects.) Or just say PERL28(a) To provide access to member variables, there are several ways including but not limited to using Class::Accessor. A useful idiom for the ->new() routine in object-oriented classes that do not need to process the arguments passed in as a hashref but merely need to save them for future processing => This suggestion is fine. It says use a parameter hash for sub new. We normally do that. Reworded: PERL 28(b) Use a hashref as second parameter in sub new when passing arguments. Any feedback? Marcel Museumstraat 1 Postbus 74888 1070 DN Amsterdam Rijksmuseum.nl Nu te zien: Operatie Nachtwacht Verwacht: Caravaggio-Bernini. Barok in Rome Dankzij Waller 2010-2020 T/m 18 jaar gratis Please think before you print

3 2

Alternative views for search results and detail pages?
by dcook＠prosentient.com.au 17 Feb '20

17 Feb '20

Hi all, What do people think about replacing the XSLTs with Template Toolkit templates for search results and detail pages? Considering that the OPAC Detail XSLT is 2000 lines and the Search Result XSLT is 1500 lines (and that doesn't include the utility XSLT) maybe that's a bit ambitious. The Intranet Search results are 1000 lines and Intranet Detail is 1600 lines. I'm just trying to think of how we could do views for metadata that aren't MARC-centric. Actually, after reviewing the XSLTs, I suppose there's no reason we couldn't expand the XSLTs to include more metadata schema options. We could actually provide any XML and then just do an XSLT template to render it. (After looking at Koha::SearchEngine::Elasticsearch::Search, it looks like we're storing whole MARCXML records in Elasticsearch, and that's what we're fetching from Elasticsearch for Koha to render for views?) Looking at biblio-zebra-indexdefs.xsl and really we could hand that arbitrary XML to index as well. and then worry about C4::Search::getRecords() stuffing the Zebra raw record into the result data structure and C4::Search::searchResults assuming it's a MARCXML record. It's too bad MARC::Record::XML doesn't check for a XML::LibXML object before trying to parse, or we could parse the XML and then just hand the relevant XML to MARC::Record. I mean we could still do that but it would involve double-parsing, which would be a performance hit. Although I imagine Galen wouldn't necessarily be opposed to accepting an update. I mean it would basically be adding the same functionality to Zebra that we have with Elasticsearch, no? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

1 0

Adding peer review status to article records
by dcook＠prosentient.com.au 17 Feb '20

17 Feb '20

Hi all, I have a library interested in adding peer review status to their article records in Koha. The short-term solution is to use a local MARC field and do a code customization for it. However, peer review status is the kind of thing that the library industry will probably see more and more of going forward into the digital future. It seems to me that a long-term solution would be wiser. Sure enough, ExLibris Alma and OCLC WorldCat Discovery already have this functionality: https://help.oclc.org/Discovery_and_Reference/WorldCat_Discovery/Search_resu lts/How_item_bibliographic_data_is_displayed https://knowledge.exlibrisgroup.com/Alma/Release_Notes/010_2018/11_February_ 2018/Alma_February_2018_Release_Notes/02Resource_Management_-_February_2018_ Enhancements#Peer_Review_and_Open_Access OCLC uses a non-MARC method, whereas ExLibris rely on a magic string in a 500 field for peer review status. That being said, I'm not sure what the best long-term solution would be to add this metadata to a bibliographic record. What do you all think? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

1 1

String Freeze Notice
by Joy Nelson 14 Feb '20

14 Feb '20

Greetings! Just a quick note that string freeze will go into effect on 2/15/2020 for the maintenance branches. Maintenance releases scheduled for the 22rd. Happy Valentines Day! -- Joy Nelson President, Koha Division ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>

1 0

Call for news: February 2020 Koha Newsletter
by kohanews 14 Feb '20

14 Feb '20

I'm collecting news for the February newsletter. Send anything noteworthy to: k o h a news AT gmail dot com News criteria: --------------------------- ** For events **: - Please include dates for past events. If I can't find dates I may not add it. - Announcements for future events with dates T.B.A. are fine ...Eg., Kohacon - For past events , **** one month back is the cut-off ****. * News items can be of any length. * Images are fine * Anything and everything Koha. * Submit by the 26th of the month. If you are working on an interesting project or development related to Koha, please let me know and I'll include it in the development section. Thank you! -- Chad Roseburg Editor, Koha Community Newsletter

1 0

issue with kohadevbox
by Hugo Agud 13 Feb '20

13 Feb '20

Good morning I am trying to be ready for tomorrow, I have installed a new kohadev box and in weinstaller I am getting this error Can't locate object method "phases" via package "CPAN::Meta::Prereqs" at /home/vagrant/kohaclone/C4/Installer/PerlModules.pm line 55 - in C4::Installer::PerlModules::versions_info at /home/vagrant/kohaclone/C4/Installer/PerlModules.pm line 55 52: $self->{'upgrade_pm'} = []; 53: $self->{'current_pm'} = []; 54: * 55: foreach my $phase ($self->prereqs->phases) { * 56: foreach my $type ($self->prereqs->types_in($phase)) { 57: my $reqs = $self->prereqs->requirements_for($phase, $type); 58: foreach my $module ($reqs->required_modules) { Show function arguments - in (eval) at /home/vagrant/kohaclone/installer/install.pl line 102 99: } 100: 101: my $perl_modules = C4::Installer::PerlModules->new;* 102: $perl_modules->versions_info; * 103: 104: my $missing_modules = $perl_modules->get_attr('missing_pm'); 105: my $upgrade_modules = $perl_modules->get_attr('upgrade_pm'); I am going to skip web installer -- *Hugo Agud - Orex Digital * *www.orex.es <http://www.orex.es>* <http://www.orex.es/> [image: www.orex.es/koha] <http://www.orex.es/koha> [image: www.orex.es/vufind] <http://www.orex.es/vufind> Director Passeig Comte Vilardaga, 118 3-3 08980 -Sant Feliu de Llobregat - Tel: 933 856 138 hagud(a)orex.es · http://www.orex.es/ No imprima este mensaje a no ser que sea necesario. Una tonelada de papel implica la tala de 15 árboles y el consumo de 250.000 litros de agua. Aviso de confidencialidad Este mensaje contiene información que puede ser CONFIDENCIAL y/o de USO RESTRINGIDO. Si usted no es el receptor deseado del mensaje (ni está autorizado a recibirlo por el remitente), no está autorizado a copiar, reenviar o divulgar el mensaje o su contenido. Si ha recibido este mensaje por error, por favor, notifíquenoslo inmediatamente y bórrelo de su sistema.

2 1

GBSD - Global Bug Squashing Day Tomorrow
by Renvoize, Martin 13 Feb '20

13 Feb '20

Hi All, Just a little reminder we have a global bug squashing day scheduled for tomorrow. I look forward to seeing lots of you on IRC and in the bug mails.. Have a great day :) *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager Community Release Manager (19.11, 20.05) *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize(a)ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info(a)ptfs-europe.com

1 0

Starting/stopping koha-testing-docker
by dcook＠prosentient.com.au 11 Feb '20

11 Feb '20

Hi all, Is there a trick for stopping and starting koha-testing-docker, when using docker-compose, so that you can re-use the same containers? I stop/start containers all the time on other projects, and I swear that Tomas told me how to do it with koha-testing-docker, but koha_koha_1 keeps crashing with "User kohadev-koha already exists" after I try to start it after stopping it, as it's trying to run /kohadevbox/run.sh. Perhaps /kohadevbox/run.sh should have a test where it only tries to do setup if it hasn't already setup the container environment. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595

3 3

hackfest registration
by Paul Poulain 10 Feb '20

10 Feb '20

Hello koha fans, A quick reminder: drop me an email if you plan to come to the hackfest, that will be in March, 23-27, in France, Marseille. Currently, we've people from : Argentina, Canada, Finland, France, Germany, Ireland, Spain, UK, USA. Your country and your contribution is missing !!! As usual, it will be a week of useful work, with a lot of documenting, testing, coding, talking, thinking. And a little bit of eating (cheese) and drinking ( -not only- beer, after work of course) Welcome -- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries

1 0

Re: [Koha-devel] Starting/stopping koha-testing-docker
by dcook＠prosentient.com.au 07 Feb '20

07 Feb '20

Thanks, Tomas, but the issue isn’t the database. I was probably misleading in my original email. The issue is that the /kohadevbox/run.sh script tries to re-provision the koha_koha_1 server, and it fatally fails to do so. Before doing the setup, it should do a test to see if it needs to do the setup. But the --force-recreate option is practical enough for now. If it bothers me enough going forward, I’ll do a patch and send in a pull request for the run.sh script It’s probably not a bad thing to re-create the containers each time just to have a clean code and configuration environment, but it makes long-term work more difficult. Recently, I created a jboss/keycloak container, and I just start/stop that container whenever I need a Keycloak server. Same with a lot of containers I use. Of course, that means it’s easier for untracked localizations to sneak in and then you destroy the container and create a new one and it’s radically different to what you’re using but *shrug*. Anyway, good to know that we can’t stop/start koha-testing-docker. I thought I was missing something, but it just looks like it’s not possible currently. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: Tomas Cohen Arazi <tomascohen(a)theke.io> Sent: Friday, 7 February 2020 10:55 AM To: David Cook <dcook(a)prosentient.com.au> Cc: Agustin Moyano <agustinmoyano(a)theke.io>; koha-devel <koha-devel(a)lists.koha-community.org> Subject: Re: [Koha-devel] Starting/stopping koha-testing-docker There's one alias for persistent db. That might suit you El jue., 6 de febrero de 2020 20:45, <dcook(a)prosentient.com.au <mailto:dcook@prosentient.com.au> > escribió: Hi Agustin, Thanks for your email. However, I think that perhaps you misunderstand me. I’m not trying to re-create the containers; I’m trying to re-use/re-start the existing containers. Your first suggestion will recreate the containers by destroying the old ones. That means I can’t re-use them. Your second suggestion requires the container to be running, but my use case is starting a stopped container, which has been stopped either manually, by a system reboot, or whatever. I suppose I could modify the docker-compose.yml file to have a custom command, and just manually run /kohadevbox/run.sh when I initially create the container… that might be the shortest path to what I’m trying to do. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: Agustin Moyano <agustinmoyano(a)theke.io <mailto:agustinmoyano@theke.io> > Sent: Friday, 7 February 2020 1:12 AM To: dcook(a)prosentient.com.au <mailto:dcook@prosentient.com.au> Cc: koha-devel <koha-devel(a)lists.koha-community.org <mailto:koha-devel@lists.koha-community.org> >; tomascohen(a)theke.io <mailto:tomascohen@theke.io> Subject: Re: [Koha-devel] Starting/stopping koha-testing-docker Hi David, you have 2 ways. First if you started koha-testing-docker using the script alias "ku", the script has the "--force-recreate" flag when it runs.. that means if you kill it, and start it again with ku you wont have any problems. The other way is to not kill the container, but simply do "reset_all" inside docker container... that is basically the same in the way that it will cleanup your database and install everything from scratch. Hope it helps! On Thu, Feb 6, 2020 at 2:16 AM <dcook(a)prosentient.com.au <mailto:dcook@prosentient.com.au> > wrote: Hi all, Is there a trick for stopping and starting koha-testing-docker, when using docker-compose, so that you can re-use the same containers? I stop/start containers all the time on other projects, and I swear that Tomas told me how to do it with koha-testing-docker, but koha_koha_1 keeps crashing with “User kohadev-koha already exists” after I try to start it after stopping it, as it’s trying to run /kohadevbox/run.sh. Perhaps /kohadevbox/run.sh should have a test where it only tries to do setup if it hasn’t already setup the container environment. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 _______________________________________________ Koha-devel mailing list Koha-devel(a)lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

1 0